From: Keith Busch <keith.busch@intel.com>
To: Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org
Cc: Wesley Yung <wesley.yung@microsemi.com>,
Sammy Hui <sammy.hui@intel.com>,
Joseph Gruher <joseph.r.gruher@intel.com>,
Wei Zhang <wzhang@fb.com>, Krishna Dhulipala <krishnad@fb.com>,
Keith Busch <keith.busch@intel.com>
Subject: [PATCH 1/2] pcie/dpc: Skip DPC event if device is not present
Date: Fri, 28 Apr 2017 12:02:48 -0400 [thread overview]
Message-ID: <1493395369-20225-2-git-send-email-keith.busch@intel.com> (raw)
In-Reply-To: <1493395369-20225-1-git-send-email-keith.busch@intel.com>
The DPC interupt may be executed on a device that is being removed. Skip
queuing event handling if the status is all 1's, which should be seen
only if the device is not present.
Signed-off-by: Keith Busch <keith.busch@intel.com>
---
drivers/pci/pcie/pcie-dpc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/pcie/pcie-dpc.c b/drivers/pci/pcie/pcie-dpc.c
index d4d70ef..fc2a4a7 100644
--- a/drivers/pci/pcie/pcie-dpc.c
+++ b/drivers/pci/pcie/pcie-dpc.c
@@ -87,7 +87,7 @@ static irqreturn_t dpc_irq(int irq, void *context)
pci_read_config_word(pdev, dpc->cap_pos + PCI_EXP_DPC_STATUS, &status);
pci_read_config_word(pdev, dpc->cap_pos + PCI_EXP_DPC_SOURCE_ID,
&source);
- if (!status)
+ if (!status || status == (u16)(~0))
return IRQ_NONE;
dev_info(&dpc->dev->device, "DPC containment event, status:%#06x source:%#06x\n",
--
2.7.2
next prev parent reply other threads:[~2017-04-28 15:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 16:02 [PATCH 0/2] pcie/dpc: Fixes Keith Busch
2017-04-28 16:02 ` Keith Busch [this message]
2017-05-10 3:39 ` [PATCH 1/2] pcie/dpc: Skip DPC event if device is not present Wei Zhang
2017-05-10 13:17 ` Keith Busch
2017-05-10 14:16 ` Wesley Yung
2017-05-10 16:35 ` Wei Zhang
2017-05-10 16:44 ` Keith Busch
2017-05-10 16:43 ` Wesley Yung
2017-05-10 16:52 ` Wesley Yung
2017-05-10 17:42 ` Keith Busch
2017-04-28 16:02 ` [PATCH 2/2] pcie/dpc: Fix control register setting Keith Busch
2017-05-22 23:43 ` [PATCH 0/2] pcie/dpc: Fixes Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493395369-20225-2-git-send-email-keith.busch@intel.com \
--to=keith.busch@intel.com \
--cc=bhelgaas@google.com \
--cc=joseph.r.gruher@intel.com \
--cc=krishnad@fb.com \
--cc=linux-pci@vger.kernel.org \
--cc=sammy.hui@intel.com \
--cc=wesley.yung@microsemi.com \
--cc=wzhang@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.