From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2998963AbdD1SYh (ORCPT ); Fri, 28 Apr 2017 14:24:37 -0400 Received: from smtprelay0229.hostedemail.com ([216.40.44.229]:46178 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1163128AbdD1SYb (ORCPT ); Fri, 28 Apr 2017 14:24:31 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2691:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:5007:6691:7875:9707:10004:10400:10848:11232:11658:11914:12740:12760:12895:13069:13095:13161:13229:13255:13311:13357:13439:14096:14097:14659:21080:21326:21433:30012:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: chain14_7d3fbd367d309 X-Filterd-Recvd-Size: 2050 Message-ID: <1493403858.1873.5.camel@perches.com> Subject: Re: [PATCH] checkpatch: don't encourage new code to use "networking" style comments From: Joe Perches To: Brian Norris , Andy Whitcroft Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Herbert Xu , Ingo Molnar , Andrew Morton Date: Fri, 28 Apr 2017 11:24:18 -0700 In-Reply-To: <20170428175547.61114-1-briannorris@chromium.org> References: <20170428175547.61114-1-briannorris@chromium.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-04-28 at 10:55 -0700, Brian Norris wrote: > Our glorious leader has made his opinion known [1]: the "networking" > comment style is not useful for new code. and yet nothing was done. I think _very_ few people concern themselves one way or another. I believe the only person that actually cares about the networking comment style is David Miller. > While the same rules as usual > still apply -- e.g., don't unnecessarily churn existing code, and follow > existing practice within files -- that doesn't mean that checkpatch > should be enforcing that for entire directories. Among other reasons, > this can cause automatic patch generators to do the exact wrong thing: > convert perfectly good existing code into the "networking style", just > because it's in a similar directory. I believe the patch generator you are referring to is checkpatch. And checkpatch doesn't actually offer to "--fix" any comment style. It just bleats a message. I don't know of another tool that proposes patches that vary comment styles based on directory.