From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1948113AbdD1VF3 (ORCPT ); Fri, 28 Apr 2017 17:05:29 -0400 Received: from smtprelay0197.hostedemail.com ([216.40.44.197]:39151 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S938643AbdD1VFZ (ORCPT ); Fri, 28 Apr 2017 17:05:25 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3351:3622:3653:3865:3867:3868:3870:3871:3872:4321:5007:7903:9707:10004:10400:10413:10848:11232:11658:11914:12049:12555:12740:12760:12895:13069:13255:13311:13357:13439:14659:21080:30012:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: band87_4bbe7416df055 X-Filterd-Recvd-Size: 1534 Message-ID: <1493413518.1873.9.camel@perches.com> Subject: Re: [PATCH] checkpatch: don't encourage new code to use "networking" style comments From: Joe Perches To: Brian Norris , David Miller Cc: apw@canonical.com, linux-kernel@vger.kernel.org, herbert@gondor.apana.org.au, mingo@redhat.com, akpm@linux-foundation.org Date: Fri, 28 Apr 2017 14:05:18 -0700 In-Reply-To: <20170428195131.GA73503@google.com> References: <20170428175547.61114-1-briannorris@chromium.org> <1493403858.1873.5.camel@perches.com> <20170428192721.GA72697@google.com> <20170428.153133.431048256400360136.davem@davemloft.net> <20170428195131.GA73503@google.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-04-28 at 12:51 -0700, Brian Norris wrote: > FWIW, I don't see this consistently applied at all. Unless my regexes > are completely wrong [*], it's roughly 50/50 in drivers/net/ and net/, > and roughly 40/60 (favoring "net" style) in net/core/. More like 5:1 in net/ $ git grep -E -n "/\*[ \t]*\w" net | grep -v ":1:" | wc -l 30461 $ git grep -E -n "/\*[ \t]*$" net | grep -v ":1:" | wc -l 6061 grep -v ":1:" is to avoid the first line in the file comment