From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH 0/3] dynamic_hex_dump cleanup Date: Fri, 28 Apr 2017 15:31:54 -0700 Message-ID: <1493418714.1873.18.camel@perches.com> References: <149341493336.35578.13631055553267152302.stgit@dwillia2-desk3.amr.corp.intel.com> <1493416143.1873.13.camel@perches.com> <1493417230.1873.15.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: Dan Williams Cc: Ohad Ben-Cohen , "linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org" , linux-remoteproc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Bjorn Andersson , Linux ACPI , Jason Baron List-Id: linux-acpi@vger.kernel.org On Fri, 2017-04-28 at 15:19 -0700, Dan Williams wrote: > On Fri, Apr 28, 2017 at 3:14 PM, Dan Williams wrote: > > On Fri, Apr 28, 2017 at 3:07 PM, Joe Perches wrote: > > > On Fri, 2017-04-28 at 14:52 -0700, Dan Williams wrote: > > > > On Fri, Apr 28, 2017 at 2:49 PM, Joe Perches wrote: > > > > > On Fri, 2017-04-28 at 14:28 -0700, Dan Williams wrote: > > > > > > More than one driver has worked around the fact that > > > > > > print_hex_dump_debug() requires CONFIG_DYNAMIC_DEBUG=y to build. > > > > > > > > > > No it doesn't. builds work fine. Output is restricted. > > > > > > > > > > > Provide a dynamic_hex_dump() so that drivers that want the extra debugging to be > > > > > > turned off in the CONFIG_DYNAMIC_DEBUG=n can use dynamic_hex_dump() > > > > > > directly. > > > > > > > > > > I think the concept is unnecessary > > > > > . > > > > > Just use print_hex_dump with KERN_DEBUG. > > > > > > > > No, we don't want any possibility of output in the > > > > CONFIG_DYNAMIC_DEBUG=n case. This is extra debug that only makes sense > > > > in the CONFIG_DYNAMIC_DEBUG case. > > > > > > No, that doesn't work the same. > > > > > > Look at your conversion of drivers/acpi/nfit/core.c > > > > > > dev_dbg outputs always when DEBUG is defined and > > > optionally outputs when CONFIG_DYNAMIC_DEBUG is enabled. > > > > Right, that's what I want dev_dbg() to output at KERN_DEBUG level > > always and the hexdump only in the dynamic case. > > Joe, I'm trying to understand your objection. What you are proposing > is that the debug output is present at the KERN_DEBUG level in the > CONFIG_DYNAMIC_DEBUG=n case and that's not what either use case wants. > What breaks by letting users call dynamic_hex_dump() directly? Call it hex_dump_dbg and I have no objections. The "dynamicism" is a side effect of not having DEBUG defined. dev_dbg will emit if DEBUG is declared regardless of dynamic_debug. This new function should have the same behavior. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtprelay.hostedemail.com (smtprelay0168.hostedemail.com [216.40.44.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 74DE721A0480F for ; Fri, 28 Apr 2017 15:36:18 -0700 (PDT) Message-ID: <1493418714.1873.18.camel@perches.com> Subject: Re: [PATCH 0/3] dynamic_hex_dump cleanup From: Joe Perches Date: Fri, 28 Apr 2017 15:31:54 -0700 In-Reply-To: References: <149341493336.35578.13631055553267152302.stgit@dwillia2-desk3.amr.corp.intel.com> <1493416143.1873.13.camel@perches.com> <1493417230.1873.15.camel@perches.com> Mime-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Dan Williams Cc: Ohad Ben-Cohen , "linux-nvdimm@lists.01.org" , linux-remoteproc@vger.kernel.org, "linux-kernel@vger.kernel.org" , Bjorn Andersson , Linux ACPI , Jason Baron List-ID: On Fri, 2017-04-28 at 15:19 -0700, Dan Williams wrote: > On Fri, Apr 28, 2017 at 3:14 PM, Dan Williams wrote: > > On Fri, Apr 28, 2017 at 3:07 PM, Joe Perches wrote: > > > On Fri, 2017-04-28 at 14:52 -0700, Dan Williams wrote: > > > > On Fri, Apr 28, 2017 at 2:49 PM, Joe Perches wrote: > > > > > On Fri, 2017-04-28 at 14:28 -0700, Dan Williams wrote: > > > > > > More than one driver has worked around the fact that > > > > > > print_hex_dump_debug() requires CONFIG_DYNAMIC_DEBUG=y to build. > > > > > > > > > > No it doesn't. builds work fine. Output is restricted. > > > > > > > > > > > Provide a dynamic_hex_dump() so that drivers that want the extra debugging to be > > > > > > turned off in the CONFIG_DYNAMIC_DEBUG=n can use dynamic_hex_dump() > > > > > > directly. > > > > > > > > > > I think the concept is unnecessary > > > > > . > > > > > Just use print_hex_dump with KERN_DEBUG. > > > > > > > > No, we don't want any possibility of output in the > > > > CONFIG_DYNAMIC_DEBUG=n case. This is extra debug that only makes sense > > > > in the CONFIG_DYNAMIC_DEBUG case. > > > > > > No, that doesn't work the same. > > > > > > Look at your conversion of drivers/acpi/nfit/core.c > > > > > > dev_dbg outputs always when DEBUG is defined and > > > optionally outputs when CONFIG_DYNAMIC_DEBUG is enabled. > > > > Right, that's what I want dev_dbg() to output at KERN_DEBUG level > > always and the hexdump only in the dynamic case. > > Joe, I'm trying to understand your objection. What you are proposing > is that the debug output is present at the KERN_DEBUG level in the > CONFIG_DYNAMIC_DEBUG=n case and that's not what either use case wants. > What breaks by letting users call dynamic_hex_dump() directly? Call it hex_dump_dbg and I have no objections. The "dynamicism" is a side effect of not having DEBUG defined. dev_dbg will emit if DEBUG is declared regardless of dynamic_debug. This new function should have the same behavior. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <1493418714.1873.18.camel@perches.com> Subject: Re: [PATCH 0/3] dynamic_hex_dump cleanup From: Joe Perches Date: Fri, 28 Apr 2017 15:31:54 -0700 In-Reply-To: References: <149341493336.35578.13631055553267152302.stgit@dwillia2-desk3.amr.corp.intel.com> <1493416143.1873.13.camel@perches.com> <1493417230.1873.15.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit To: Dan Williams Cc: "linux-nvdimm@lists.01.org" , Ohad Ben-Cohen , linux-remoteproc@vger.kernel.org, "linux-kernel@vger.kernel.org" , Bjorn Andersson , Linux ACPI , Jason Baron List-ID: On Fri, 2017-04-28 at 15:19 -0700, Dan Williams wrote: > On Fri, Apr 28, 2017 at 3:14 PM, Dan Williams wrote: > > On Fri, Apr 28, 2017 at 3:07 PM, Joe Perches wrote: > > > On Fri, 2017-04-28 at 14:52 -0700, Dan Williams wrote: > > > > On Fri, Apr 28, 2017 at 2:49 PM, Joe Perches wrote: > > > > > On Fri, 2017-04-28 at 14:28 -0700, Dan Williams wrote: > > > > > > More than one driver has worked around the fact that > > > > > > print_hex_dump_debug() requires CONFIG_DYNAMIC_DEBUG=y to build. > > > > > > > > > > No it doesn't. builds work fine. Output is restricted. > > > > > > > > > > > Provide a dynamic_hex_dump() so that drivers that want the extra debugging to be > > > > > > turned off in the CONFIG_DYNAMIC_DEBUG=n can use dynamic_hex_dump() > > > > > > directly. > > > > > > > > > > I think the concept is unnecessary > > > > > . > > > > > Just use print_hex_dump with KERN_DEBUG. > > > > > > > > No, we don't want any possibility of output in the > > > > CONFIG_DYNAMIC_DEBUG=n case. This is extra debug that only makes sense > > > > in the CONFIG_DYNAMIC_DEBUG case. > > > > > > No, that doesn't work the same. > > > > > > Look at your conversion of drivers/acpi/nfit/core.c > > > > > > dev_dbg outputs always when DEBUG is defined and > > > optionally outputs when CONFIG_DYNAMIC_DEBUG is enabled. > > > > Right, that's what I want dev_dbg() to output at KERN_DEBUG level > > always and the hexdump only in the dynamic case. > > Joe, I'm trying to understand your objection. What you are proposing > is that the debug output is present at the KERN_DEBUG level in the > CONFIG_DYNAMIC_DEBUG=n case and that's not what either use case wants. > What breaks by letting users call dynamic_hex_dump() directly? Call it hex_dump_dbg and I have no objections. The "dynamicism" is a side effect of not having DEBUG defined. dev_dbg will emit if DEBUG is declared regardless of dynamic_debug. This new function should have the same behavior. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1036231AbdD1Wgf (ORCPT ); Fri, 28 Apr 2017 18:36:35 -0400 Received: from smtprelay0051.hostedemail.com ([216.40.44.51]:46211 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1034257AbdD1WgZ (ORCPT ); Fri, 28 Apr 2017 18:36:25 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2692:2693:2828:3138:3139:3140:3141:3142:3354:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4250:4321:5007:7903:8660:10004:10400:10848:11026:11232:11473:11658:11914:12296:12438:12663:12740:12760:12895:13148:13161:13229:13230:13439:13618:14096:14097:14181:14659:14721:21063:21080:21433:30054:30064:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: chalk92_684454b6cf507 X-Filterd-Recvd-Size: 3421 Message-ID: <1493418714.1873.18.camel@perches.com> Subject: Re: [PATCH 0/3] dynamic_hex_dump cleanup From: Joe Perches To: Dan Williams Cc: "linux-nvdimm@lists.01.org" , Ohad Ben-Cohen , linux-remoteproc@vger.kernel.org, "linux-kernel@vger.kernel.org" , Bjorn Andersson , Linux ACPI , Jason Baron Date: Fri, 28 Apr 2017 15:31:54 -0700 In-Reply-To: References: <149341493336.35578.13631055553267152302.stgit@dwillia2-desk3.amr.corp.intel.com> <1493416143.1873.13.camel@perches.com> <1493417230.1873.15.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-04-28 at 15:19 -0700, Dan Williams wrote: > On Fri, Apr 28, 2017 at 3:14 PM, Dan Williams wrote: > > On Fri, Apr 28, 2017 at 3:07 PM, Joe Perches wrote: > > > On Fri, 2017-04-28 at 14:52 -0700, Dan Williams wrote: > > > > On Fri, Apr 28, 2017 at 2:49 PM, Joe Perches wrote: > > > > > On Fri, 2017-04-28 at 14:28 -0700, Dan Williams wrote: > > > > > > More than one driver has worked around the fact that > > > > > > print_hex_dump_debug() requires CONFIG_DYNAMIC_DEBUG=y to build. > > > > > > > > > > No it doesn't. builds work fine. Output is restricted. > > > > > > > > > > > Provide a dynamic_hex_dump() so that drivers that want the extra debugging to be > > > > > > turned off in the CONFIG_DYNAMIC_DEBUG=n can use dynamic_hex_dump() > > > > > > directly. > > > > > > > > > > I think the concept is unnecessary > > > > > . > > > > > Just use print_hex_dump with KERN_DEBUG. > > > > > > > > No, we don't want any possibility of output in the > > > > CONFIG_DYNAMIC_DEBUG=n case. This is extra debug that only makes sense > > > > in the CONFIG_DYNAMIC_DEBUG case. > > > > > > No, that doesn't work the same. > > > > > > Look at your conversion of drivers/acpi/nfit/core.c > > > > > > dev_dbg outputs always when DEBUG is defined and > > > optionally outputs when CONFIG_DYNAMIC_DEBUG is enabled. > > > > Right, that's what I want dev_dbg() to output at KERN_DEBUG level > > always and the hexdump only in the dynamic case. > > Joe, I'm trying to understand your objection. What you are proposing > is that the debug output is present at the KERN_DEBUG level in the > CONFIG_DYNAMIC_DEBUG=n case and that's not what either use case wants. > What breaks by letting users call dynamic_hex_dump() directly? Call it hex_dump_dbg and I have no objections. The "dynamicism" is a side effect of not having DEBUG defined. dev_dbg will emit if DEBUG is declared regardless of dynamic_debug. This new function should have the same behavior.