From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from g2t2353.austin.hpe.com (g2t2353.austin.hpe.com [15.233.44.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AAB9B21A0480F for ; Fri, 28 Apr 2017 15:41:56 -0700 (PDT) From: "Kani, Toshimitsu" Subject: Re: [PATCH 1/2] libnvdimm: fix clear length of nvdimm_forget_poison() Date: Fri, 28 Apr 2017 22:41:53 +0000 Message-ID: <1493419278.30303.8.camel@hpe.com> References: <20170427225706.26791-1-toshi.kani@hpe.com> <1493418523.30303.6.camel@hpe.com> In-Reply-To: Content-Language: en-US Content-ID: MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "dan.j.williams@intel.com" Cc: "linux-kernel@vger.kernel.org" , "linux-nvdimm@lists.01.org" List-ID: T24gRnJpLCAyMDE3LTA0LTI4IGF0IDE1OjM5IC0wNzAwLCBEYW4gV2lsbGlhbXMgd3JvdGU6DQo+ IE9uIEZyaSwgQXByIDI4LCAyMDE3IGF0IDM6MjkgUE0sIEthbmksIFRvc2hpbWl0c3UgPHRvc2hp LmthbmlAaHBlLmNvbQ0KPiA+IHdyb3RlOg0KPiA+IE9uIEZyaSwgMjAxNy0wNC0yOCBhdCAxNDo0 OCAtMDcwMCwgRGFuIFdpbGxpYW1zIHdyb3RlOg0KPiA+ID4gT24gVGh1LCBBcHIgMjcsIDIwMTcg YXQgMzo1NyBQTSwgVG9zaGkgS2FuaSA8dG9zaGkua2FuaUBocGUuY29tPg0KIDoNCj4gPiA+ID4g DQo+ID4gPiA+IC3CoMKgwqDCoMKgwqDCoG52ZGltbV9mb3JnZXRfcG9pc29uKG52ZGltbV9idXMs IHBoeXMsIGxlbik7DQo+ID4gPiA+ICvCoMKgwqDCoMKgwqDCoGlmIChjbGVhcl9lcnIuY2xlYXJl ZCA+IDApDQo+ID4gPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBudmRpbW1fZm9y Z2V0X3BvaXNvbihudmRpbW1fYnVzLCBwaHlzLA0KPiA+ID4gPiBjbGVhcl9lcnIuY2xlYXJlZCk7 DQo+ID4gPiA+ICsNCj4gPiA+ID4gwqDCoMKgwqDCoMKgwqDCoHJldHVybiBjbGVhcl9lcnIuY2xl YXJlZDsNCj4gPiA+IA0KPiA+ID4gTG9va3MsIGdvb2Qgd2UgbmVlZCB0byBtYXJrIHRoaXMgZm9y IC1zdGFibGUgc2luY2UgdGhlIGJ1ZyBpcw0KPiA+ID4gYWxzbyBwcmVzZW50IGluIGN1cnJlbnQg bWFpbmxpbmUuDQo+ID4gPiANCj4gPiA+IEZpeGVzOiBlMDQ2MTE0YWY1ZmMgKCJsaWJudmRpbW06 IGNsZWFyIHRoZSBpbnRlcm5hbCBwb2lzb25fbGlzdA0KPiA+ID4gd2hlbiBjbGVhcmluZyBiYWRi bG9ja3MiKQ0KPiA+IA0KPiA+IFNoYWxsIEkgc2VuZCBhIHBhdGNoIGJhc2VkIG9uIHRoZSBjdXJy ZW50IG1haW5saW5lIHdpdGggY2MgdG8NCj4gPiAtc3RhYmxlPyAgVGhlIGZ1bmMgbmFtZSBpcyBu dmRpbW1fY2xlYXJfZnJvbV9wb2lzb25fbGlzdCgpIGluIHRoZQ0KPiA+IG1haW5saW5lLg0KPiAN Cj4gSSB0aGlua3MgaXQncyB0b28gbGF0ZSB0byBnZXQgYSBmaXggaW50byA0LjExLCBlc3BlY2lh bGx5IHdoZW4gdGhpcw0KPiB3ZW50IGluIGJyb2tlbiBhbmQgbm90IGEgcmVncmVzc2lvbi4gSSds bCBqdXN0IHRhZyB0aGlzIGZvciAtc3RhYmxlDQo+IGFuZCBoYW5kbGUgdGhlIGJhY2twb3J0IG1h bnVhbGx5Lg0KDQpTb3VuZHMgZ3JlYXQuIFRoYW5rcyBEYW4hDQotVG9zaGkNCg0KDQpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1udmRpbW0gbWFp bGluZyBsaXN0CkxpbnV4LW52ZGltbUBsaXN0cy4wMS5vcmcKaHR0cHM6Ly9saXN0cy4wMS5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1udmRpbW0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1165238AbdD1WmC (ORCPT ); Fri, 28 Apr 2017 18:42:02 -0400 Received: from g2t2353.austin.hpe.com ([15.233.44.26]:14709 "EHLO g2t2353.austin.hpe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1035275AbdD1Wl5 (ORCPT ); Fri, 28 Apr 2017 18:41:57 -0400 From: "Kani, Toshimitsu" To: "dan.j.williams@intel.com" CC: "linux-kernel@vger.kernel.org" , "dave.jiang@intel.com" , "linux-nvdimm@lists.01.org" , "vishal.l.verma@intel.com" Subject: Re: [PATCH 1/2] libnvdimm: fix clear length of nvdimm_forget_poison() Thread-Topic: [PATCH 1/2] libnvdimm: fix clear length of nvdimm_forget_poison() Thread-Index: AQHSv6m7gGeP0lAs30ynvJerDiEMOqHbUueAgAALW4CAAALjgIAAAKEA Date: Fri, 28 Apr 2017 22:41:53 +0000 Message-ID: <1493419278.30303.8.camel@hpe.com> References: <20170427225706.26791-1-toshi.kani@hpe.com> <1493418523.30303.6.camel@hpe.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=hpe.com; x-originating-ip: [15.219.163.8] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AT5PR84MB0259;7:vkVVwuhe0G1RGWgEbj0jd3wH8PBrlqcJ1GFLUKxm1N/5mH34XQHZJR4qbi6zzEmJewSPYxWL5t8KzD6EWIZO4Z8ntAuo90uhabORrGfbP2iBG456mj3pYZb6kNcSBYc5X8TKpYHJ8HlIBXLiNmtjM2GSACz/LtiDgJAKU8ITcuQh8pTtKl8y/IvziRDyYGpy9noj5Gf9+H1y9yW6bKg7eHXGY6IYO1VT/lPUJVL+UWg9ys4he3BlerhIyOqNk6qsQDqRmDFXVeoaF8BtZC98JE2IHCFsfeWGQzs7BRPJ8sHAvbdYTJzS8fNrRpYnMYu3QEGHgynEDD+3Vw5gvpxqXQ== x-ms-office365-filtering-correlation-id: 59b54b1d-8051-4740-b116-08d48e87c475 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081)(201702281549075);SRVR:AT5PR84MB0259; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(227479698468861); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123562025)(20161123564025)(20161123555025)(6072148);SRVR:AT5PR84MB0259;BCL:0;PCL:0;RULEID:;SRVR:AT5PR84MB0259; x-forefront-prvs: 029174C036 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39410400002)(39400400002)(39850400002)(39450400003)(39840400002)(39860400002)(377454003)(377424004)(24454002)(2351001)(122556002)(6486002)(2950100002)(6436002)(33646002)(77096006)(54906002)(6506006)(189998001)(5640700003)(102836003)(2501003)(6116002)(305945005)(5660300001)(7736002)(3846002)(66066001)(50986999)(25786009)(76176999)(93886004)(53546009)(54356999)(3280700002)(4326008)(38730400002)(3660700001)(103116003)(2900100001)(53936002)(81166006)(8676002)(2906002)(8936002)(86362001)(229853002)(6246003)(36756003)(6916009)(6512007);DIR:OUT;SFP:1102;SCL:1;SRVR:AT5PR84MB0259;H:AT5PR84MB0260.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2017 22:41:53.2609 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: AT5PR84MB0259 X-OriginatorOrg: hpe.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v3SMg87P031580 On Fri, 2017-04-28 at 15:39 -0700, Dan Williams wrote: > On Fri, Apr 28, 2017 at 3:29 PM, Kani, Toshimitsu > wrote: > > On Fri, 2017-04-28 at 14:48 -0700, Dan Williams wrote: > > > On Thu, Apr 27, 2017 at 3:57 PM, Toshi Kani : > > > > > > > > -       nvdimm_forget_poison(nvdimm_bus, phys, len); > > > > +       if (clear_err.cleared > 0) > > > > +               nvdimm_forget_poison(nvdimm_bus, phys, > > > > clear_err.cleared); > > > > + > > > >         return clear_err.cleared; > > > > > > Looks, good we need to mark this for -stable since the bug is > > > also present in current mainline. > > > > > > Fixes: e046114af5fc ("libnvdimm: clear the internal poison_list > > > when clearing badblocks") > > > > Shall I send a patch based on the current mainline with cc to > > -stable? The func name is nvdimm_clear_from_poison_list() in the > > mainline. > > I thinks it's too late to get a fix into 4.11, especially when this > went in broken and not a regression. I'll just tag this for -stable > and handle the backport manually. Sounds great. Thanks Dan! -Toshi