diff for duplicates of <1493508775.25397.26.camel@buserror.net> diff --git a/a/1.txt b/N1/1.txt index fa8476f..37c656a 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -6,22 +6,22 @@ You mean unsigned long msecs? > > Signed-off-by: Karim Eshapa <karim.eshapa@gmail.com> > --- -> drivers/soc/fsl/qbman/qman.c | 2 +- -> 1 file changed, 1 insertion(+), 1 deletion(-) +> ?drivers/soc/fsl/qbman/qman.c | 2 +- +> ?1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c > index e0df4d1..6e1a44a 100644 > --- a/drivers/soc/fsl/qbman/qman.c > +++ b/drivers/soc/fsl/qbman/qman.c > @@ -1084,7 +1084,7 @@ static int drain_mr_fqrni(struct qm_portal *p) -> * entries well before the ring has been fully consumed, so -> * we're being *really* paranoid here. -> */ +> ? ?* entries well before the ring has been fully consumed, so +> ? ?* we're being *really* paranoid here. +> ? ?*/ > - unsigned int udel_time = jiffies_to_usecs(10000); > + unsigned long udel_time = jiffies_to_usecs(10000); -> -> usleep_range(udel_time/2, udel_time); -> msg = qm_mr_current(p); +> ? +> ? usleep_range(udel_time/2, udel_time); +> ? msg = qm_mr_current(p); If unsigned int isn't big enough, then unsigned long won't be either on 32- bit. With such a long delay why not use msleep()? diff --git a/a/content_digest b/N1/content_digest index 00c2056..a385bbf 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,15 +1,9 @@ "ref\01493495164-8658-1-git-send-email-karim.eshapa@gmail.com\0" "ref\01493498620-9975-1-git-send-email-karim.eshapa@gmail.com\0" - "From\0Scott Wood <oss@buserror.net>\0" - "Subject\0Re: [PATCH] drivers:soc:fsl:qbman:qman.c: unsigned long jiffies value.\0" + "From\0oss@buserror.net (Scott Wood)\0" + "Subject\0[PATCH] drivers:soc:fsl:qbman:qman.c: unsigned long jiffies value.\0" "Date\0Sat, 29 Apr 2017 18:32:55 -0500\0" - "To\0Karim Eshapa <karim.eshapa@gmail.com>\0" - "Cc\0claudiu.manoil@nxp.com" - roy.pledge@nxp.com - colin.king@canonical.com - linuxppc-dev@lists.ozlabs.org - linux-arm-kernel@lists.infradead.org - " linux-kernel@vger.kernel.org\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On Sat, 2017-04-29 at 22:43 +0200, Karim Eshapa wrote:\n" @@ -20,22 +14,22 @@ "> \n" "> Signed-off-by: Karim Eshapa <karim.eshapa@gmail.com>\n" "> ---\n" - "> \302\240drivers/soc/fsl/qbman/qman.c | 2 +-\n" - "> \302\2401 file changed, 1 insertion(+), 1 deletion(-)\n" + "> ?drivers/soc/fsl/qbman/qman.c | 2 +-\n" + "> ?1 file changed, 1 insertion(+), 1 deletion(-)\n" "> \n" "> diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c\n" "> index e0df4d1..6e1a44a 100644\n" "> --- a/drivers/soc/fsl/qbman/qman.c\n" "> +++ b/drivers/soc/fsl/qbman/qman.c\n" "> @@ -1084,7 +1084,7 @@ static int drain_mr_fqrni(struct qm_portal *p)\n" - "> \302\240\t\t\302\240* entries well before the ring has been fully consumed, so\n" - "> \302\240\t\t\302\240* we're being *really* paranoid here.\n" - "> \302\240\t\t\302\240*/\n" + "> ?\t\t?* entries well before the ring has been fully consumed, so\n" + "> ?\t\t?* we're being *really* paranoid here.\n" + "> ?\t\t?*/\n" "> -\t\tunsigned int udel_time = jiffies_to_usecs(10000);\n" "> +\t\tunsigned long udel_time = jiffies_to_usecs(10000);\n" - "> \302\240\n" - "> \302\240\t\tusleep_range(udel_time/2, udel_time);\n" - "> \302\240\t\tmsg = qm_mr_current(p);\n" + "> ?\n" + "> ?\t\tusleep_range(udel_time/2, udel_time);\n" + "> ?\t\tmsg = qm_mr_current(p);\n" "\n" "If unsigned int isn't big enough, then unsigned long won't be either on 32-\n" "bit. With such a long delay why not use msleep()?\n" @@ -55,4 +49,4 @@ "[1] When fixing a patch you've already posted that hasn't yet been applied,\n" send a replacement (v2) patch rather than a separate fix. -c025340d8f52b0e8b8bde9a2b38296c10aa65008357b067f2e2ea6bc9c0a6f59 +01c5279a9b8ce5759229d147c5b10e519805298042a58577facb7469d749b41d
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.