From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from g4t3425.houston.hpe.com (g4t3425.houston.hpe.com [15.241.140.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B70462195DA43 for ; Mon, 1 May 2017 08:05:50 -0700 (PDT) From: "Kani, Toshimitsu" Subject: Re: [PATCH 2/2] libnvdimm: clear region badblock in nvdimm_clear_poison() Date: Mon, 1 May 2017 15:05:46 +0000 Message-ID: <1493651145.30303.13.camel@hpe.com> References: <20170427225706.26791-1-toshi.kani@hpe.com> <20170427225706.26791-2-toshi.kani@hpe.com> In-Reply-To: Content-Language: en-US Content-ID: <969166676757964D8986BBE663CEF769@NAMPRD84.PROD.OUTLOOK.COM> MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "dan.j.williams@intel.com" Cc: "linux-kernel@vger.kernel.org" , "linux-nvdimm@lists.01.org" List-ID: T24gRnJpLCAyMDE3LTA0LTI4IGF0IDE3OjM1IC0wNzAwLCBEYW4gV2lsbGlhbXMgd3JvdGU6DQo+ IE9uIEZyaSwgQXByIDI4LCAyMDE3IGF0IDU6MTIgUE0sIERhbiBXaWxsaWFtcyA8ZGFuLmoud2ls bGlhbXNAaW50ZWwuYw0KPiBvbT4gd3JvdGU6DQo+ID4gT24gRnJpLCBBcHIgMjgsIDIwMTcgYXQg NToxMCBQTSwgRGFuIFdpbGxpYW1zIDxkYW4uai53aWxsaWFtc0BpbnRlbA0KPiA+IC5jb20+IHdy b3RlOg0KPiA+ID4gT24gVGh1LCBBcHIgMjcsIDIwMTcgYXQgMzo1NyBQTSwgVG9zaGkgS2FuaSA8 dG9zaGkua2FuaUBocGUuY29tPg0KPiA+ID4gd3JvdGU6DQo+ID4gPiA+IEJhZGJsb2NrcyBhcmUg dHJhY2tlZCBhdCBib3RoIHJlZ2lvbiBhbmQgZGV2aWNlIGxldmVscy4NCj4gPiA+ID4gcG1lbV9j bGVhcl9wb2lzb24oKSBhbmQgbnNpb19yd19ieXRlcygpIGNhbGwNCj4gPiA+ID4gbnZkaW1tX2Ns ZWFyX3BvaXNvbigpIGFuZCB0aGVuIGJhZGJsb2Nrc19jbGVhcigpIHRvIGNsZWFyDQo+ID4gPiA+ IGJhZGJsb2NrcyBhdCB0aGUgZGV2aWNlIGxldmVsLiBIb3dldmVyLCBpdCBkb2VzIG5vdCB1cGRh dGUNCj4gPiA+ID4gYmFkYmxvY2tzIGF0IHRoZSByZWdpb24gbGV2ZWwsIHdoaWNoIG1ha2VzIHRo ZW0gaW5jb25zaXN0ZW50Lg0KPiA+ID4gPiANCj4gPiA+ID4gQ2hhbmdlIG52ZGltbV9jbGVhcl9w b2lzb24oKSB0byB1cGRhdGUgYmFja2Jsb2NrcyBhdCB0aGUgcmVnaW9uDQo+ID4gPiA+IGxldmVs IHRvIGtlZXAgdGhlbSBjb25zaXN0ZW50Lg0KPiA+ID4gPiANCj4gPiA+ID4gU2lnbmVkLW9mZi1i eTogVG9zaGkgS2FuaSA8dG9zaGkua2FuaUBocGUuY29tPg0KPiA+ID4gPiBDYzogRGFuIFdpbGxp YW1zIDxkYW4uai53aWxsaWFtc0BpbnRlbC5jb20+DQo+ID4gPiA+IENjOiBEYXZlIEppYW5nIDxk YXZlLmppYW5nQGludGVsLmNvbT4NCj4gPiA+ID4gQ2M6IFZpc2hhbCBWZXJtYSA8dmlzaGFsLmwu dmVybWFAaW50ZWwuY29tPg0KPiA+ID4gDQo+ID4gPiBUaGlzIGxvb2tzIGdvb2QsIGFuZCBpdCBz ZWVtcyB3ZSBoYXZlIGEgYnVnIGluIHRoZSBvdGhlciBsb2NhdGlvbg0KPiA+ID4gdGhhdCBkb2Vz IHRoaXMgaW4gX19uZF9pb2N0bCgpLiBUaGF0IG90aGVyIG9uZSBpcyBtaXNzaW5nIHRoZQ0KPiA+ ID4gImNsZWFyX2Vyci5jbGVhcmVkIC8gNTEyIiBjaGVjay4gQ2FuIHlvdSByZXNwaW4gdGhpcyBh bmQgZGVmaW5lIGENCj4gPiA+IGNvbW1vbiBoZWxwZXIgdGhhdCBib3RoIGxvY2F0aW9ucyBjYW4g Y2FsbD8NCj4gPiANCj4gPiBPbiBzZWNvbmQgdGhvdWdodCwgSSdsbCB0YWtlIHRoaXMgYW5kIHNw aW4gbXkgb3duIGNsZWFudXAgLyBmaXggb24NCj4gPiB0b3AuDQo+ID4gDQo+ID4gVGhhbmtzIFRv c2hpIQ0KPiANCj4gLi4uYW5kIEkgbmVlZCB0byBkcm9wIGl0IGFnYWluIGJlY2F1c2UgaXQgY2F1 c2VzIHRoaXM6DQo+IA0KPiBbwqDCoDEwNi45NzQ4ODldIEJVRzogc2xlZXBpbmcgZnVuY3Rpb24g Y2FsbGVkIGZyb20gaW52YWxpZCBjb250ZXh0IGF0DQo+IGtlcm5lbC9sb2NraW5nL211dGV4LmM6 NzQ3DQo+IFvCoMKgMTA2Ljk3NzMyOF0gaW5fYXRvbWljKCk6IDEsIGlycXNfZGlzYWJsZWQoKTog MCwgcGlkOiA1NTg0LCBuYW1lOg0KPiBkZA0KDQpTb3JyeSwgSSBzaG91bGQgaGF2ZSB0ZXN0ZWQg d2l0aCBDT05GSUdfREVCVUdfQVRPTUlDX1NMRUVQIHNldC4gIFRoYW5rcw0KZm9yIHN0cmFpZ2h0 ZW4gaXQgb3V0IGluIHlvdXIgcGF0Y2ghwqANCg0KLVRvc2hpIA0KX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtbnZkaW1tIG1haWxpbmcgbGlzdApM aW51eC1udmRpbW1AbGlzdHMuMDEub3JnCmh0dHBzOi8vbGlzdHMuMDEub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtbnZkaW1tCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757055AbdEAPn1 (ORCPT ); Mon, 1 May 2017 11:43:27 -0400 Received: from g9t1613g.houston.hpe.com ([15.241.32.99]:28153 "EHLO g9t1613g.houston.hpe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751264AbdEAPnW (ORCPT ); Mon, 1 May 2017 11:43:22 -0400 From: "Kani, Toshimitsu" To: "dan.j.williams@intel.com" CC: "linux-kernel@vger.kernel.org" , "dave.jiang@intel.com" , "linux-nvdimm@lists.01.org" , "vishal.l.verma@intel.com" Subject: Re: [PATCH 2/2] libnvdimm: clear region badblock in nvdimm_clear_poison() Thread-Topic: [PATCH 2/2] libnvdimm: clear region badblock in nvdimm_clear_poison() Thread-Index: AQHSv6m1kgFf2Sbn9kC8cbl2A6ROWaHberAAgAAAlYCAAAaMgIAEF6yA Date: Mon, 1 May 2017 15:05:46 +0000 Message-ID: <1493651145.30303.13.camel@hpe.com> References: <20170427225706.26791-1-toshi.kani@hpe.com> <20170427225706.26791-2-toshi.kani@hpe.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=hpe.com; x-originating-ip: [15.203.227.8] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AT5PR84MB0259;7:UjcDAKvBJeVtVTLIctB8A+1FPzTargiKecH9EGON1ytKOksPlBRfI1N/iCsqoMLCnaIGLJlgBkAvc4Cj0fV9T2DenzkTeF7yMIzfcAtgLyo6FYEL9I+h+FRala9VCKF7ZM7a0OBTVR+1o/B0Ucqf1ovaIhuaWQc9SD8dGQzrVN4KV0Uxrhr27h2F7bRPI3xG6OUMLHMWMbnmuDAXITKpxpqWUKdQuGFig5+sVYZt+mcTM7lcyuo0lCP/hwnVCEBJzB6ChzFwdHU7UIWqiQd8chVusZN35hYpXpums1PIyfFi2Txds6lY4GqvCWOAcC+g909MvdJaRH9wTZYZ33qUZQ== x-ms-office365-filtering-correlation-id: 90fdff8b-bb75-4262-c63b-08d490a38c15 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081)(201702281549075);SRVR:AT5PR84MB0259; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(227479698468861)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123564025)(20161123562025)(20161123555025)(20161123560025)(6072148);SRVR:AT5PR84MB0259;BCL:0;PCL:0;RULEID:;SRVR:AT5PR84MB0259; x-forefront-prvs: 02945962BD x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39450400003)(39840400002)(39410400002)(39850400002)(39400400002)(39860400002)(377424004)(377454003)(24454002)(2900100001)(93886004)(8936002)(25786009)(103116003)(76176999)(81166006)(102836003)(7736002)(6116002)(3846002)(2351001)(2906002)(36756003)(3280700002)(86362001)(3660700001)(33646002)(305945005)(53546009)(50986999)(54356999)(2950100002)(6916009)(4326008)(8676002)(189998001)(229853002)(77096006)(6486002)(54906002)(6506006)(110136004)(5660300001)(38730400002)(53936002)(6512007)(2501003)(5640700003)(478600001)(122556002)(6436002);DIR:OUT;SFP:1102;SCL:1;SRVR:AT5PR84MB0259;H:AT5PR84MB0260.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <969166676757964D8986BBE663CEF769@NAMPRD84.PROD.OUTLOOK.COM> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 May 2017 15:05:46.8201 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: AT5PR84MB0259 X-OriginatorOrg: hpe.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v41FhcTw028010 On Fri, 2017-04-28 at 17:35 -0700, Dan Williams wrote: > On Fri, Apr 28, 2017 at 5:12 PM, Dan Williams om> wrote: > > On Fri, Apr 28, 2017 at 5:10 PM, Dan Williams > .com> wrote: > > > On Thu, Apr 27, 2017 at 3:57 PM, Toshi Kani > > > wrote: > > > > Badblocks are tracked at both region and device levels. > > > > pmem_clear_poison() and nsio_rw_bytes() call > > > > nvdimm_clear_poison() and then badblocks_clear() to clear > > > > badblocks at the device level. However, it does not update > > > > badblocks at the region level, which makes them inconsistent. > > > > > > > > Change nvdimm_clear_poison() to update backblocks at the region > > > > level to keep them consistent. > > > > > > > > Signed-off-by: Toshi Kani > > > > Cc: Dan Williams > > > > Cc: Dave Jiang > > > > Cc: Vishal Verma > > > > > > This looks good, and it seems we have a bug in the other location > > > that does this in __nd_ioctl(). That other one is missing the > > > "clear_err.cleared / 512" check. Can you respin this and define a > > > common helper that both locations can call? > > > > On second thought, I'll take this and spin my own cleanup / fix on > > top. > > > > Thanks Toshi! > > ...and I need to drop it again because it causes this: > > [  106.974889] BUG: sleeping function called from invalid context at > kernel/locking/mutex.c:747 > [  106.977328] in_atomic(): 1, irqs_disabled(): 0, pid: 5584, name: > dd Sorry, I should have tested with CONFIG_DEBUG_ATOMIC_SLEEP set. Thanks for straighten it out in your patch!  -Toshi