diff for duplicates of <1493746791.2552.9.camel@sandisk.com> diff --git a/a/1.txt b/N1/1.txt index c66adc2..f495f2e 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,6 +1,5 @@ On Tue, 2017-05-02 at 16:41 +0200, Jan Kara wrote: -> So I'm also not aware of any particular breakage this would cause. Howeve= -r +> So I'm also not aware of any particular breakage this would cause. However > logically the freeing of request mempools really belongs to > blk_release_queue() so it seems a bit dumb to move blk_exit_rl() just > because SCSI stores the fact from which slab cache it has allocated the @@ -10,8 +9,7 @@ r Hello Jan, My concern when I wrote my previous e-mail was that I didn't want to add a -scsi_host_get() / scsi_host_put() pair to the hot path in the SCSI core. Bu= -t +scsi_host_get() / scsi_host_put() pair to the hot path in the SCSI core. But I just realized that scsi_init_rq() and scsi_exit_rq() are not in the hot path so adding a scsi_host_get() / scsi_host_put() pair should work fine. I will post a patch. diff --git a/a/content_digest b/N1/content_digest index b286860..c3ef47f 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -18,8 +18,7 @@ "\00:1\0" "b\0" "On Tue, 2017-05-02 at 16:41 +0200, Jan Kara wrote:\n" - "> So I'm also not aware of any particular breakage this would cause. Howeve=\n" - "r\n" + "> So I'm also not aware of any particular breakage this would cause. However\n" "> logically the freeing of request mempools really belongs to\n" "> blk_release_queue() so it seems a bit dumb to move blk_exit_rl() just\n" "> because SCSI stores the fact from which slab cache it has allocated the\n" @@ -29,12 +28,11 @@ "Hello Jan,\n" "\n" "My concern when I wrote my previous e-mail was that I didn't want to add a\n" - "scsi_host_get() / scsi_host_put() pair to the hot path in the SCSI core. Bu=\n" - "t\n" + "scsi_host_get() / scsi_host_put() pair to the hot path in the SCSI core. But\n" "I just realized that scsi_init_rq() and scsi_exit_rq() are not in the hot\n" "path so adding a scsi_host_get() / scsi_host_put() pair should work fine. I\n" "will post a patch.\n" "\n" Bart. -6edc2c79aceaf20b02cb6498c28c2ca19c033ef7eae87b84e77b66a41214f9df +92ce403d312aa5839684002f55722a6a4cb3856cbb0f7a567c9ef98337d8fc2b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.