diff for duplicates of <1493762020.2552.15.camel@sandisk.com> diff --git a/a/1.txt b/N1/1.txt index 46b2bb8..3f8e38f 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,20 +1,24 @@ On Tue, 2017-05-02 at 02:53 +0900, damien.lemoal@wdc.com wrote: > +static unsigned long dmz_mblock_shrinker_count(struct shrinker *shrink, -> + struct shrink_control *sc) +> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 struct shri= +nk_control *sc) > +{ -> + struct dmz_target *dmz = -> + container_of(shrink, struct dmz_target, mblk_shrinker); +> +=A0=A0=A0=A0=A0=A0=A0struct dmz_target *dmz =3D +> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0container_of(shrink, struct= + dmz_target, mblk_shrinker); > + -> + return atomic_read(&dmz->nr_mblks); +> +=A0=A0=A0=A0=A0=A0=A0return atomic_read(&dmz->nr_mblks); > +} Hello Damien, -dmz_mblock_shrinker_count() probably should return the following value since +dmz_mblock_shrinker_count() probably should return the following value sinc= +e dmz_shrink_mblock_cache() won't free more than the this number of elements: - max(atomic_read(&dmz->nr_mblks) - dmz->min_nr_mblks, 0) + max(atomic_read(&dmz->nr_mblks) - dmz->min_nr_mblks, 0)=20 But since v2 is IMHO good enough to be merged, for the whole series: -Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com> +Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>= diff --git a/a/content_digest b/N1/content_digest index 9b23349..4e228d6 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -14,23 +14,27 @@ "b\0" "On Tue, 2017-05-02 at 02:53 +0900, damien.lemoal@wdc.com wrote:\n" "> +static unsigned long dmz_mblock_shrinker_count(struct shrinker *shrink,\n" - "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 struct shrink_control *sc)\n" + "> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=\n" + "=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 struct shri=\n" + "nk_control *sc)\n" "> +{\n" - "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240struct dmz_target *dmz =\n" - "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240container_of(shrink, struct dmz_target, mblk_shrinker);\n" + "> +=A0=A0=A0=A0=A0=A0=A0struct dmz_target *dmz =3D\n" + "> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0container_of(shrink, struct=\n" + " dmz_target, mblk_shrinker);\n" "> +\n" - "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240return atomic_read(&dmz->nr_mblks);\n" + "> +=A0=A0=A0=A0=A0=A0=A0return atomic_read(&dmz->nr_mblks);\n" "> +}\n" "\n" "Hello Damien,\n" "\n" - "dmz_mblock_shrinker_count() probably should return the following value since\n" + "dmz_mblock_shrinker_count() probably should return the following value sinc=\n" + "e\n" "dmz_shrink_mblock_cache() won't free more than the this number of elements:\n" "\n" - " max(atomic_read(&dmz->nr_mblks) - dmz->min_nr_mblks, 0) \n" + " max(atomic_read(&dmz->nr_mblks) - dmz->min_nr_mblks, 0)=20\n" "\n" "But since v2 is IMHO good enough to be merged, for the whole series:\n" "\n" - Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com> + Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>= -a4c95d3aa99ef685f6a182163d3758129e94d6ac33a9fc984a73a28bbc024f2e +4635bfd25f85d504d1587ade9a1630c1f23521f75bb067d8f06bdf80e057bfc4
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.