From: Joe Perches <joe@perches.com>
To: Anatolij Gustschin <agust@denx.de>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: linux-fpga@vger.kernel.org,
Alan Tull <atull@opensource.altera.com>,
Moritz Fischer <moritz.fischer@ettus.com>,
matthew.gerlach@linux.intel.com, yi1.li@linux.intel.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] fpga manager: Add Altera CvP driver
Date: Tue, 02 May 2017 16:36:54 -0700 [thread overview]
Message-ID: <1493768214.22125.8.camel@perches.com> (raw)
In-Reply-To: <20170502115308.1e2f1233@crub>
On Tue, 2017-05-02 at 11:53 +0200, Anatolij Gustschin wrote:
> On Mon, 1 May 2017 23:06:16 +0300 Andy Shevchenko andy.shevchenko@gmail.com wrote:
> > > +#define VSEC_CVP_MODE_CTRL_NUMCLKS (0xff<<8) /* CVP_NUMCLKS */
> >
> > Is 0xff a mask here? (Btw, you missed spaces around <<)
>
> yes, it is. Will add spaces (checkpatch didn't warn here).
It would with command line option --strict, otherwise not.
next prev parent reply other threads:[~2017-05-02 23:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-30 19:08 [PATCH v4] fpga manager: Add Altera CvP driver Anatolij Gustschin
2017-05-01 14:58 ` Alan Tull
2017-05-01 20:06 ` Andy Shevchenko
2017-05-02 9:53 ` Anatolij Gustschin
2017-05-02 21:28 ` Andy Shevchenko
2017-05-03 0:14 ` Anatolij Gustschin
2017-05-03 14:19 ` Alan Tull
2017-05-03 15:01 ` Andy Shevchenko
2017-05-14 8:38 ` Anatolij Gustschin
2017-05-02 23:36 ` Joe Perches [this message]
2017-05-03 0:22 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493768214.22125.8.camel@perches.com \
--to=joe@perches.com \
--cc=agust@denx.de \
--cc=andy.shevchenko@gmail.com \
--cc=atull@opensource.altera.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.gerlach@linux.intel.com \
--cc=moritz.fischer@ettus.com \
--cc=yi1.li@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.