Re: [PATCH] libdevmapper: enable native support.

["Puustinen, Ismo" <ismo.puustinen@intel.com>]

On Wed, 2017-05-03 at 11:26 +0000, Peter Kjellerstedt wrote:
> > -----Original Message-----
> > From: openembedded-devel-bounces@lists.openembedded.org
> > [mailto:openembedded-devel-bounces@lists.openembedded.org] On
> > Behalf Of
> > Ismo Puustinen
> > Sent: den 3 maj 2017 13:00
> > To: openembedded-devel@lists.openembedded.org
> > Subject: [oe] [PATCH] libdevmapper: enable native support.
> > 
> > Signed-off-by: Ismo Puustinen <ismo.puustinen@intel.com>
> > ---
> >  meta-oe/recipes-support/lvm2/libdevmapper_2.02.166.bb | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/meta-oe/recipes-support/lvm2/libdevmapper_2.02.166.bb
> > b/meta-oe/recipes-support/lvm2/libdevmapper_2.02.166.bb
> > index 462e8fb..37c0a97 100644
> > --- a/meta-oe/recipes-support/lvm2/libdevmapper_2.02.166.bb
> > +++ b/meta-oe/recipes-support/lvm2/libdevmapper_2.02.166.bb
> > @@ -28,4 +28,6 @@ do_install_append() {
> >      rm -rf ${D}${datadir}
> >  }
> > 
> > -RRECOMMENDS_${PN} += "lvm2-udevrules"
> > +RRECOMMENDS_${PN}_class-target += "lvm2-udevrules"
> 
> That should be either:
> 
> RRECOMMENDS_${PN}_append_class-target = " lvm2-udevrules"
> 
> or:
> 
> RRECOMMENDS_${PN}_class-target = "lvm2-udevrules"
> 
> Using FOO_class-target += "..." gives the impression that it adds to 
> FOO, but it does not, it adds to FOO_class-target which then
> completely 
> replaces FOO for target builds. E.g., with the following two
> definitions:
> 
> FOO = "foo"
> FOO_class-target += "bar"
> 
> then ${FOO} will be "bar" for target builds and "foo" for all other 
> builds. It will never be "foo bar".
> 
> > +BBCLASSEXTEND = "native nativesdk"
> > --
> > 2.9.3
> 
> //Peter

Good point. I'll prepare a second version of the patch. I found it bit
surprising that RRECOMMENDS is even a thing for native recipes...

Ismo