All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Ohly <patrick.ohly@intel.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] QemuRunner: avoid tainting os.environ
Date: Wed, 03 May 2017 15:08:10 +0200	[thread overview]
Message-ID: <1493816890.4241.259.camel@intel.com> (raw)
In-Reply-To: <1493816000.23535.73.camel@linuxfoundation.org>

On Wed, 2017-05-03 at 13:53 +0100, Richard Purdie wrote:
> > Anyway, the variables weren't logged before either, so I'll just
> keep
> > that and change to passing an env dict.
> 
> You could pass in the specific env delta you want to the function and
> leave launch to infill anything which isn't set?

That behavior would then differ from how subprocess works and make it
harder to remove variables from the os.environ. I don't find that
appealing.

Forget that I ever brought up logging of env variables, okay? ;-}

-- 
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.





      reply	other threads:[~2017-05-03 13:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-03 10:56 [PATCH] QemuRunner: avoid tainting os.environ Patrick Ohly
2017-05-03 11:13 ` Richard Purdie
2017-05-03 11:53   ` Patrick Ohly
2017-05-03 12:00     ` Burton, Ross
2017-05-03 12:17       ` Patrick Ohly
2017-05-03 12:20         ` Burton, Ross
2017-05-03 12:40         ` Patrick Ohly
2017-05-03 13:08           ` Burton, Ross
2017-05-03 13:38             ` Patrick Ohly
2017-05-03 12:53         ` Richard Purdie
2017-05-03 13:08           ` Patrick Ohly [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1493816890.4241.259.camel@intel.com \
    --to=patrick.ohly@intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.