Re: [RFC][PATCH] linux/uuid.h: hoist uuid_is_null() helper from libnvdimm

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Wed, 2017-05-03 at 19:35 +0300, Andy Shevchenko wrote:
> On Wed, 2017-05-03 at 15:42 +0300, Amir Goldstein wrote:
> > On Wed, May 3, 2017 at 2:00 PM, Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > > On Wed, 2017-05-03 at 13:05 +0300, Amir Goldstein wrote:
> > > > On Wed, May 3, 2017 at 12:13 PM, Andy Shevchenko

> > I can hear the voices of
> > > > those saying that there should be a 'natural' helper
> > > > uuid_is_null(u8
> > > > *) for the
> > > > users that represent uuid as u8[16] (i.e. filesystems and sb-
> > > > > s_uuid).
> > > 
> > > u8 * doesn't represent UUID as a type.
> > > Perhaps we need to reflect this in the name of the function
> > > somehow.
> > > 
> > 
> > OK, since you have no time nor the intention to convert filesystem
> > code
> > to use uuid_le 
> 
> uuid_be I suppose. I noticed core developers doesn't support endianess
> feature of UUID: https://lkml.org/lkml/2016/5/25/724
> 
> That's also why I don't want to touch filesystem stuff.
> 
> > (not should you), I see 2 options for filesystems/VFS:
> > 
> > 1. Use the simple u8* libnvdimm helper proposed by this patch
> > 2. Hoist uuid_t + helpers from fs/xfs/uuid.* to linux/uuid.h
> > lib/uuid.c
> > 
> > If option #2 is preferred, I think we should conform to libuuid's
> > helper
> > name uuid_is_null() (instead of freebsd's uuid_is_nil()) 

I renamed as proposed and updated my branch.

By the way, notice that uuid_v1 type (which had been moved to uuid.h
already) is the same what xfs uses as uuid_t.

So, helpers against it we can prefix with uuid_v1_[foo_bar()].

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy