From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from g9t5009.houston.hpe.com (g9t5009.houston.hpe.com [15.241.48.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3A75721A13493 for ; Wed, 3 May 2017 16:36:16 -0700 (PDT) From: "Kani, Toshimitsu" Subject: Re: [RFC PATCH] dax: add badblocks check to Device DAX Date: Wed, 3 May 2017 23:36:13 +0000 Message-ID: <1493854569.30303.53.camel@hpe.com> References: <20170503153103.30756-1-toshi.kani@hpe.com> <1493827750.30303.44.camel@hpe.com> <1493837209.30303.47.camel@hpe.com> <1493851282.30303.49.camel@hpe.com> <1493853934.30303.51.camel@hpe.com> In-Reply-To: <1493853934.30303.51.camel@hpe.com> Content-Language: en-US Content-ID: <7FD3C72861743F4D8057037C92C9CECD@NAMPRD84.PROD.OUTLOOK.COM> MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "dan.j.williams@intel.com" Cc: "linux-kernel@vger.kernel.org" , "linux-nvdimm@lists.01.org" List-ID: T24gV2VkLCAyMDE3LTA1LTAzIGF0IDE3OjI1IC0wNjAwLCBUb3NoaSBLYW5pIHdyb3RlOg0KPiBP biBXZWQsIDIwMTctMDUtMDMgYXQgMTY6MDggLTA3MDAsIERhbiBXaWxsaWFtcyB3cm90ZToNCj4g PiBPbiBXZWQsIE1heSAzLCAyMDE3IGF0IDM6NTEgUE0sIERhbiBXaWxsaWFtcyA8ZGFuLmoud2ls bGlhbXNAaW50ZWwuDQo+ID4gY28NCj4gPiBtPiB3cm90ZToNCj4gPiA+IE9uIFdlZCwgTWF5IDMs IDIwMTcgYXQgMzo0MSBQTSwgS2FuaSwgVG9zaGltaXRzdSA8dG9zaGkua2FuaUBocGUuDQo+ID4g PiBjbw0KPiA+ID4gbT4gd3JvdGU6DQo+ID4gPiA+IE9uIFdlZCwgMjAxNy0wNS0wMyBhdCAxNDo0 OCAtMDcwMCwgRGFuIFdpbGxpYW1zIHdyb3RlOg0KPiANCj4gwqA6DQo+ID4gPiANCj4gPiA+IEkg YmVsaWV2ZSB3ZSBhbHJlYWR5IGhhdmUgYWxsIHRoZSBkYXRhIG5lZWRlZCB0byBjYWxjdWxhdGUg dGhlDQo+ID4gPiBkYXRhDQo+ID4gPiBvZmZzZXQuIEdpdmVuIHRoZSBmb2xsb3dpbmcgc3lzZnMg cGF0aDoNCj4gPiA+IA0KPiA+ID4gwqDCoMKgwqAvc3lzL2RldmljZXMvTE5YU1lTVE06MDAvTE5Y U1lCVVM6MDAvQUNQSTAwMTI6MDAvbmRidXMwL3JlZ2lvDQo+ID4gPiBuMQ0KPiA+ID4gL2RheDEu MS9kYXgvZGF4MS4wDQo+ID4gPiANCj4gPiA+IC4uLndlIGNhbiBmaW5kIHRoZSBhc3NvY2lhdGVk IG5hbWVzcGFjZSBkZXZpY2UgZnJvbSB0aGF0IGRheDEuMS4NCj4gPiA+IEZyb20NCj4gPiA+IHRo ZXJlIHdlIGhhdmUgdGhlIGJhc2UgYWRkcmVzcyBvZiB0aGUgbmFtZXNwYWNlIGFuZCB0aGUgc2l6 ZQ0KPiA+ID4gZGV2aWNlLWRheCBpbnN0YW5jZS4NCj4gPiA+IA0KPiA+ID4gwqDCoMKgwqBkZXZp Y2VfZGF4X2RhdGFfb2Zmc2V0ID09IG5hbWVzcGFjZV9iYXNlICsgbmFtZXNwYWNlX3NpemUgLQ0K PiA+ID4gZGV2aWNlX2RheF9zaXplDQo+ID4gDQo+ID4gRGF2ZSByZW1pbmRzIG1lIHRoYXQgd2Ug ZG8gaGF2ZSB0aGUgZGF0YSBvZmZzZXQgb2YgdGhlIGRldmljZS1kYXgNCj4gPiBpbnN0YW5jZSBh dCB0aGUgbGlibnZkaW1tIGxldmVsOg0KPiA+IA0KPiA+IMKgwqDCoMKgL3N5cy9kZXZpY2VzL0xO WFNZU1RNOjAwL0xOWFNZQlVTOjAwL0FDUEkwMDEyOjAwL25kYnVzMC9yZWdpb24xDQo+ID4gL2QN Cj4gPiBheDEuMS9yZXNvdXJjZQ0KPiA+IA0KPiA+IC4uLmluIHRoaXMgZXhhbXBsZSwgd2hpY2gg bWFwcyB0byBuZGN0bF9kYXhfZ2V0X3Jlc291cmNlKCkuDQo+IA0KPiBUaGFua3MgZm9yIHRoZSBp bmZvIcKgwqBJIG5vdGljZWQgd2h5IEkgZGlkIG5vdCBjYXRjaCB0aGlzIGluZm8gYmVmb3JlLg0K PiANCj4gIyBsbCAvZGV2L2RheCoNCj4gY3J3LS0tLS0tLSAxIHJvb3Qgcm9vdCAyNTEsIDMgTWF5 wqDCoDMgMDQ6MjggL2Rldi9kYXgwLjANCj4gDQo+ICMgcHdkDQo+IC9zeXMvZGV2aWNlcy9MTlhT WVNUTTowMC9MTlhTWUJVUzowMC9BQ1BJMDAxMjowMC9uZGJ1czAvcmVnaW9uMC9kYXgwLg0KPiAw DQo+IA0KPiAjIGdyZXAgLiAqDQo+IGFsaWduOjIwOTcxNTINCj4gZGV2dHlwZTpuZF9kYXgNCj4g bW9kYWxpYXM6bmQ6dDcNCj4gbW9kZTpub25lDQo+IG51bWFfbm9kZTowDQo+IGdyZXA6IHBvd2Vy OiBJcyBhIGRpcmVjdG9yeQ0KPiBncmVwOiByZXNvdXJjZTogTm8gc3VjaCBkZXZpY2Ugb3IgYWRk cmVzcw0KPiBncmVwOiBzaXplOiBObyBzdWNoIGRldmljZSBvciBhZGRyZXNzDQo+IGdyZXA6IHN1 YnN5c3RlbTogSXMgYSBkaXJlY3RvcnkNCj4gdWV2ZW50OkRFVlRZUEU9bmRfZGF4DQo+IHVldmVu dDpNT0RBTElBUz1uZDp0Nw0KPiANCj4gQnV0IEkgbm90aWNlZCB0aGF0ICJyZXNvdXJjZSIgYW5k ICJzaXplIiB0aGF0IGFyZSB1bmRlcg0KPiAiLi4uL3JlZ2lvbjAvZGF4MC4xIiB3b3JrLsKgwqBJ cyB0aGlzIGludGVuZGVkPw0KDQpIZXJlIGlzIGFuIG91dHB1dCBmcm9tIGRheDAuMSAoSSByZW1v dmVkIHRoZSBzaXplIHZhbHVlKS4gIE5vdGljZWQgdGhhdA0KbW9kZSBpcyBkaWZmZXJlbnQuDQoN CiMgcHdkDQovc3lzL2RldmljZXMvTE5YU1lTVE06MDAvTE5YU1lCVVM6MDAvQUNQSTAwMTI6MDAv bmRidXMwL3JlZ2lvbjAvZGF4MC4xDQoNCiMgZ3JlcCAuICoNCmFsaWduOjIwOTcxNTINCmdyZXA6 IGRheDogSXMgYSBkaXJlY3RvcnkNCmdyZXA6IGRheF9yZWdpb246IElzIGEgZGlyZWN0b3J5DQpk ZXZ0eXBlOm5kX2RheA0KZ3JlcDogZHJpdmVyOiBJcyBhIGRpcmVjdG9yeQ0KbW9kYWxpYXM6bmQ6 dDcNCm1vZGU6cG1lbQ0KbmFtZXNwYWNlOm5hbWVzcGFjZTAuMA0KbnVtYV9ub2RlOjANCmdyZXA6 IHBvd2VyOiBJcyBhIGRpcmVjdG9yeQ0KcmVzb3VyY2U6MHgyNTAyMDAwMDANCnNpemU6KHNpemUg dmFsdWUpDQpncmVwOiBzdWJzeXN0ZW06IElzIGEgZGlyZWN0b3J5DQp1ZXZlbnQ6REVWVFlQRT1u ZF9kYXgNCnVldmVudDpEUklWRVI9ZGF4X3BtZW0NCnVldmVudDpNT0RBTElBUz1uZDp0Nw0KdXVp ZDo4YzcxODExZi0yNjBkLTQ3ODgtODQ4Ny1kYjg4ZDgyOWQzOTMNCg0KVGhhbmtzLA0KLVRvc2hp DQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1u dmRpbW0gbWFpbGluZyBsaXN0CkxpbnV4LW52ZGltbUBsaXN0cy4wMS5vcmcKaHR0cHM6Ly9saXN0 cy4wMS5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1udmRpbW0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752072AbdECXgZ (ORCPT ); Wed, 3 May 2017 19:36:25 -0400 Received: from g9t5009.houston.hpe.com ([15.241.48.73]:37233 "EHLO g9t5009.houston.hpe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751589AbdECXgQ (ORCPT ); Wed, 3 May 2017 19:36:16 -0400 From: "Kani, Toshimitsu" To: "dan.j.williams@intel.com" CC: "linux-kernel@vger.kernel.org" , "dave.jiang@intel.com" , "linux-nvdimm@lists.01.org" Subject: Re: [RFC PATCH] dax: add badblocks check to Device DAX Thread-Topic: [RFC PATCH] dax: add badblocks check to Device DAX Thread-Index: AQHSxCJYsIkXTJcozUeBmwgaJMx1HaHiwjaAgAAEtwCAAAXrgIAAJiGAgAAy3QCAAA6sAIAAAvMAgAAEj4CAAATXAIAAAvWA Date: Wed, 3 May 2017 23:36:13 +0000 Message-ID: <1493854569.30303.53.camel@hpe.com> References: <20170503153103.30756-1-toshi.kani@hpe.com> <1493827750.30303.44.camel@hpe.com> <1493837209.30303.47.camel@hpe.com> <1493851282.30303.49.camel@hpe.com> <1493853934.30303.51.camel@hpe.com> In-Reply-To: <1493853934.30303.51.camel@hpe.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=hpe.com; x-originating-ip: [15.219.163.8] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AT5PR84MB0258;7:9MO5AfOHtLuXBVB/4Y8tb4BdP0kOkG96psPkuRafKPaIWW8oto31sPwm3+6TGI1lf/K+11sqoC8T4sgGvDqX8VA1agoRkrZm3SyGCCCeiI5AGtkt0gkLPwGY5klyjYUmKzzgIe/rBcUe2ZxKoD+DQKE9tS4NZP+/jhBaGYCG1AryVb1Y4Tk7SiumYzj9NNA6r7nLbSydoLZIgSXaifxYb5nwdsai9NjRFZdBPoRJNdkmaOguCvKw/HuaOoNNgl+p0FZySJaQqbQw5Z1DvWee2kicvjqlpIaJerYoXSS0BRdmHZf4fri3H44IcQMd6y5pmDbYlS4tEVCNsZO9+GWR/g== x-ms-office365-filtering-correlation-id: 63ffb05d-55df-40bb-62bf-08d4927d2f97 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081)(201702281549075);SRVR:AT5PR84MB0258; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041248)(20161123555025)(20161123562025)(20161123560025)(20161123564025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148);SRVR:AT5PR84MB0258;BCL:0;PCL:0;RULEID:;SRVR:AT5PR84MB0258; x-forefront-prvs: 029651C7A1 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39400400002)(39450400003)(39410400002)(39850400002)(39840400002)(39860400002)(377424004)(377454003)(51914003)(24454002)(6486002)(5660300001)(25786009)(4326008)(6506006)(33646002)(86362001)(102836003)(2351001)(5250100002)(3846002)(53546009)(6116002)(2900100001)(2501003)(305945005)(5640700003)(7736002)(8936002)(6436002)(478600001)(50986999)(81166006)(54906002)(66066001)(76176999)(6512007)(189998001)(3660700001)(54356999)(3280700002)(2906002)(53936002)(8676002)(229853002)(6916009)(110136004)(38730400002)(103116003)(93886004)(2950100002)(36756003)(6246003);DIR:OUT;SFP:1102;SCL:1;SRVR:AT5PR84MB0258;H:AT5PR84MB0260.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <7FD3C72861743F4D8057037C92C9CECD@NAMPRD84.PROD.OUTLOOK.COM> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2017 23:36:13.2439 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: AT5PR84MB0258 X-OriginatorOrg: hpe.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v43NbGlK005912 On Wed, 2017-05-03 at 17:25 -0600, Toshi Kani wrote: > On Wed, 2017-05-03 at 16:08 -0700, Dan Williams wrote: > > On Wed, May 3, 2017 at 3:51 PM, Dan Williams > co > > m> wrote: > > > On Wed, May 3, 2017 at 3:41 PM, Kani, Toshimitsu > > co > > > m> wrote: > > > > On Wed, 2017-05-03 at 14:48 -0700, Dan Williams wrote: > >  : > > > > > > I believe we already have all the data needed to calculate the > > > data > > > offset. Given the following sysfs path: > > > > > >     /sys/devices/LNXSYSTM:00/LNXSYBUS:00/ACPI0012:00/ndbus0/regio > > > n1 > > > /dax1.1/dax/dax1.0 > > > > > > ...we can find the associated namespace device from that dax1.1. > > > From > > > there we have the base address of the namespace and the size > > > device-dax instance. > > > > > >     device_dax_data_offset == namespace_base + namespace_size - > > > device_dax_size > > > > Dave reminds me that we do have the data offset of the device-dax > > instance at the libnvdimm level: > > > >     /sys/devices/LNXSYSTM:00/LNXSYBUS:00/ACPI0012:00/ndbus0/region1 > > /d > > ax1.1/resource > > > > ...in this example, which maps to ndctl_dax_get_resource(). > > Thanks for the info!  I noticed why I did not catch this info before. > > # ll /dev/dax* > crw------- 1 root root 251, 3 May  3 04:28 /dev/dax0.0 > > # pwd > /sys/devices/LNXSYSTM:00/LNXSYBUS:00/ACPI0012:00/ndbus0/region0/dax0. > 0 > > # grep . * > align:2097152 > devtype:nd_dax > modalias:nd:t7 > mode:none > numa_node:0 > grep: power: Is a directory > grep: resource: No such device or address > grep: size: No such device or address > grep: subsystem: Is a directory > uevent:DEVTYPE=nd_dax > uevent:MODALIAS=nd:t7 > > But I noticed that "resource" and "size" that are under > ".../region0/dax0.1" work.  Is this intended? Here is an output from dax0.1 (I removed the size value). Noticed that mode is different. # pwd /sys/devices/LNXSYSTM:00/LNXSYBUS:00/ACPI0012:00/ndbus0/region0/dax0.1 # grep . * align:2097152 grep: dax: Is a directory grep: dax_region: Is a directory devtype:nd_dax grep: driver: Is a directory modalias:nd:t7 mode:pmem namespace:namespace0.0 numa_node:0 grep: power: Is a directory resource:0x250200000 size:(size value) grep: subsystem: Is a directory uevent:DEVTYPE=nd_dax uevent:DRIVER=dax_pmem uevent:MODALIAS=nd:t7 uuid:8c71811f-260d-4788-8487-db88d829d393 Thanks, -Toshi