From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga07.intel.com ([134.134.136.100]:23822 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932087AbdEDGGX (ORCPT ); Thu, 4 May 2017 02:06:23 -0400 From: "Coelho, Luciano" To: "torvalds@linux-foundation.org" , "kvalo@codeaurora.org" CC: "linux-wireless@vger.kernel.org" , "davem@davemloft.net" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "johannes@sipsolutions.net" Subject: Re: new warning at net/wireless/util.c:1236 Date: Thu, 4 May 2017 06:06:18 +0000 Message-ID: <1493877978.14233.85.camel@intel.com> (sfid-20170504_080629_073268_67BD16E6) References: <87o9v99r3g.fsf@purkki.adurom.net> In-Reply-To: <87o9v99r3g.fsf@purkki.adurom.net> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: T24gVGh1LCAyMDE3LTA1LTA0IGF0IDA3OjM1ICswMzAwLCBLYWxsZSBWYWxvIHdyb3RlOg0KPiBM aW51cyBUb3J2YWxkcyA8dG9ydmFsZHNAbGludXgtZm91bmRhdGlvbi5vcmc+IHdyaXRlczoNCj4g DQo+ID4gU28gbXkgRGVsbCBYUFMgMTMgc2VlbXMgdG8gaGF2ZSBncm93biBhIG5ldyB3YXJuaW5n IGFzIG9mIHRoZQ0KPiA+IG5ldHdvcmtpbmcgbWVyZ2UgeWVzdGVyZGF5Lg0KPiA+IA0KPiA+IFRo aW5ncyBzdGlsbCB3b3JrLCBidXQgd2hlbiBpdCBzdGFydHMgd2FybmluZywgaXQgZ2VuZXJhdGVz IGEgKmxvdCogb2YNCj4gPiBub2lzZSAoSSBnb3QgMzYgb2YgdGhlc2Ugd2l0aGluIGFib3V0IHRl biBtaW51dGVzKS4NCj4gPiANCj4gPiBJIGhhdmUgbm8gaWRlYSB3aGF0IHRyaWdnZXJlZCBpdCwg YmVjYXVzZSB3aGVuIEkgcmVib290ZWQgKG5vdCBiZWNhdXNlDQo+ID4gb2YgdGhpcyBpc3N1ZSwg YnV0IGp1c3QgdG8gcmVib290IGludG8gYSBuZXdlciBrZXJuZWwpIEkgZG9uJ3Qgc2VlIGl0DQo+ ID4gYWdhaW4uDQo+ID4gDQo+ID4gVGhpcyBpcyBhbGwgcHJldHR5IHJlZ3VsYXIgd2lyZWxlc3Mg LSBpdCdzIGludGVsIDgyNjAgd2lyZWxlc3MgaW4gYQ0KPiA+IGZhaXJseSBub3JtYWwgbGFwdG9w Lg0KPiA+IA0KPiA+IFRoaW5ncyBzdGlsbCBzZWVtIHRvICp3b3JrKiBvaywgc28gdGhlIG9ubHkg cHJvYmxlbSBoZXJlIGlzIHRoZSBvdmVybHkNCj4gPiB2ZXJib3NlIGFuZCB1c2VsZXNzIFdBUk5f T04uIEl0IGRvZXNuJ3QgZXZlbiBwcmludCBvdXQgKndoaWNoKiByYXRlIGl0DQo+ID4gaXMgd2Fy bmluZyBhYm91dCwgaXQganVzdCBkb2VzIHRoYXQgc3R1cGlkIHVuY29uZGl0aW9uYWwgV0FSTl9P TigpDQo+ID4gd2l0aG91dCBldmVyIHNodXR0aW5nIHVwIGFib3V0IGl0Li4NCj4gPiANCj4gPiBU aGUgV0FSTl9PTigpIHNlZW1zIHRvIGJlIG9sZCwgYnV0IG15IGxvZ3MgZG9uJ3Qgc2VlbSB0byBo YXZlIGFueQ0KPiA+IG1lbnRpb24gb2YgdGhpcyB1bnRpbCB0b2RheSwgc28gdGhlcmUncyBzb21l dGhpbmcgdGhhdCBoYXMgY2hhbmdlZA0KPiA+IHRoYXQgbm93IHRyaWdnZXJzIGl0Lg0KPiA+IA0K PiA+IElkZWFzPw0KPiA+IA0KPiA+ICAgICAgICAgICAgICAgICAgIExpbnVzDQo+ID4gDQo+ID4g LS0tDQo+ID4gDQo+ID4gV0FSTklORzogQ1BVOiAzIFBJRDogMTEzOCBhdCBuZXQvd2lyZWxlc3Mv dXRpbC5jOjEyMzYNCj4gPiBjZmc4MDIxMV9jYWxjdWxhdGVfYml0cmF0ZSsweDEzOS8weDE3MCBb Y2ZnODAyMTFdDQo+IA0KPiBBcyB0aGlzIGlzIHdpdGggaXdsd2lmaSBhZGRpbmcgYWxzbyBMdWNh LiBUaGVyZSB3ZXJlIHNvbWUgcmF0ZSBoYW5kbGluZw0KPiBjaGFuZ2VzIGluIGl3bHdpZmksIGxp a2UgY29tbWl0IDc3ZTQwOTQ1NWY0MSwgYnV0IGRvbid0IGtub3cgaWYgdGhhdA0KPiBjb3VsZCBj YXVzZSB0aGlzLg0KDQpUaGFua3MgS2FsbGUuICBJIGRvbid0IHNlZSBhbnl0aGluZyBpbiB0aGUg aXdsd2lmaSBkcml2ZXIgdGhhdCBjb3VsZCBiZQ0KY2F1c2luZyB0aGlzLiAgSm9oYW5uZXMgc3Vz cGVjdHMgc29tZSBSWCByYXRlIGNoYW5nZXMgaGUgbWFkZSBpbg0KbWFjODAyMTEuLi4NCg0KLS0N Ckx1Y2Eu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932238AbdEDGGa (ORCPT ); Thu, 4 May 2017 02:06:30 -0400 Received: from mga07.intel.com ([134.134.136.100]:23822 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932087AbdEDGGX (ORCPT ); Thu, 4 May 2017 02:06:23 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,286,1491289200"; d="scan'208";a="95388197" From: "Coelho, Luciano" To: "torvalds@linux-foundation.org" , "kvalo@codeaurora.org" CC: "linux-wireless@vger.kernel.org" , "davem@davemloft.net" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "johannes@sipsolutions.net" Subject: Re: new warning at net/wireless/util.c:1236 Thread-Topic: new warning at net/wireless/util.c:1236 Thread-Index: AQHSxJyLGJl/EYPjokyMY00NbO/tIg== Date: Thu, 4 May 2017 06:06:18 +0000 Message-ID: <1493877978.14233.85.camel@intel.com> References: <87o9v99r3g.fsf@purkki.adurom.net> In-Reply-To: <87o9v99r3g.fsf@purkki.adurom.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.252.19.243] Content-Type: text/plain; charset="utf-8" Content-ID: <28266EE120BE294D965460F0C60F93A0@intel.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v4466fCT003553 On Thu, 2017-05-04 at 07:35 +0300, Kalle Valo wrote: > Linus Torvalds writes: > > > So my Dell XPS 13 seems to have grown a new warning as of the > > networking merge yesterday. > > > > Things still work, but when it starts warning, it generates a *lot* of > > noise (I got 36 of these within about ten minutes). > > > > I have no idea what triggered it, because when I rebooted (not because > > of this issue, but just to reboot into a newer kernel) I don't see it > > again. > > > > This is all pretty regular wireless - it's intel 8260 wireless in a > > fairly normal laptop. > > > > Things still seem to *work* ok, so the only problem here is the overly > > verbose and useless WARN_ON. It doesn't even print out *which* rate it > > is warning about, it just does that stupid unconditional WARN_ON() > > without ever shutting up about it.. > > > > The WARN_ON() seems to be old, but my logs don't seem to have any > > mention of this until today, so there's something that has changed > > that now triggers it. > > > > Ideas? > > > > Linus > > > > --- > > > > WARNING: CPU: 3 PID: 1138 at net/wireless/util.c:1236 > > cfg80211_calculate_bitrate+0x139/0x170 [cfg80211] > > As this is with iwlwifi adding also Luca. There were some rate handling > changes in iwlwifi, like commit 77e409455f41, but don't know if that > could cause this. Thanks Kalle. I don't see anything in the iwlwifi driver that could be causing this. Johannes suspects some RX rate changes he made in mac80211... -- Luca. From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Coelho, Luciano" Subject: Re: new warning at net/wireless/util.c:1236 Date: Thu, 4 May 2017 06:06:18 +0000 Message-ID: <1493877978.14233.85.camel@intel.com> References: <87o9v99r3g.fsf@purkki.adurom.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: "linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org" , "netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org" To: "torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org" , "kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org" Return-path: In-Reply-To: <87o9v99r3g.fsf-5ukZ45wKbUHoml4zekdYB16hYfS7NtTn@public.gmane.org> Content-Language: en-US Content-ID: <28266EE120BE294D965460F0C60F93A0-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org T24gVGh1LCAyMDE3LTA1LTA0IGF0IDA3OjM1ICswMzAwLCBLYWxsZSBWYWxvIHdyb3RlOg0KPiBM aW51cyBUb3J2YWxkcyA8dG9ydmFsZHNAbGludXgtZm91bmRhdGlvbi5vcmc+IHdyaXRlczoNCj4g DQo+ID4gU28gbXkgRGVsbCBYUFMgMTMgc2VlbXMgdG8gaGF2ZSBncm93biBhIG5ldyB3YXJuaW5n IGFzIG9mIHRoZQ0KPiA+IG5ldHdvcmtpbmcgbWVyZ2UgeWVzdGVyZGF5Lg0KPiA+IA0KPiA+IFRo aW5ncyBzdGlsbCB3b3JrLCBidXQgd2hlbiBpdCBzdGFydHMgd2FybmluZywgaXQgZ2VuZXJhdGVz IGEgKmxvdCogb2YNCj4gPiBub2lzZSAoSSBnb3QgMzYgb2YgdGhlc2Ugd2l0aGluIGFib3V0IHRl biBtaW51dGVzKS4NCj4gPiANCj4gPiBJIGhhdmUgbm8gaWRlYSB3aGF0IHRyaWdnZXJlZCBpdCwg YmVjYXVzZSB3aGVuIEkgcmVib290ZWQgKG5vdCBiZWNhdXNlDQo+ID4gb2YgdGhpcyBpc3N1ZSwg YnV0IGp1c3QgdG8gcmVib290IGludG8gYSBuZXdlciBrZXJuZWwpIEkgZG9uJ3Qgc2VlIGl0DQo+ ID4gYWdhaW4uDQo+ID4gDQo+ID4gVGhpcyBpcyBhbGwgcHJldHR5IHJlZ3VsYXIgd2lyZWxlc3Mg LSBpdCdzIGludGVsIDgyNjAgd2lyZWxlc3MgaW4gYQ0KPiA+IGZhaXJseSBub3JtYWwgbGFwdG9w Lg0KPiA+IA0KPiA+IFRoaW5ncyBzdGlsbCBzZWVtIHRvICp3b3JrKiBvaywgc28gdGhlIG9ubHkg cHJvYmxlbSBoZXJlIGlzIHRoZSBvdmVybHkNCj4gPiB2ZXJib3NlIGFuZCB1c2VsZXNzIFdBUk5f T04uIEl0IGRvZXNuJ3QgZXZlbiBwcmludCBvdXQgKndoaWNoKiByYXRlIGl0DQo+ID4gaXMgd2Fy bmluZyBhYm91dCwgaXQganVzdCBkb2VzIHRoYXQgc3R1cGlkIHVuY29uZGl0aW9uYWwgV0FSTl9P TigpDQo+ID4gd2l0aG91dCBldmVyIHNodXR0aW5nIHVwIGFib3V0IGl0Li4NCj4gPiANCj4gPiBU aGUgV0FSTl9PTigpIHNlZW1zIHRvIGJlIG9sZCwgYnV0IG15IGxvZ3MgZG9uJ3Qgc2VlbSB0byBo YXZlIGFueQ0KPiA+IG1lbnRpb24gb2YgdGhpcyB1bnRpbCB0b2RheSwgc28gdGhlcmUncyBzb21l dGhpbmcgdGhhdCBoYXMgY2hhbmdlZA0KPiA+IHRoYXQgbm93IHRyaWdnZXJzIGl0Lg0KPiA+IA0K PiA+IElkZWFzPw0KPiA+IA0KPiA+ICAgICAgICAgICAgICAgICAgIExpbnVzDQo+ID4gDQo+ID4g LS0tDQo+ID4gDQo+ID4gV0FSTklORzogQ1BVOiAzIFBJRDogMTEzOCBhdCBuZXQvd2lyZWxlc3Mv dXRpbC5jOjEyMzYNCj4gPiBjZmc4MDIxMV9jYWxjdWxhdGVfYml0cmF0ZSsweDEzOS8weDE3MCBb Y2ZnODAyMTFdDQo+IA0KPiBBcyB0aGlzIGlzIHdpdGggaXdsd2lmaSBhZGRpbmcgYWxzbyBMdWNh LiBUaGVyZSB3ZXJlIHNvbWUgcmF0ZSBoYW5kbGluZw0KPiBjaGFuZ2VzIGluIGl3bHdpZmksIGxp a2UgY29tbWl0IDc3ZTQwOTQ1NWY0MSwgYnV0IGRvbid0IGtub3cgaWYgdGhhdA0KPiBjb3VsZCBj YXVzZSB0aGlzLg0KDQpUaGFua3MgS2FsbGUuICBJIGRvbid0IHNlZSBhbnl0aGluZyBpbiB0aGUg aXdsd2lmaSBkcml2ZXIgdGhhdCBjb3VsZCBiZQ0KY2F1c2luZyB0aGlzLiAgSm9oYW5uZXMgc3Vz cGVjdHMgc29tZSBSWCByYXRlIGNoYW5nZXMgaGUgbWFkZSBpbg0KbWFjODAyMTEuLi4NCg0KLS0N Ckx1Y2Eu