From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa5.hgst.iphmx.com ([216.71.153.144]:64396 "EHLO esa5.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751900AbdEDXNp (ORCPT ); Thu, 4 May 2017 19:13:45 -0400 From: Bart Van Assche To: "osandov@osandov.com" , "linux-block@vger.kernel.org" , "axboe@fb.com" CC: "kernel-team@fb.com" Subject: Re: [PATCH v2 06/12] blk-mq-debugfs: get rid of a bunch of boilerplate Date: Thu, 4 May 2017 23:13:42 +0000 Message-ID: <1493939622.2692.16.camel@sandisk.com> References: In-Reply-To: Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Sender: linux-block-owner@vger.kernel.org List-Id: linux-block@vger.kernel.org On Thu, 2017-05-04 at 00:31 -0700, Omar Sandoval wrote: > From: Omar Sandoval >=20 > A large part of blk-mq-debugfs.c is file_operations and seq_file > boilerplate. This sucks as is but will suck even more when schedulers > can define their own debugfs entries. Factor it all out into a single > blk_mq_debugfs_fops which multiplexes as needed. We store the > request_queue, blk_mq_hw_ctx, or blk_mq_ctx in the parent directory > dentry, which is kind of hacky, but it works. Reviewed-by: Bart Van Assche =