From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCHv4 3/3] drm/vgem: Enable dmabuf import interfaces Date: Thu, 04 May 2017 21:09:54 -0700 Message-ID: <1493957394.31950.7.camel@perches.com> References: <1493923548-20878-1-git-send-email-labbott@redhat.com> <1493923548-20878-4-git-send-email-labbott@redhat.com> <20170504202503.GP24019@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from smtprelay.hostedemail.com (smtprelay0141.hostedemail.com [216.40.44.141]) by gabe.freedesktop.org (Postfix) with ESMTPS id 34A426E56E for ; Fri, 5 May 2017 04:09:58 +0000 (UTC) In-Reply-To: <20170504202503.GP24019@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chris Wilson , Laura Abbott Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, Joonas Lahtinen , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCAyMDE3LTA1LTA0IGF0IDIxOjI1ICswMTAwLCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4g T24gVGh1LCBNYXkgMDQsIDIwMTcgYXQgMTE6NDU6NDhBTSAtMDcwMCwgTGF1cmEgQWJib3R0IHdy b3RlOgo+ID4gCj4gPiBFbmFibGUgdGhlIEdFTSBkbWEtYnVmIGltcG9ydCBpbnRlcmZhY2VzIGlu IGFkZGl0aW9uIHRvIHRoZSBleHBvcnQKPiA+IGludGVyZmFjZXMuIFRoaXMgbGV0cyB2Z2VtIGJl IHVzZWQgYXMgYSB0ZXN0IHNvdXJjZSBmb3Igb3RoZXIgYWxsb2NhdG9ycwo+ID4gKGUuZy4gSW9u KS4KPiA+IAo+ID4gUmV2aWV3ZWQtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29u LmNvLnVrPgo+ID4gU2lnbmVkLW9mZi1ieTogTGF1cmEgQWJib3R0IDxsYWJib3R0QHJlZGhhdC5j b20+Cj4gPiAtLS0KPiA+IHY0OiBVc2UgbmV3IGRybV9nZW1fcHJpbWVfaW1wb3J0X2RldiBmdW5j dGlvbgo+ID4gLS0tCj4gPiAgc3RhdGljIGNvbnN0IHN0cnVjdCB2bV9vcGVyYXRpb25zX3N0cnVj dCB2Z2VtX2dlbV92bV9vcHMgPSB7Cj4gPiBAQCAtMTE0LDEyICsxNDIsOCBAQCBzdGF0aWMgdm9p ZCB2Z2VtX3Bvc3RjbG9zZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBzdHJ1Y3QgZHJtX2ZpbGUg KmZpbGUpCj4gPiAgCWtmcmVlKHZmaWxlKTsKPiA+ICB9Cj4gPiAgCj4gPiAtLyogaW9jdGxzICov Cj4gPiAtCj4gPiAtc3RhdGljIHN0cnVjdCBkcm1fZ2VtX29iamVjdCAqdmdlbV9nZW1fY3JlYXRl KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gPiAtCQkJCQkgICAgICBzdHJ1Y3QgZHJtX2ZpbGUg KmZpbGUsCj4gPiAtCQkJCQkgICAgICB1bnNpZ25lZCBpbnQgKmhhbmRsZSwKPiA+IC0JCQkJCSAg ICAgIHVuc2lnbmVkIGxvbmcgc2l6ZSkKPiA+ICtzdGF0aWMgc3RydWN0IGRybV92Z2VtX2dlbV9v YmplY3QgKl9fdmdlbV9nZW1fY3JlYXRlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gPiArCQkJ CQkJdW5zaWduZWQgbG9uZyBzaXplKQo+IAo+IEknbSBnb2luZyB0byBndWVzcyB0aGF0IGRvZXNu J3QgbGluZSB1cCBhbnltb3JlLiBJZiBjaGVja3BhdGNoIGlzbid0Cj4gY29tcGxhaW5pbmcsIHRo ZW4gc29ycnkgZm9yIHRoZSBub2lzZS4KCkJlY2F1c2Ugb2YgdGhlIHZlcnkgbG9uZyBpZGVudGlm aWVycywgcGVyaGFwcyBhCm5pY2VyIHdheSB0byB3cml0ZSB0aGlzIGlzIGxpa2U6CgpzdGF0aWMg c3RydWN0IGRybV92Z2VtX2dlbV9vYmplY3QgKgpfX3ZnZW5fZ2VtX2NyZWF0ZShzdHJ1Y3QgZHJt X2RldmljZSAqZGV2LCB1bnNpZ25lZCBsb25nIHNpemUpOwoKPiA+ICtzdGF0aWMgc3RydWN0IGRy bV9nZW1fb2JqZWN0ICp2Z2VtX2dlbV9jcmVhdGUoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiA+ ICsJCQkJCSAgICAgIHN0cnVjdCBkcm1fZmlsZSAqZmlsZSwKPiA+ICsJCQkJCSAgICAgIHVuc2ln bmVkIGludCAqaGFuZGxlLAo+ID4gKwkJCQkJICAgICAgdW5zaWduZWQgbG9uZyBzaXplKQo+IAo+ IERpdHRvLgoKZXRjLi4uCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmkt ZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752462AbdEEEKA (ORCPT ); Fri, 5 May 2017 00:10:00 -0400 Received: from smtprelay0115.hostedemail.com ([216.40.44.115]:54982 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750812AbdEEEJ7 (ORCPT ); Fri, 5 May 2017 00:09:59 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:966:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2196:2199:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3870:3871:3874:4250:4321:4385:4605:5007:8603:10004:10226:10400:10848:11026:11232:11233:11658:11876:11914:12296:12438:12663:12740:12760:12895:13069:13311:13357:13439:14096:14097:14181:14659:14721:21080:21627:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: bomb45_3996d8da96060 X-Filterd-Recvd-Size: 2666 Message-ID: <1493957394.31950.7.camel@perches.com> Subject: Re: [PATCHv4 3/3] drm/vgem: Enable dmabuf import interfaces From: Joe Perches To: Chris Wilson , Laura Abbott Cc: Daniel Vetter , Sean Paul , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Sumit Semwal , intel-gfx@lists.freedesktop.org, Joonas Lahtinen Date: Thu, 04 May 2017 21:09:54 -0700 In-Reply-To: <20170504202503.GP24019@nuc-i3427.alporthouse.com> References: <1493923548-20878-1-git-send-email-labbott@redhat.com> <1493923548-20878-4-git-send-email-labbott@redhat.com> <20170504202503.GP24019@nuc-i3427.alporthouse.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-05-04 at 21:25 +0100, Chris Wilson wrote: > On Thu, May 04, 2017 at 11:45:48AM -0700, Laura Abbott wrote: > > > > Enable the GEM dma-buf import interfaces in addition to the export > > interfaces. This lets vgem be used as a test source for other allocators > > (e.g. Ion). > > > > Reviewed-by: Chris Wilson > > Signed-off-by: Laura Abbott > > --- > > v4: Use new drm_gem_prime_import_dev function > > --- > > static const struct vm_operations_struct vgem_gem_vm_ops = { > > @@ -114,12 +142,8 @@ static void vgem_postclose(struct drm_device *dev, struct drm_file *file) > > kfree(vfile); > > } > > > > -/* ioctls */ > > - > > -static struct drm_gem_object *vgem_gem_create(struct drm_device *dev, > > - struct drm_file *file, > > - unsigned int *handle, > > - unsigned long size) > > +static struct drm_vgem_gem_object *__vgem_gem_create(struct drm_device *dev, > > + unsigned long size) > > I'm going to guess that doesn't line up anymore. If checkpatch isn't > complaining, then sorry for the noise. Because of the very long identifiers, perhaps a nicer way to write this is like: static struct drm_vgem_gem_object * __vgen_gem_create(struct drm_device *dev, unsigned long size); > > +static struct drm_gem_object *vgem_gem_create(struct drm_device *dev, > > + struct drm_file *file, > > + unsigned int *handle, > > + unsigned long size) > > Ditto. etc...