From: Gerd Hoffmann <kraxel@redhat.com>
To: Philippe Voinov <philippevoinov@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ui: input-linux: Add absolute event support
Date: Fri, 05 May 2017 10:39:46 +0200 [thread overview]
Message-ID: <1493973586.371.65.camel@redhat.com> (raw)
In-Reply-To: <20170505075918.4033-1-philippevoinov@gmail.com>
Hi,
> This patch allows, for example, uinput to be used to create virtual
> absolute input devices. This lets you build external systems which share
> physical input devices between guests.
Ah, interesting.
> +static bool input_linux_abs_range_is_valid(int min, int max)
> +{
> + int64_t difference = ((int64_t) max) - ((int64_t) min);
> + return difference > 0 && difference <= INT_MAX;
> +}
Does this happen in practice?
If so we might consider improving ui/input.c instead.
cheers,
Gerd
next prev parent reply other threads:[~2017-05-05 8:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 7:59 [Qemu-devel] [PATCH] ui: input-linux: Add absolute event support Philippe Voinov
2017-05-05 8:39 ` Gerd Hoffmann [this message]
2017-05-05 9:29 ` Philippe Voinov
2017-05-05 10:01 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493973586.371.65.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=philippevoinov@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.