From: Walker, Benjamin <benjamin.walker at intel.com>
To: spdk@lists.01.org
Subject: Re: [SPDK] [spdk/spdk] Master Pull request for DPDK and Posix abstraction changes. (#152)
Date: Fri, 05 May 2017 21:39:20 +0000 [thread overview]
Message-ID: <1494020358.3021.9.camel@intel.com> (raw)
In-Reply-To: 8485E02B-6B2F-46E4-AEB1-A34F3C5733C3@gmail.com
[-- Attachment #1: Type: text/plain, Size: 1811 bytes --]
On Fri, 2017-05-05 at 09:24 -0400, John Meneghini wrote:
> Also, with these changes we are trying to encourage more community
> participation.
>
> I think there are many other individuals and companies in the SPDK community
> who have a stake in these change. As we go through this list of proposed
> patches (31 in all) I’d like to see some reviews and approvals from others in
> the community.
>
> Can we agree upon a criteria for approval with changes?
>
> I propose a criteria of at least 3 approvals for all commits:
>
> 1. from the proposing individual or representative company
> 2. from the Intel SPDK development team
> 3. from a third party
>
> Thoughts?
Feedback is always welcome from anyone. I encourage anyone with an opinion to
post comments on the pull requests. We'll leave each request open for a few days
minimum to solicit feedback.
The official process is that the SPDK maintainers (currently Daniel, Jim, and
myself) can accept or deny a patch as we see fit. However, in practice that's
going to mean that we've gathered feedback from all of the interested parties
and we're confident that the patch meets everyone's needs. We won't ever just
plow ahead without consensus unless we're not getting any participation.
For this particular series, we're not going to merge anything unless both you
and Ranjit are ok with it (or provide no feedback for an extended period of
time), since you two are the primary stakeholders in this effort. We're also
going to try and poke a few people who have shown interest in this in the past
and try to get some more feedback that way. If anyone else is interested in the
DPDK/POSIX abstractions and starts commenting, we'll make sure their feedback is
all incorporated into the final patches as well.
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3274 bytes --]
next reply other threads:[~2017-05-05 21:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 21:39 Walker, Benjamin [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-05-05 13:24 [SPDK] [spdk/spdk] Master Pull request for DPDK and Posix abstraction changes. (#152) John Meneghini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494020358.3021.9.camel@intel.com \
--to=spdk@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.