Re: [PATCH] block: Remove leading whitespace and trailing newline in elevator switch error message

[Bart Van Assche <Bart.VanAssche@sandisk.com>]

On Mon, 2017-05-08 at 18:48 +0200, markus@trippelsdorf.de wrote:
> On 2017.05.08 at 15:47 +0000, Bart Van Assche wrote:
> > On Sat, 2017-05-06 at 07:22 +0200, markus@trippelsdorf.de wrote:
> > > -	ret =3D __elevator_change(q, name);
> > > +	strlcpy(elevator_name, skip_spaces(name), sizeof(elevator_name));
> >=20
> > Please include the version number of a patch in the e-mail subject line=
 when
> > posting a second or later version. Regarding the strlcpy() call, in the
> > FreeBSD strlcpy() man page I found the following: "If the src and dst s=
trings
> > overlap, the behavior is undefined." Since the Linux kernel implementat=
ion of
> > strlcpy() uses memcpy() and since the ANSI C standard does not allow th=
at
> > memcpy() input and output buffers overlap, please rework this code. See=
 e.g.
> > http://pubs.opengroup.org/onlinepubs/9699919799/functions/memcpy.html
>=20
> I don't see how src and dst could possibly overlap here.

Hello Markus,

Sorry - I misread your patch. Since that was the only comment I had:

Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>=