From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa6.hgst.iphmx.com ([216.71.154.45]:36645 "EHLO esa6.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750968AbdEHVZp (ORCPT ); Mon, 8 May 2017 17:25:45 -0400 From: Bart Van Assche To: "nab@linux-iscsi.org" CC: "hch@lst.de" , "ddiss@suse.de" , "hare@suse.com" , "target-devel@vger.kernel.org" , "agrover@redhat.com" , "stable@vger.kernel.org" Subject: Re: [PATCH 03/19] target: Avoid that aborting a command sporadically hangs Date: Mon, 8 May 2017 21:25:33 +0000 Message-ID: <1494278731.2591.17.camel@sandisk.com> References: <20170504225102.8931-1-bart.vanassche@sandisk.com> <20170504225102.8931-4-bart.vanassche@sandisk.com> <1494195644.30469.19.camel@haakon3.risingtidesystems.com> In-Reply-To: <1494195644.30469.19.camel@haakon3.risingtidesystems.com> Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org List-ID: On Sun, 2017-05-07 at 15:20 -0700, Nicholas A. Bellinger wrote: > aborted =3D true is only set when transport_generic_free_cmd() > is called with wait_for_tasks =3D true, and neither srpt nor isert have > ever invoked transport_generic_free_cmd() with wait_for_tasks =3D true in > upstream code. Right. Although this patch is not wrong, this patch is not needed with the current transport_generic_free_cmd() implementation but has to be folded in the patch that eliminates the "aborted" and "tas" variables (which is not in the series I posted). Bart.=