All of lore.kernel.org
 help / color / mirror / Atom feed
From: <gregkh@linuxfoundation.org>
To: luciano.coelho@intel.com, gregkh@linuxfoundation.org
Cc: <stable@vger.kernel.org>, <stable-commits@vger.kernel.org>
Subject: Patch "iwlwifi: mvm: don't restart HW if suspend fails with unified image" has been added to the 4.9-stable tree
Date: Tue, 09 May 2017 11:41:10 +0200	[thread overview]
Message-ID: <1494322870228177@kroah.com> (raw)


This is a note to let you know that I've just added the patch titled

    iwlwifi: mvm: don't restart HW if suspend fails with unified image

to the 4.9-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     iwlwifi-mvm-don-t-restart-hw-if-suspend-fails-with-unified-image.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From bac453ab3745eaa64137ea6e77e009b45954f0ae Mon Sep 17 00:00:00 2001
From: Luca Coelho <luciano.coelho@intel.com>
Date: Fri, 7 Oct 2016 15:16:26 +0300
Subject: iwlwifi: mvm: don't restart HW if suspend fails with unified image

From: Luca Coelho <luciano.coelho@intel.com>

commit bac453ab3745eaa64137ea6e77e009b45954f0ae upstream.

For unified images, we shouldn't restart the HW if suspend fails.  The
only reason for restarting the HW with non-unified images is to go
back to the D0 image.

Fixes: 23ae61282b88 ("iwlwifi: mvm: Do not switch to D3 image on suspend")
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/net/wireless/intel/iwlwifi/mvm/d3.c |   13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

--- a/drivers/net/wireless/intel/iwlwifi/mvm/d3.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/d3.c
@@ -1262,12 +1262,15 @@ static int __iwl_mvm_suspend(struct ieee
 	iwl_trans_d3_suspend(mvm->trans, test, !unified_image);
  out:
 	if (ret < 0) {
-		iwl_mvm_ref(mvm, IWL_MVM_REF_UCODE_DOWN);
-		if (mvm->restart_fw > 0) {
-			mvm->restart_fw--;
-			ieee80211_restart_hw(mvm->hw);
-		}
 		iwl_mvm_free_nd(mvm);
+
+		if (!unified_image) {
+			iwl_mvm_ref(mvm, IWL_MVM_REF_UCODE_DOWN);
+			if (mvm->restart_fw > 0) {
+				mvm->restart_fw--;
+				ieee80211_restart_hw(mvm->hw);
+			}
+		}
 	}
  out_noreset:
 	mutex_unlock(&mvm->mutex);


Patches currently in stable-queue which might be from luciano.coelho@intel.com are

queue-4.9/iwlwifi-mvm-synchronize-firmware-dma-paging-memory.patch
queue-4.9/iwlwifi-mvm-overwrite-skb-info-later.patch
queue-4.9/iwlwifi-mvm-fix-reorder-timer-re-arming.patch
queue-4.9/iwlwifi-mvm-pcie-adjust-a-msdu-tx_cmd-length-in-pcie.patch
queue-4.9/iwlwifi-pcie-fix-the-set-of-dma-memory-mask.patch
queue-4.9/iwlwifi-mvm-fix-pending-frame-counter-calculation.patch
queue-4.9/iwlwifi-mvm-writing-zero-bytes-to-debugfs-causes-a-crash.patch
queue-4.9/iwlwifi-pcie-trans-remove-unused-shift_param.patch
queue-4.9/iwlwifi-mvm-don-t-restart-hw-if-suspend-fails-with-unified-image.patch
queue-4.9/iwlwifi-fix-module_firmware-for-6030.patch
queue-4.9/iwlwifi-mvm-use-aux-queue-for-offchannel-frames-in-dqa.patch
queue-4.9/iwlwifi-pcie-don-t-increment-decrement-a-bool.patch
queue-4.9/iwlwifi-mvm-fix-references-to-first_agg_queue-in-dqa-mode.patch

                 reply	other threads:[~2017-05-09  9:41 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1494322870228177@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=luciano.coelho@intel.com \
    --cc=stable-commits@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.