From: Mike Galbraith <efault@gmx.de>
To: Jens Axboe <axboe@fb.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: get/put_cpu() usage in block/blk-mq.c
Date: Tue, 09 May 2017 18:26:43 +0200 [thread overview]
Message-ID: <1494347203.4440.24.camel@gmx.de> (raw)
In-Reply-To: <19592821-f779-176e-ecb5-a98e846824d6@fb.com>
On Tue, 2017-05-09 at 09:45 -0600, Jens Axboe wrote:
> > > > > > Is it from this_cpu_ptr() in blk_stat_add()?
> > > > >
> > > > > Yeah.
> > > >
> > > > So why is this complaining, doesn't rcu_read_lock() disable
> > > > preemption?
> > >
> > > Ah, I guess it doesn't if PREEMPT_RCU is set. How about the
> > > below?
> >
> > Should do it. I was about to run LTP (where it turned up) again
> > anyway, I'll add this. No news is good news, what you should hear.
>
> Thanks, let me know, so I can add your tested-by (or whatever you
> prefer).
Sure, but s/get_cpu_var/get_cpu_ptr first.
-MIke
next prev parent reply other threads:[~2017-05-09 16:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-09 6:07 get/put_cpu() usage in block/blk-mq.c Mike Galbraith
2017-05-09 14:53 ` Jens Axboe
2017-05-09 15:04 ` Mike Galbraith
2017-05-09 15:13 ` Jens Axboe
2017-05-09 15:15 ` Jens Axboe
2017-05-09 15:40 ` Mike Galbraith
2017-05-09 15:45 ` Jens Axboe
2017-05-09 16:26 ` Mike Galbraith [this message]
2017-05-09 16:32 ` Jens Axboe
2017-05-09 16:52 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494347203.4440.24.camel@gmx.de \
--to=efault@gmx.de \
--cc=axboe@fb.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.