From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44222) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8ART-0001gj-GW for qemu-devel@nongnu.org; Tue, 09 May 2017 15:05:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8ARQ-0001DU-7u for qemu-devel@nongnu.org; Tue, 09 May 2017 15:05:03 -0400 Received: from mail.kernel.org ([198.145.29.136]:43460) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d8ARQ-0001D9-2X for qemu-devel@nongnu.org; Tue, 09 May 2017 15:05:00 -0400 From: Stefano Stabellini Date: Tue, 9 May 2017 12:04:52 -0700 Message-Id: <1494356693-13190-2-git-send-email-sstabellini@kernel.org> In-Reply-To: <1494356693-13190-1-git-send-email-sstabellini@kernel.org> References: <1494356693-13190-1-git-send-email-sstabellini@kernel.org> Subject: [Qemu-devel] [PATCH v2 2/3] Check the return value of fcntl in qemu_set_cloexec List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: xen-devel@lists.xen.org, sstabellini@kernel.org, groug@kaod.org, pbonzini@redhat.com, Eric Blake Assert that the return value is not an error. This issue was found by Coverity. CID: 1374831 Signed-off-by: Stefano Stabellini CC: groug@kaod.org CC: pbonzini@redhat.com CC: Eric Blake --- util/oslib-posix.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/util/oslib-posix.c b/util/oslib-posix.c index 4d9189e..16894ad 100644 --- a/util/oslib-posix.c +++ b/util/oslib-posix.c @@ -182,7 +182,9 @@ void qemu_set_cloexec(int fd) { int f; f = fcntl(fd, F_GETFD); - fcntl(fd, F_SETFD, f | FD_CLOEXEC); + assert(f != -1); + f = fcntl(fd, F_SETFD, f | FD_CLOEXEC); + assert(f != -1); } /* -- 1.9.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Stabellini Subject: [PATCH v2 2/3] Check the return value of fcntl in qemu_set_cloexec Date: Tue, 9 May 2017 12:04:52 -0700 Message-ID: <1494356693-13190-2-git-send-email-sstabellini@kernel.org> References: <1494356693-13190-1-git-send-email-sstabellini@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1494356693-13190-1-git-send-email-sstabellini@kernel.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, sstabellini@kernel.org, Eric Blake , groug@kaod.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org QXNzZXJ0IHRoYXQgdGhlIHJldHVybiB2YWx1ZSBpcyBub3QgYW4gZXJyb3IuIFRoaXMgaXNzdWUg d2FzIGZvdW5kIGJ5CkNvdmVyaXR5LgoKQ0lEOiAxMzc0ODMxCgpTaWduZWQtb2ZmLWJ5OiBTdGVm YW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+CkNDOiBncm91Z0BrYW9kLm9y ZwpDQzogcGJvbnppbmlAcmVkaGF0LmNvbQpDQzogRXJpYyBCbGFrZSA8ZWJsYWtlQHJlZGhhdC5j b20+Ci0tLQogdXRpbC9vc2xpYi1wb3NpeC5jIHwgNCArKystCiAxIGZpbGUgY2hhbmdlZCwgMyBp bnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvdXRpbC9vc2xpYi1wb3Np eC5jIGIvdXRpbC9vc2xpYi1wb3NpeC5jCmluZGV4IDRkOTE4OWUuLjE2ODk0YWQgMTAwNjQ0Ci0t LSBhL3V0aWwvb3NsaWItcG9zaXguYworKysgYi91dGlsL29zbGliLXBvc2l4LmMKQEAgLTE4Miw3 ICsxODIsOSBAQCB2b2lkIHFlbXVfc2V0X2Nsb2V4ZWMoaW50IGZkKQogewogICAgIGludCBmOwog ICAgIGYgPSBmY250bChmZCwgRl9HRVRGRCk7Ci0gICAgZmNudGwoZmQsIEZfU0VURkQsIGYgfCBG RF9DTE9FWEVDKTsKKyAgICBhc3NlcnQoZiAhPSAtMSk7CisgICAgZiA9IGZjbnRsKGZkLCBGX1NF VEZELCBmIHwgRkRfQ0xPRVhFQyk7CisgICAgYXNzZXJ0KGYgIT0gLTEpOwogfQogCiAvKgotLSAK MS45LjEKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpY ZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlz dHMueGVuLm9yZy94ZW4tZGV2ZWwK