From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Tue, 09 May 2017 20:52:34 +0000 Subject: Re: [PATCH] checkpatch: Adjust regular expressions in $logFunctions Message-Id: <1494363154.20782.7.camel@perches.com> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring , Andy Whitcroft Cc: LKML , kernel-janitors@vger.kernel.org On Tue, 2017-05-09 at 21:00 +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 9 May 2017 20:40:51 +0200 > > * Two alternations contained an empty element. Use the question mark > metacharacter instead to express optional items in the search pattern. > > * Some alternation elements shared a common prefix (like an underscore). > Improve the specification of this detail by more non-capturing groups. No thanks. Perl is odd enough already adding more non-capture groups when the arguments are clearly specified is harder to read. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753431AbdEIUwk (ORCPT ); Tue, 9 May 2017 16:52:40 -0400 Received: from smtprelay0136.hostedemail.com ([216.40.44.136]:40194 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750795AbdEIUwj (ORCPT ); Tue, 9 May 2017 16:52:39 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2393:2553:2559:2562:2734:2828:3138:3139:3140:3141:3142:3351:3622:3865:3866:3867:3870:3871:4321:5007:7576:7903:10004:10400:10848:10967:11232:11658:11914:12043:12663:12740:12760:12895:13069:13311:13357:13439:14659:14721:21080:21451:21627:30041:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: need46_16cdcc9d4af2d X-Filterd-Recvd-Size: 1468 Message-ID: <1494363154.20782.7.camel@perches.com> Subject: Re: [PATCH] checkpatch: Adjust regular expressions in $logFunctions From: Joe Perches To: SF Markus Elfring , Andy Whitcroft Cc: LKML , kernel-janitors@vger.kernel.org Date: Tue, 09 May 2017 13:52:34 -0700 In-Reply-To: References: Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-05-09 at 21:00 +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 9 May 2017 20:40:51 +0200 > > * Two alternations contained an empty element. Use the question mark > metacharacter instead to express optional items in the search pattern. > > * Some alternation elements shared a common prefix (like an underscore). > Improve the specification of this detail by more non-capturing groups. No thanks. Perl is odd enough already adding more non-capture groups when the arguments are clearly specified is harder to read.