From: Johannes Berg <johannes@sipsolutions.net>
To: mike@hellotwist.com
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Validate michael MIC before attempting packet decode.
Date: Wed, 10 May 2017 12:44:31 +0200 [thread overview]
Message-ID: <1494413071.5482.5.camel@sipsolutions.net> (raw)
In-Reply-To: <CAKXXJEzWfNrQxquCzA5dkD5=xCXWyeAC+_yBT35N1oDk-H_Buw@mail.gmail.com> (sfid-20170509_201632_574132_3ABEEF43)
On Tue, 2017-05-09 at 14:16 -0400, Michael Skeffington wrote:
> In order to allow wpa_supplicant to correctly identify a perceived
> WPA TKIP key
> recovery attack the michael MIC must be checked before the packet
> decode is
> attempted. A packet with an invalid MIC will always fail a decrypt
> check which
> previously was being checked first. Therefore the MIC failure bit of
> status flags
> describing the error would remain unset.
This isn't how the Michael MIC works. I have no idea what problem
you're trying to solve, but this is not the solution.
johannes
next prev parent reply other threads:[~2017-05-10 10:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-09 18:16 [PATCH] mac80211: Validate michael MIC before attempting packet decode Michael Skeffington
2017-05-10 10:44 ` Johannes Berg [this message]
2017-05-10 12:24 ` Jouni Malinen
2017-05-11 20:22 ` Michael Skeffington
2017-05-12 8:52 ` Johannes Berg
2017-05-16 19:57 ` Michael Skeffington
2017-05-16 20:17 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494413071.5482.5.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mike@hellotwist.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.