Re: [PATCH v3 2/2] ndctl: add list --media-errors support

["Kani, Toshimitsu" <toshi.kani@hpe.com>]

On Wed, 2017-05-10 at 12:56 -0700, Dave Jiang wrote:
> 
> On 05/10/2017 11:43 AM, Kani, Toshimitsu wrote:
> > On Wed, 2017-05-10 at 11:03 -0700, Dave Jiang wrote:
> > > ACPI NFIT enabled platforms provide media errors as absolute
> > > phyiscal
> > > address offsets. Add an option to ndctl to display those media
> > > errors
> > > tranlsated to region and namespace device level offsets in an
> > > "ndctl
> > > list" listing.
> > > 
> > > Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> > > ---
> > > 
> > > v2: added fix to badblocks display from Toshi's testing result.
> > > v3: fixed naming issues from Dan's comments.
> > >     fixed badblocks boundary offset calculations from Toshi's
> > > testing.
> > 
> > Thanks for the quick update.  This version works nicely for dax and
> > memory modes.  Is there particular reason why it does not list
> > errors for raw and sector modes?
> 
> So it should work for raw AFAICT. Dan said the BTT ones don't make
> sense because the namespace relative offset is dynamic.
> 
> 
> # ./ndctl/ndctl list -NM
> [
>   {
>     "dev":"namespace5.0",
>     "mode":"raw",
>     "size":33554432,
>     "uuid":"bb3539dd-065c-41bd-8bcc-dc3bbc3317a5",
>     "badblocks":[
>       {
>         "offset":4,
>         "length":1
>       },
>       {
>         "offset":32768,
>         "length":8
>       },
>       {
>         "offset":65528,
>         "length":8
>       }
>     ],
>     "blockdev":"pmem5"
>   },

Attached "strace.log".  Note, there is no reference to "badblocks"
files in the log.

I agree that offsets do not make sense for BTT, but it leads to a false
impression that there is no error.  Perhaps, we can remove "offset" or
put "n/a" for BTT.  

Thanks,
-Toshi


_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm