From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH 2/2] eal: Fix compilation on C++
Date: Mon, 17 Aug 2015 17:50:15 +0200
Message-ID: <1494488.ouvK29kKhu@xps13>
References: <1435927863-3398-1-git-send-email-joongi@an.kaist.ac.kr>
 <1435927863-3398-2-git-send-email-joongi@an.kaist.ac.kr>
 <3151494.cFXF6huzQX@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org
To: Joongi Kim <joongi@an.kaist.ac.kr>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com
 [209.85.212.179]) by dpdk.org (Postfix) with ESMTP id 575E78DA9
 for <dev@dpdk.org>; Mon, 17 Aug 2015 17:51:30 +0200 (CEST)
Received: by wicja10 with SMTP id ja10so84735029wic.1
 for <dev@dpdk.org>; Mon, 17 Aug 2015 08:51:29 -0700 (PDT)
In-Reply-To: <3151494.cFXF6huzQX@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-08-17 17:29, Thomas Monjalon:
> 2015-07-03 21:51, Joongi Kim:
> >  * Forward declaration of enum in C++ requires explicit underlying
> >    type definitions.
> >=20
> >  * This fixes the issue at:
> >    http://dpdk.org/ml/archives/dev/2015-April/017065.html
> >=20
> > Signed-off-by: Joongi Kim <joongi@an.kaist.ac.kr>
>=20
> Does the problem appear only with rte_hash_crc.h inclusion?
>=20
> The reported errors were:
>=20
> include/generic/rte_cpuflags.h:50:6:
> error: use of enum =E2=80=98rte_cpu_flag_t=E2=80=99 without previous =
declaration
>  enum rte_cpu_flag_t;
>=20
> include/generic/rte_cpuflags.h:55:6:
> error: use of enum =E2=80=98cpu_register_t=E2=80=99 without previous =
declaration
>  enum cpu_register_t;
>=20
> >  lib/librte_eal/common/include/arch/x86/rte_cpuflags.h |  4 ++--
> >  lib/librte_eal/common/include/generic/rte_cpuflags.h  | 12 +++++++=
+++--
>=20
> Do we need to update lib/librte_eal/common/include/arch/ppc_64/rte_cp=
uflags.h
> and lib/librte_eal/common/include/arch/tile/rte_cpuflags.h as well?
>=20
> Thanks

Applied with same fixes for ppc and tile, thanks