From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8ADE221A04E1D for ; Thu, 11 May 2017 04:38:11 -0700 (PDT) Message-ID: <1494502687.6967.2.camel@linux.intel.com> Subject: Re: [PATCH 03/16] uuid: rename uuid types From: Andy Shevchenko Date: Thu, 11 May 2017 14:38:07 +0300 In-Reply-To: <2612.1494440436@warthog.procyon.org.uk> References: <20170510180214.16852-4-hch@lst.de> <20170510180214.16852-1-hch@lst.de> <2612.1494440436@warthog.procyon.org.uk> Mime-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: David Howells , Christoph Hellwig Cc: linux-raid@vger.kernel.org, linux-nvdimm@lists.01.org, Shaohua Li , Amir Goldstein , linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, Mimi Zohar , Steven Whitehouse List-ID: T24gV2VkLCAyMDE3LTA1LTEwIGF0IDE5OjIwICswMTAwLCBEYXZpZCBIb3dlbGxzIHdyb3RlOgo+ IENocmlzdG9waCBIZWxsd2lnIDxoY2hAbHN0LmRlPiB3cm90ZToKPiAKPiA+IC0jZGVmaW5lIE5V TExfVVVJRF9MRQkJCQkJCQo+ID4gCVwKPiA+IC0JVVVJRF9MRSgweDAwMDAwMDAwLCAweDAwMDAs IDB4MDAwMCwgMHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwKPiA+IAlcCj4gPiAtCQkweDAwLCAweDAw LCAweDAwLCAweDAwKQo+ID4gKyNkZWZpbmUgTlVMTF9HVUlECQkJCQkJCQo+ID4gXAo+ID4gKwlH VUlEKDB4MDAwMDAwMDAsIDB4MDAwMCwgMHgwMDAwLCAweDAwLCAweDAwLCAweDAwLCAweDAwLAkK PiA+IFwKPiA+ICsJwqDCoMKgwqDCoDB4MDAsIDB4MDAsIDB4MDAsIDB4MDApCj4gPiDCoAo+ID4g LSNkZWZpbmUgTlVMTF9VVUlEX0JFCQkJCQkJCj4gPiAJXAo+ID4gLQlVVUlEX0JFKDB4MDAwMDAw MDAsIDB4MDAwMCwgMHgwMDAwLCAweDAwLCAweDAwLCAweDAwLCAweDAwLAo+ID4gCVwKPiA+IC0J CTB4MDAsIDB4MDAsIDB4MDAsIDB4MDApCj4gPiArI2RlZmluZSBOVUxMX1VVSUQJCQkJCQkJCj4g PiBcCj4gPiArCVVVSUQoMHgwMDAwMDAwMCwgMHgwMDAwLCAweDAwMDAsIDB4MDAsIDB4MDAsIDB4 MDAsIDB4MDAsCQo+ID4gXAo+ID4gKwnCoMKgwqDCoMKgMHgwMCwgMHgwMCwgMHgwMCwgMHgwMCkK PiAKPiBUaGVzZSBhcmUgVUFQSSBhbmQgb3VnaHQgbm90IHRvIGJlIHJlbmFtZWQuCj4gCgpHb29k IHBvaW50LiBJIHNlZSBpbiB0aGUgYnJhbmNoIGl0J3MgYWxyZWFkeSBmaXhlZC4KCgotLSAKQW5k eSBTaGV2Y2hlbmtvIDxhbmRyaXkuc2hldmNoZW5rb0BsaW51eC5pbnRlbC5jb20+CkludGVsIEZp bmxhbmQgT3kKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K TGludXgtbnZkaW1tIG1haWxpbmcgbGlzdApMaW51eC1udmRpbW1AbGlzdHMuMDEub3JnCmh0dHBz Oi8vbGlzdHMuMDEub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbnZkaW1tCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH 03/16] uuid: rename uuid types Date: Thu, 11 May 2017 14:38:07 +0300 Message-ID: <1494502687.6967.2.camel@linux.intel.com> References: <20170510180214.16852-4-hch@lst.de> <20170510180214.16852-1-hch@lst.de> <2612.1494440436@warthog.procyon.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <2612.1494440436-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: David Howells , Christoph Hellwig Cc: linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, Shaohua Li , Amir Goldstein , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mimi Zohar , Steven Whitehouse List-Id: linux-raid.ids T24gV2VkLCAyMDE3LTA1LTEwIGF0IDE5OjIwICswMTAwLCBEYXZpZCBIb3dlbGxzIHdyb3RlOgo+ IENocmlzdG9waCBIZWxsd2lnIDxoY2hAbHN0LmRlPiB3cm90ZToKPiAKPiA+IC0jZGVmaW5lIE5V TExfVVVJRF9MRQkJCQkJCQo+ID4gCVwKPiA+IC0JVVVJRF9MRSgweDAwMDAwMDAwLCAweDAwMDAs IDB4MDAwMCwgMHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwKPiA+IAlcCj4gPiAtCQkweDAwLCAweDAw LCAweDAwLCAweDAwKQo+ID4gKyNkZWZpbmUgTlVMTF9HVUlECQkJCQkJCQo+ID4gXAo+ID4gKwlH VUlEKDB4MDAwMDAwMDAsIDB4MDAwMCwgMHgwMDAwLCAweDAwLCAweDAwLCAweDAwLCAweDAwLAkK PiA+IFwKPiA+ICsJwqDCoMKgwqDCoDB4MDAsIDB4MDAsIDB4MDAsIDB4MDApCj4gPiDCoAo+ID4g LSNkZWZpbmUgTlVMTF9VVUlEX0JFCQkJCQkJCj4gPiAJXAo+ID4gLQlVVUlEX0JFKDB4MDAwMDAw MDAsIDB4MDAwMCwgMHgwMDAwLCAweDAwLCAweDAwLCAweDAwLCAweDAwLAo+ID4gCVwKPiA+IC0J CTB4MDAsIDB4MDAsIDB4MDAsIDB4MDApCj4gPiArI2RlZmluZSBOVUxMX1VVSUQJCQkJCQkJCj4g PiBcCj4gPiArCVVVSUQoMHgwMDAwMDAwMCwgMHgwMDAwLCAweDAwMDAsIDB4MDAsIDB4MDAsIDB4 MDAsIDB4MDAsCQo+ID4gXAo+ID4gKwnCoMKgwqDCoMKgMHgwMCwgMHgwMCwgMHgwMCwgMHgwMCkK PiAKPiBUaGVzZSBhcmUgVUFQSSBhbmQgb3VnaHQgbm90IHRvIGJlIHJlbmFtZWQuCj4gCgpHb29k IHBvaW50LiBJIHNlZSBpbiB0aGUgYnJhbmNoIGl0J3MgYWxyZWFkeSBmaXhlZC4KCgotLSAKQW5k eSBTaGV2Y2hlbmtvIDxhbmRyaXkuc2hldmNoZW5rb0BsaW51eC5pbnRlbC5jb20+CkludGVsIEZp bmxhbmQgT3kKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K TGludXgtbnZkaW1tIG1haWxpbmcgbGlzdApMaW51eC1udmRpbW1AbGlzdHMuMDEub3JnCmh0dHBz Oi8vbGlzdHMuMDEub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbnZkaW1tCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com ([192.55.52.115]:34112 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754486AbdEKLiU (ORCPT ); Thu, 11 May 2017 07:38:20 -0400 Message-ID: <1494502687.6967.2.camel@linux.intel.com> Subject: Re: [PATCH 03/16] uuid: rename uuid types From: Andy Shevchenko Date: Thu, 11 May 2017 14:38:07 +0300 In-Reply-To: <2612.1494440436@warthog.procyon.org.uk> References: <20170510180214.16852-4-hch@lst.de> <20170510180214.16852-1-hch@lst.de> <2612.1494440436@warthog.procyon.org.uk> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: David Howells , Christoph Hellwig Cc: Amir Goldstein , linux-fsdevel@vger.kernel.org, Shaohua Li , Dan Williams , Steven Whitehouse , Mimi Zohar , linux-xfs@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org On Wed, 2017-05-10 at 19:20 +0100, David Howells wrote: > Christoph Hellwig wrote: > > > -#define NULL_UUID_LE > > \ > > - UUID_LE(0x00000000, 0x0000, 0x0000, 0x00, 0x00, 0x00, 0x00, > > \ > > - 0x00, 0x00, 0x00, 0x00) > > +#define NULL_GUID > > \ > > + GUID(0x00000000, 0x0000, 0x0000, 0x00, 0x00, 0x00, 0x00, > > \ > > +      0x00, 0x00, 0x00, 0x00) > >   > > -#define NULL_UUID_BE > > \ > > - UUID_BE(0x00000000, 0x0000, 0x0000, 0x00, 0x00, 0x00, 0x00, > > \ > > - 0x00, 0x00, 0x00, 0x00) > > +#define NULL_UUID > > \ > > + UUID(0x00000000, 0x0000, 0x0000, 0x00, 0x00, 0x00, 0x00, > > \ > > +      0x00, 0x00, 0x00, 0x00) > > These are UAPI and ought not to be renamed. > Good point. I see in the branch it's already fixed. -- Andy Shevchenko Intel Finland Oy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932244AbdEKLiV (ORCPT ); Thu, 11 May 2017 07:38:21 -0400 Received: from mga14.intel.com ([192.55.52.115]:34112 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754486AbdEKLiU (ORCPT ); Thu, 11 May 2017 07:38:20 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,324,1491289200"; d="scan'208";a="967226080" Message-ID: <1494502687.6967.2.camel@linux.intel.com> Subject: Re: [PATCH 03/16] uuid: rename uuid types From: Andy Shevchenko To: David Howells , Christoph Hellwig Cc: Amir Goldstein , linux-fsdevel@vger.kernel.org, Shaohua Li , Dan Williams , Steven Whitehouse , Mimi Zohar , linux-xfs@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org Date: Thu, 11 May 2017 14:38:07 +0300 In-Reply-To: <2612.1494440436@warthog.procyon.org.uk> References: <20170510180214.16852-4-hch@lst.de> <20170510180214.16852-1-hch@lst.de> <2612.1494440436@warthog.procyon.org.uk> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-05-10 at 19:20 +0100, David Howells wrote: > Christoph Hellwig wrote: > > > -#define NULL_UUID_LE > > \ > > - UUID_LE(0x00000000, 0x0000, 0x0000, 0x00, 0x00, 0x00, 0x00, > > \ > > - 0x00, 0x00, 0x00, 0x00) > > +#define NULL_GUID > > \ > > + GUID(0x00000000, 0x0000, 0x0000, 0x00, 0x00, 0x00, 0x00, > > \ > > +      0x00, 0x00, 0x00, 0x00) > >   > > -#define NULL_UUID_BE > > \ > > - UUID_BE(0x00000000, 0x0000, 0x0000, 0x00, 0x00, 0x00, 0x00, > > \ > > - 0x00, 0x00, 0x00, 0x00) > > +#define NULL_UUID > > \ > > + UUID(0x00000000, 0x0000, 0x0000, 0x00, 0x00, 0x00, 0x00, > > \ > > +      0x00, 0x00, 0x00, 0x00) > > These are UAPI and ought not to be renamed. > Good point. I see in the branch it's already fixed. -- Andy Shevchenko Intel Finland Oy