From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B138121A04E29 for ; Thu, 11 May 2017 04:43:42 -0700 (PDT) Message-ID: <1494502838.6967.4.camel@linux.intel.com> Subject: Re: [PATCH 05/16] uuid: add the v1 layout to uuid_t From: Andy Shevchenko Date: Thu, 11 May 2017 14:40:38 +0300 In-Reply-To: <20170510180214.16852-6-hch@lst.de> References: <20170510180214.16852-1-hch@lst.de> <20170510180214.16852-6-hch@lst.de> Mime-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Christoph Hellwig , Amir Goldstein , linux-fsdevel@vger.kernel.org Cc: linux-xfs@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvdimm@lists.01.org, Shaohua Li , linux-kernel@vger.kernel.org, David Howells , Mimi Zohar , Steven Whitehouse List-ID: T24gV2VkLCAyMDE3LTA1LTEwIGF0IDIwOjAyICswMjAwLCBDaHJpc3RvcGggSGVsbHdpZyB3cm90 ZToKPiBUdXJuIHRoZSBjb250ZW50IG9mIHV1aWRfdCBpbnRvIGEgdW5pb24gYW5kIGFkZCB0aGUg ZmllbGRzIGZvciB0aGUgdjEKPiBpbnRlcnByZXRhdGlvbiB0byBpdC4KCkluIHRoZSBicmFuY2gg aXQgaGFzIGZpeCBmb3IgVVVJRCgpIHdydCB1bmlvbiBjaGFuZ2UsIGJ1dCB0aGVyZSBtaXNzZWQK c2ltaWxhciBmb3IgR1VJRCgpLgoKKyNkZWZpbmUgVVVJRChhLCBfYiwgYywgZDAsIGQxLCBkMiwg ZDMsIGQ0LCBkNSwgZDYsCmQ3KcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBcCit7 IC5iID0geyBcCgpeXl4gVGhpcyBzaG91bGQgYmUgZG9uZSBmb3IgR1VJRCgpIGFzIHdlbGwuCgpX aGlsZSBoZXJlLCBjYW4gd2UgaW5kZW50IFwgdG8gYmUgdGhlIHNhbWUgYXMgb2YgdGhlIHJlc3Qg bGluZXMgaW4KbWFjcm8ocykgPwoKLS0gCkFuZHkgU2hldmNoZW5rbyA8YW5kcml5LnNoZXZjaGVu a29AbGludXguaW50ZWwuY29tPgpJbnRlbCBGaW5sYW5kIE95Cl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LW52ZGltbSBtYWlsaW5nIGxpc3QKTGlu dXgtbnZkaW1tQGxpc3RzLjAxLm9yZwpodHRwczovL2xpc3RzLjAxLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LW52ZGltbQo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH 05/16] uuid: add the v1 layout to uuid_t Date: Thu, 11 May 2017 14:40:38 +0300 Message-ID: <1494502838.6967.4.camel@linux.intel.com> References: <20170510180214.16852-1-hch@lst.de> <20170510180214.16852-6-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170510180214.16852-6-hch-jcswGhMUV9g@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: Christoph Hellwig , Amir Goldstein , linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, Shaohua Li , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, David Howells , Mimi Zohar , Steven Whitehouse List-Id: linux-raid.ids T24gV2VkLCAyMDE3LTA1LTEwIGF0IDIwOjAyICswMjAwLCBDaHJpc3RvcGggSGVsbHdpZyB3cm90 ZToKPiBUdXJuIHRoZSBjb250ZW50IG9mIHV1aWRfdCBpbnRvIGEgdW5pb24gYW5kIGFkZCB0aGUg ZmllbGRzIGZvciB0aGUgdjEKPiBpbnRlcnByZXRhdGlvbiB0byBpdC4KCkluIHRoZSBicmFuY2gg aXQgaGFzIGZpeCBmb3IgVVVJRCgpIHdydCB1bmlvbiBjaGFuZ2UsIGJ1dCB0aGVyZSBtaXNzZWQK c2ltaWxhciBmb3IgR1VJRCgpLgoKKyNkZWZpbmUgVVVJRChhLCBfYiwgYywgZDAsIGQxLCBkMiwg ZDMsIGQ0LCBkNSwgZDYsCmQ3KcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBcCit7 IC5iID0geyBcCgpeXl4gVGhpcyBzaG91bGQgYmUgZG9uZSBmb3IgR1VJRCgpIGFzIHdlbGwuCgpX aGlsZSBoZXJlLCBjYW4gd2UgaW5kZW50IFwgdG8gYmUgdGhlIHNhbWUgYXMgb2YgdGhlIHJlc3Qg bGluZXMgaW4KbWFjcm8ocykgPwoKLS0gCkFuZHkgU2hldmNoZW5rbyA8YW5kcml5LnNoZXZjaGVu a29AbGludXguaW50ZWwuY29tPgpJbnRlbCBGaW5sYW5kIE95Cl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LW52ZGltbSBtYWlsaW5nIGxpc3QKTGlu dXgtbnZkaW1tQGxpc3RzLjAxLm9yZwpodHRwczovL2xpc3RzLjAxLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LW52ZGltbQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com ([134.134.136.31]:33396 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932370AbdEKLnn (ORCPT ); Thu, 11 May 2017 07:43:43 -0400 Message-ID: <1494502838.6967.4.camel@linux.intel.com> Subject: Re: [PATCH 05/16] uuid: add the v1 layout to uuid_t From: Andy Shevchenko Date: Thu, 11 May 2017 14:40:38 +0300 In-Reply-To: <20170510180214.16852-6-hch@lst.de> References: <20170510180214.16852-1-hch@lst.de> <20170510180214.16852-6-hch@lst.de> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Christoph Hellwig , Amir Goldstein , linux-fsdevel@vger.kernel.org Cc: Shaohua Li , Dan Williams , David Howells , Steven Whitehouse , Mimi Zohar , linux-xfs@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org On Wed, 2017-05-10 at 20:02 +0200, Christoph Hellwig wrote: > Turn the content of uuid_t into a union and add the fields for the v1 > interpretation to it. In the branch it has fix for UUID() wrt union change, but there missed similar for GUID(). +#define UUID(a, _b, c, d0, d1, d2, d3, d4, d5, d6, d7)                 \ +{ .b = { \ ^^^ This should be done for GUID() as well. While here, can we indent \ to be the same as of the rest lines in macro(s) ? -- Andy Shevchenko Intel Finland Oy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932411AbdEKLnp (ORCPT ); Thu, 11 May 2017 07:43:45 -0400 Received: from mga06.intel.com ([134.134.136.31]:33396 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932370AbdEKLnn (ORCPT ); Thu, 11 May 2017 07:43:43 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,324,1491289200"; d="scan'208";a="967227386" Message-ID: <1494502838.6967.4.camel@linux.intel.com> Subject: Re: [PATCH 05/16] uuid: add the v1 layout to uuid_t From: Andy Shevchenko To: Christoph Hellwig , Amir Goldstein , linux-fsdevel@vger.kernel.org Cc: Shaohua Li , Dan Williams , David Howells , Steven Whitehouse , Mimi Zohar , linux-xfs@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org Date: Thu, 11 May 2017 14:40:38 +0300 In-Reply-To: <20170510180214.16852-6-hch@lst.de> References: <20170510180214.16852-1-hch@lst.de> <20170510180214.16852-6-hch@lst.de> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-05-10 at 20:02 +0200, Christoph Hellwig wrote: > Turn the content of uuid_t into a union and add the fields for the v1 > interpretation to it. In the branch it has fix for UUID() wrt union change, but there missed similar for GUID(). +#define UUID(a, _b, c, d0, d1, d2, d3, d4, d5, d6, d7)                 \ +{ .b = { \ ^^^ This should be done for GUID() as well. While here, can we indent \ to be the same as of the rest lines in macro(s) ? -- Andy Shevchenko Intel Finland Oy