From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Luis Oliveira <Luis.Oliveira@synopsys.com>,
wsa@the-dreams.de, robh+dt@kernel.org, mark.rutland@arm.com,
mika.westerberg@linux.intel.com, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Ramiro.Oliveira@synopsys.com, Joao.Pinto@synopsys.com,
CARLOS.PALMINHA@synopsys.com
Subject: Re: [PATCH v9 5/6] i2c: designware: add SLAVE mode functions
Date: Thu, 11 May 2017 16:32:24 +0300 [thread overview]
Message-ID: <1494509544.6967.6.camel@linux.intel.com> (raw)
In-Reply-To: <f2c268ba-2f08-e6a6-2af7-b9b9b8afc49a@linux.intel.com>
On Thu, 2017-05-11 at 16:20 +0300, Jarkko Nikula wrote:
> On 05/08/2017 07:53 PM, Andy Shevchenko wrote:
> > > + } else if (reg == (DW_IC_COMP_TYPE_VALUE & 0x0000ffff)) {
> >
> > GENMASK(15, 0)
> >
>
> I don't think this increase readability compared to 0x0000ffff here.
If it's a defined constant it might do, otherwise I'm fine with explicit
value.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-05-11 13:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-08 10:37 [PATCH v9 0/6] i2c: designware: add I2C SLAVE support Luis Oliveira
2017-05-08 10:37 ` [PATCH v9 1/6] i2c: designware: Cleaning and comment style fixes Luis Oliveira
2017-05-08 10:37 ` [PATCH v9 2/6] i2c: designware: refactoring of the i2c-designware Luis Oliveira
2017-05-08 10:37 ` [PATCH v9 3/6] i2c: designware: MASTER mode as separated driver Luis Oliveira
2017-05-08 10:37 ` [PATCH v9 4/6] i2c: designware: introducing I2C_SLAVE definitions Luis Oliveira
2017-05-08 10:37 ` [PATCH v9 5/6] i2c: designware: add SLAVE mode functions Luis Oliveira
[not found] ` <b2accd73182d19927dfb0cd1a57cadf469ae5e9d.1493893241.git.lolivei-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2017-05-08 16:53 ` Andy Shevchenko
2017-05-08 16:53 ` Andy Shevchenko
[not found] ` <1494262399.30052.69.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-05-11 13:20 ` Jarkko Nikula
2017-05-11 13:20 ` Jarkko Nikula
2017-05-11 13:32 ` Andy Shevchenko [this message]
2017-05-22 14:32 ` Luis Oliveira
2017-05-22 14:32 ` Luis Oliveira
2017-05-22 16:37 ` Andy Shevchenko
2017-05-08 10:37 ` [PATCH v9 6/6] i2c: designware: enable SLAVE in platform module Luis Oliveira
2017-05-08 16:40 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494509544.6967.6.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=Joao.Pinto@synopsys.com \
--cc=Luis.Oliveira@synopsys.com \
--cc=Ramiro.Oliveira@synopsys.com \
--cc=devicetree@vger.kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.