From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: Re: [PATCH] IB/srp: Fix NULL deref at srp_destroy_qp() Date: Thu, 11 May 2017 15:26:32 +0000 Message-ID: <1494516391.2489.4.camel@sandisk.com> References: <1494515323-23869-1-git-send-email-israelr@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1494515323-23869-1-git-send-email-israelr-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> Content-Language: en-US Content-ID: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "israelr-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org" , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" Cc: "maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On Thu, 2017-05-11 at 18:08 +0300, Israel Rukshin wrote: > If srp_init_qp() fails at srp_create_ch_ib() then ch->send_cq > may be NULL. > Calling directly to ib_destroy_qp() is sufficient because > no work requests were posted on the created qp. Hello Israel, Thanks for the patch. Although this patch looks fine to me, please consider adding "Fixes: ..." and "Cc: stable" tags. Thanks, Bart.= -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html