Re: [PATCH v4 2/2] ndctl: add list --media-errors support

["Kani, Toshimitsu" <toshi.kani@hpe.com>]

On Thu, 2017-05-11 at 08:39 -0700, Dan Williams wrote:
> On Thu, May 11, 2017 at 8:31 AM, Kani, Toshimitsu <toshi.kani@hpe.com
> > wrote:
> > On Wed, 2017-05-10 at 16:57 -0700, Dave Jiang wrote:
> > > ACPI NFIT enabled platforms provide media errors as absolute
> > > phyiscal address offsets. Add an option to ndctl to display those
> > > media errors tranlsated to region and namespace device level
> > > offsets in an "ndctl list" listing. BTT badblocks show is not
> > > supported in this iteration and will come later.
> > > 
> > > Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> > > ---
> > > 
> > > v2: added fix to badblocks display from Toshi's testing result.
> > > v3: fixed naming issues from Dan's comments.
> > >     fixed badblocks boundary offset calculations from Toshi's
> > > testing.
> > > v4: Add indicator to show badblocks exist or not, per Toshi's
> > > comments.
> > 
> > This version works pretty good, except that it does not show
> > "has_badblocks" for sector mode.
> > 
> > # ndctl list -M -m sector
> > {
> >   "dev":"namespace0.0",
> >   "mode":"sector",
> >   "size":17162027008,
> >   "uuid":"7742dff3-3edd-4a28-894d-9ac1aede6b2c",
> >   "sector_size":4096,
> >   "blockdev":"pmem0s"
> > }
> 
> Since we're going to spin the patch to fix this up... Toshi, what do
> you think about changing "has_badblocks" to "badblock_count". My
> concern is that for the btt case it will also count badblocks that
> are on the free list or in metadata, but it at least gives you a
> better indication of the damage level of the underlying namespace.

Good idea.  Yes, I like "badblock_count" better.

Thanks!
-Toshi
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm