All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH v3 1/2] libnvdimm: add an atomic vs process context flag to rw_bytes
Date: Thu, 11 May 2017 16:14:52 +0000	[thread overview]
Message-ID: <1494519209.20330.11.camel@intel.com> (raw)
In-Reply-To: <CAPcyv4jbSZB-QFywszWpK2ZRODSR-J7t8KkPX-uMKaMRW1RYVQ@mail.gmail.com>

On Wed, 2017-05-10 at 22:15 -0700, Dan Williams wrote:
> On Wed, May 10, 2017 at 2:01 PM, Vishal Verma <vishal.l.verma@intel.co
> m> wrote:
> > nsio_rw_bytes can clear media errors, but this cannot be done while
> > we
> > are in an atomic context due to locking within ACPI. From the BTT,
> > ->rw_bytes may be called either from atomic or process context
> > depending
> > on whether the calls happen during initialization or during IO.
> > 
> > During init, we want to ensure error clearing happens, and the flag
> > marking process context allows nsio_rw_bytes to do that. When called
> > during IO, we're in atomic context, and error clearing can be
> > skipped.
> > 
> > Cc: Dan Williams <dan.j.williams@intel.com>
> > Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
> 
> Thanks Vishal, this one and the next look good to me.

Thanks - I had pushed this to my external nvdimm.git tree and it has
received a success notification -


    https://git.kernel.org/pub/scm/linux/kernel/git/vishal/nvdimm.git      li
    bnvdimm-btt-for-4.12
    7535ed9add87aad32af2e1127dc64eb107d02368  libnvdimm, btt: ensure that
    initializing metadata clears poison

    elapsed time: 391m

    configs tested: 156

    The following configs have been built successfully.
    More configs may be tested in the coming days.

    cris                 etrax-100lx_v2_defconfig
    blackfin                  TCM-BF537_defconfig
    blackfin            BF561-EZKIT-SMP_defconfig
    blackfin                BF533-EZKIT_defconfig
    blackfin                BF526-EZBRD_defconfig
    sh                                allnoconfig
    sh                          rsk7269_defconfig
    sh                  sh7785lcr_32bit_defconfig
    sh                            titan_defconfig
    x86_64                randconfig-in0-05110918
    x86_64                 randconfig-x015-201719
    x86_64                 randconfig-x012-201719
    x86_64                 randconfig-x010-201719
    x86_64                 randconfig-x017-201719
    x86_64                 randconfig-x011-201719
    x86_64                 randconfig-x018-201719
    x86_64                 randconfig-x014-201719
    x86_64                 randconfig-x013-201719
    x86_64                 randconfig-x016-201719
    x86_64                 randconfig-x019-201719
    ia64                              allnoconfig
    ia64                                defconfig
    ia64                             alldefconfig
    x86_64                                  kexec
    x86_64                                   rhel
    x86_64                               rhel-7.2
    i386                   randconfig-a0-05102342
    x86_64       nfsroot+CONFIG_DEBUG_INFO_REDUCED
    x86_64                             acpi-redef
    x86_64                           allyesdebian
    x86_64                                nfsroot
    parisc                        c3000_defconfig
    parisc                         b180_defconfig
    parisc                              defconfig
    alpha                               defconfig
    parisc                            allnoconfig
    i386                             allmodconfig
    m68k                           sun3_defconfig
    m68k                          multi_defconfig
    m68k                       m5475evb_defconfig
    mips                                   jz4740
    mips                      malta_kvm_defconfig
    mips                         64r6el_defconfig
    mips                           32r2_defconfig
    mips                              allnoconfig
    mips                      fuloong2e_defconfig
    mips                                     txx9
    powerpc                           allnoconfig
    powerpc                             defconfig
    powerpc                       ppc64_defconfig
    s390                        default_defconfig
    x86_64                 randconfig-i0-05102326
    i386                   randconfig-i1-05102355
    i386                   randconfig-i0-05102355
    x86_64                           allmodconfig
    mips                          ath79_defconfig
    c6x                        evmc6678_defconfig
    xtensa                       common_defconfig
    m32r                       m32104ut_defconfig
    xtensa                          iss_defconfig
    m32r                         opsput_defconfig
    m32r                           usrv_defconfig
    m32r                     mappi3.smp_defconfig
    nios2                         10m50_defconfig
    h8300                    h8300h-sim_defconfig
    i386                 randconfig-x010-05102342
    i386                 randconfig-x011-05102342
    i386                 randconfig-x012-05102342
    i386                 randconfig-x013-05102342
    i386                 randconfig-x014-05102342
    i386                 randconfig-x015-05102342
    i386                 randconfig-x016-05102342
    i386                 randconfig-x017-05102342
    i386                 randconfig-x018-05102342
    i386                 randconfig-x019-05102342
    mips                                defconfig
    x86_64                randconfig-ne0-05111110
    i386                               tinyconfig
    i386                 randconfig-x019-05102329
    i386                 randconfig-x015-05102329
    i386                 randconfig-x012-05102329
    i386                 randconfig-x011-05102329
    i386                 randconfig-x017-05102329
    i386                 randconfig-x013-05102329
    i386                 randconfig-x016-05102329
    i386                 randconfig-x010-05102329
    i386                 randconfig-x018-05102329
    i386                 randconfig-x014-05102329
    i386                   randconfig-n0-05102330
    mn10300                     asb2364_defconfig
    openrisc                    or1ksim_defconfig
    um                           x86_64_defconfig
    um                             i386_defconfig
    frv                                 defconfig
    tile                         tilegx_defconfig
    i386                 randconfig-x072-05102354
    i386                 randconfig-x077-05102354
    i386                 randconfig-x079-05102354
    i386                 randconfig-x078-05102354
    i386                 randconfig-x075-05102354
    i386                 randconfig-x071-05102354
    i386                 randconfig-x070-05102354
    i386                 randconfig-x076-05102354
    i386                 randconfig-x073-05102354
    i386                 randconfig-x074-05102354
    microblaze                      mmu_defconfig
    microblaze                    nommu_defconfig
    sparc                               defconfig
    sparc64                           allnoconfig
    sparc64                             defconfig
    score                      spct6600_defconfig
    arm                               allnoconfig
    arm                         at91_dt_defconfig
    arm                           efm32_defconfig
    arm                          exynos_defconfig
    arm                        multi_v5_defconfig
    arm                        multi_v7_defconfig
    arm                        shmobile_defconfig
    arm                           sunxi_defconfig
    arm64                             allnoconfig
    arm64                               defconfig
    i386                 randconfig-x070-05102330
    i386                 randconfig-x071-05102330
    i386                 randconfig-x072-05102330
    i386                 randconfig-x073-05102330
    i386                 randconfig-x074-05102330
    i386                 randconfig-x075-05102330
    i386                 randconfig-x076-05102330
    i386                 randconfig-x077-05102330
    i386                 randconfig-x078-05102330
    i386                 randconfig-x079-05102330
    i386                              allnoconfig
    i386                                defconfig
    i386                             alldefconfig
    x86_64               randconfig-x005-05102324
    x86_64               randconfig-x009-05102324
    x86_64               randconfig-x006-05102324
    x86_64               randconfig-x000-05102324
    x86_64               randconfig-x002-05102324
    x86_64               randconfig-x004-05102324
    x86_64               randconfig-x008-05102324
    x86_64               randconfig-x001-05102324
    x86_64               randconfig-x003-05102324
    x86_64               randconfig-x007-05102324
    i386                   randconfig-r0-05102325
    x86_64                 randconfig-r0-05102325
    i386                 randconfig-x003-05102322
    i386                 randconfig-x009-05102322
    i386                 randconfig-x005-05102322
    i386                 randconfig-x002-05102322
    i386                 randconfig-x008-05102322
    i386                 randconfig-x001-05102322
    i386                 randconfig-x007-05102322
    i386                 randconfig-x000-05102322
    i386                 randconfig-x006-05102322
    i386                 randconfig-x004-05102322
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

      reply	other threads:[~2017-05-11 16:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-10 21:01 [PATCH v3 1/2] libnvdimm: add an atomic vs process context flag to rw_bytes Vishal Verma
2017-05-10 21:01 ` [PATCH v3 2/2] libnvdimm, btt: ensure that initializing metadata clears poison Vishal Verma
2017-05-11  5:15 ` [PATCH v3 1/2] libnvdimm: add an atomic vs process context flag to rw_bytes Dan Williams
2017-05-11 16:14   ` Verma, Vishal L [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1494519209.20330.11.camel@intel.com \
    --to=vishal.l.verma@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=linux-nvdimm@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.