From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>,
"Jiang, Dave" <dave.jiang@intel.com>,
"toshi.kani@hpe.com" <toshi.kani@hpe.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH v5 2/2] ndctl: add list --media-errors support
Date: Thu, 11 May 2017 18:01:02 +0000 [thread overview]
Message-ID: <1494525578.20330.13.camel@intel.com> (raw)
In-Reply-To: <f32a0671-926f-04be-210e-bccd0bd4f1b7@intel.com>
On Thu, 2017-05-11 at 10:52 -0700, Dave Jiang wrote:
>
> On 05/11/2017 10:48 AM, Kani, Toshimitsu wrote:
> > On Thu, 2017-05-11 at 10:37 -0700, Dave Jiang wrote:
> > > ACPI NFIT enabled platforms provide media errors as absolute
> > > phyiscal
> > > address offsets. Add an option to ndctl to display those media
> > > errors
> > > tranlsated to region and namespace device level offsets in an
> > > "ndctl
> > > list" listing. BTT badblocks show is not supported in this
> > > iteration
> > > and will come later.
> > >
> > > Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> > > ---
> > >
> > > v2: added fix to badblocks display from Toshi's testing result.
> > > v3: fixed naming issues from Dan's comments.
> > > fixed badblocks boundary offset calculations from Toshi's
> > > testing.
> > > v4: Add indicator to show badblocks exist or not, per Toshi's
> > > comments.
> > > v5: Add BTT badblock_count from Toshi and Dan's comments.
> >
> > Thanks Dave for the quick update. Sorry, but I expected
> > "badblock_count" to be a number of badblock sectors, not a number of
> > badblock ranges.
>
> Ah! I'll fix that.
With the fix, you can add for the series
Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2017-05-11 18:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 17:37 [PATCH v5 1/2] ndctl: add foreach helper for region badblocks in libndctl Dave Jiang
2017-05-11 17:37 ` [PATCH v5 2/2] ndctl: add list --media-errors support Dave Jiang
2017-05-11 17:48 ` Kani, Toshimitsu
2017-05-11 17:52 ` Dave Jiang
2017-05-11 18:01 ` Verma, Vishal L [this message]
2017-05-11 17:50 ` [PATCH v5 1/2] ndctl: add foreach helper for region badblocks in libndctl Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494525578.20330.13.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=linux-nvdimm@lists.01.org \
--cc=toshi.kani@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.