From: Scott Wood <oss@buserror.net>
To: Boris Brezillon <boris.brezillon@free-electrons.com>,
Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
Cc: linux-mtd@lists.infradead.org, dedekind1@gmail.com
Subject: Re: [PATCH] driver: mtd: update struct map_info's swap as per map requirement.
Date: Mon, 15 May 2017 12:28:33 -0500 [thread overview]
Message-ID: <1494869313.29095.5.camel@buserror.net> (raw)
In-Reply-To: <20170515104824.2ffb5186@bbrezillon>
On Mon, 2017-05-15 at 10:48 +0200, Boris Brezillon wrote:
>
> You can even make this property a string property:
>
> if (!of_property_read_string(dp->parent,
> "cfi-endianness",
> &endianness)) {
> if (!strcmp("big", endianness))
> info->list[i].map.swap = CFI_BIG_ENDIAN;
> else if (!strcmp("little", endianness))
> info->list[i].map.swap = CFI_LITTLE_ENDIAN;
> else if (!strcmp("host", endianness))
> info->list[i].map.swap = CFI_HOST_ENDIAN;
> }
Boolean endianness properties are the standard elsewhere -- why should CFI be
different?
See Documentation/devicetree/bindings/common-properties.txt
-Scott
next prev parent reply other threads:[~2017-05-15 17:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-04 7:20 [PATCH] driver: mtd: update struct map_info's swap as per map requirement Prabhakar Kushwaha
2017-05-15 8:48 ` Boris Brezillon
2017-05-15 17:28 ` Scott Wood [this message]
2017-05-15 19:01 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494869313.29095.5.camel@buserror.net \
--to=oss@buserror.net \
--cc=boris.brezillon@free-electrons.com \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=prabhakar.kushwaha@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.