From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
paulus@samba.org, mpe@ellerman.id.au,
Frederic Barrat <fbarrat@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/3] powerpc: Add __hard_irqs_disabled()
Date: Tue, 16 May 2017 21:22:02 +1000 [thread overview]
Message-ID: <1494933722.21847.47.camel@kernel.crashing.org> (raw)
In-Reply-To: <1494926782-25700-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
On Tue, 2017-05-16 at 14:56 +0530, Aneesh Kumar K.V wrote:
>
> +static inline bool __hard_irqs_disabled(void)
> +{
> + unsigned long flags = mfmsr();
> + return (flags & MSR_EE) == 0;
> +}
> +
Reading the MSR has a cost. Can't we rely on paca->irq_happened being
non-0 ?
(If you are paranoid, add a test of msr as well and warn if there's
a mismatch ...)
Cheers,
Ben.
next prev parent reply other threads:[~2017-05-16 11:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 9:26 [PATCH 1/3] powerpc: Add __hard_irqs_disabled() Aneesh Kumar K.V
2017-05-16 9:26 ` [PATCH 2/3] powerpc/mm: Rename find_linux_pte_or_hugepte Aneesh Kumar K.V
2017-05-16 11:22 ` Benjamin Herrenschmidt
2017-05-17 3:27 ` Aneesh Kumar K.V
2017-05-17 4:57 ` Benjamin Herrenschmidt
2017-05-17 5:30 ` Madhavan Srinivasan
2017-05-29 14:32 ` Aneesh Kumar K.V
2017-05-30 3:21 ` Benjamin Herrenschmidt
2017-05-16 9:26 ` [PATCH 3/3] powerpc/mm: Don't send IPI to all cpus on THP updates Aneesh Kumar K.V
2017-05-16 11:22 ` Benjamin Herrenschmidt [this message]
2017-05-17 11:04 ` [PATCH 1/3] powerpc: Add __hard_irqs_disabled() Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494933722.21847.47.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=fbarrat@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.