Guidelines for stats_get ierrors in a media driver

[Tom Hall <thall@Brocade.com>]

I'm trying to make sense of the stats_get ierrors value. It doesn't appear that there is any consistency between any of the net drivers for what this value truly represents. For example, the ixgbe driver calculates the value as


stats->ierrors  = hw_stats->crcerrs +
                          hw_stats->mspdc +
                          hw_stats->rlec +
                          hw_stats->ruc +
                          hw_stats->roc +
                          hw_stats->illerrc +
                          hw_stats->errbc +
                          hw_stats->rfc +
                          hw_stats->fccrc +
                          hw_stats->fclast;

While the vmxnet3 driver does the following

RTE_BUILD_BUG_ON(RTE_ETHDEV_QUEUE_STAT_CNTRS < VMXNET3_MAX_RX_QUEUES); for (i = 0; i < hw->num_rx_queues; i++) { struct UPT1_RxStats *rxStats = &hw->rqd_start[i].stats; stats->q_ipackets[i] = rxStats->ucastPktsRxOK + rxStats->mcastPktsRxOK + rxStats->bcastPktsRxOK; stats->q_ibytes[i] = rxStats->ucastBytesRxOK + rxStats->mcastBytesRxOK + rxStats->bcastBytesRxOK; stats->ipackets += stats->q_ipackets[i]; stats->ibytes += stats->q_ibytes[i]; stats->q_errors[i] = rxStats->pktsRxError; stats->ierrors += rxStats->pktsRxError; stats->rx_nombuf += rxStats->pktsRxOutOfBuf; }

The bnx2x driver sets the value in this way

stats->ierrors =
                HILO_U64(sc->eth_stats.error_bytes_received_hi,
                                sc->eth_stats.error_bytes_received_lo);

Can someone address this inconsistancY? What should stats->ierrors represent?

Tom Hall

Brocade Communications