From mboxrd@z Thu Jan 1 00:00:00 1970 From: jbrunet@baylibre.com (Jerome Brunet) Date: Wed, 17 May 2017 01:28:59 +0200 Subject: [PATCH v2 2/6] pintrl: meson: document GPIO IRQ DT binding In-Reply-To: References: <36164ed8-aa59-2a77-b7fc-9adce03a2fc1@gmail.com> Message-ID: <1494977339.2728.8.camel@baylibre.com> To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org On Fri, 2017-05-12 at 21:13 +0200, Heiner Kallweit wrote: > Document the DT binding for GPIO IRQ support on Amlogic Meson SoC's. > > This documentation is intentionally not placed under > interrupt-controllers as GPIO IRQ support on these SoC's acts more > like an interrupt multiplexer. > > Signed-off-by: Heiner Kallweit > --- > v2: > - remove syscon > --- > ?arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 13 +++++++++++++ > ?1 file changed, 13 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi > b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi > index 436b8750..44422b85 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi > @@ -312,6 +312,19 @@ > ? status = "disabled"; > ? }; > ? > + gpio_irq at 9880 { > + compatible = "amlogic,meson-gpio-interrupt"; > + reg = <0x0 0x09880 0x0 0x10>; > + interrupts = , > + ?????, > + ?????, > + ?????, > + ?????, > + ?????, > + ?????, > + ?????; > + }; > + Already tried the same thing: https://marc.info/?l=devicetree&m=147758174404359&w=2 Irq maintainers reminded me that this is not correct as the device is not able to generate these particular irqs (it is merely routing the signal) and the flags are meaning less here > ? watchdog at 98d0 { > ? compatible = "amlogic,meson-gx-wdt", > "amlogic,meson-gxbb-wdt"; > ? reg = <0x0 0x098d0 0x0 0x10>; From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerome Brunet Subject: Re: [PATCH v2 2/6] pintrl: meson: document GPIO IRQ DT binding Date: Wed, 17 May 2017 01:28:59 +0200 Message-ID: <1494977339.2728.8.camel@baylibre.com> References: <36164ed8-aa59-2a77-b7fc-9adce03a2fc1@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: Received: from mail-wm0-f51.google.com ([74.125.82.51]:37537 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752764AbdEPX3C (ORCPT ); Tue, 16 May 2017 19:29:02 -0400 Received: by mail-wm0-f51.google.com with SMTP id d127so134694312wmf.0 for ; Tue, 16 May 2017 16:29:01 -0700 (PDT) In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Heiner Kallweit , Mark Rutland , Marc Zyngier , Linus Walleij , Kevin Hilman , Thomas Gleixner Cc: devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-gpio@vger.kernel.org, "thierry.reding@gmail.com" , Thierry Reding On Fri, 2017-05-12 at 21:13 +0200, Heiner Kallweit wrote: > Document the DT binding for GPIO IRQ support on Amlogic Meson SoC's. > > This documentation is intentionally not placed under > interrupt-controllers as GPIO IRQ support on these SoC's acts more > like an interrupt multiplexer. > > Signed-off-by: Heiner Kallweit > --- > v2: > - remove syscon > --- >  arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 13 +++++++++++++ >  1 file changed, 13 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi > b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi > index 436b8750..44422b85 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi > @@ -312,6 +312,19 @@ >   status = "disabled"; >   }; >   > + gpio_irq@9880 { > + compatible = "amlogic,meson-gpio-interrupt"; > + reg = <0x0 0x09880 0x0 0x10>; > + interrupts = , > +      , > +      , > +      , > +      , > +      , > +      , > +      ; > + }; > + Already tried the same thing: https://marc.info/?l=devicetree&m=147758174404359&w=2 Irq maintainers reminded me that this is not correct as the device is not able to generate these particular irqs (it is merely routing the signal) and the flags are meaning less here >   watchdog@98d0 { >   compatible = "amlogic,meson-gx-wdt", > "amlogic,meson-gxbb-wdt"; >   reg = <0x0 0x098d0 0x0 0x10>;