From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754136AbdEQHp4 (ORCPT ); Wed, 17 May 2017 03:45:56 -0400 Received: from mx2.suse.de ([195.135.220.15]:41090 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752834AbdEQHpw (ORCPT ); Wed, 17 May 2017 03:45:52 -0400 Message-ID: <1495007060.30577.8.camel@suse.com> Subject: Re: [RFC V1 1/1] net: cdc_ncm: Reduce memory use when kernel memory low From: Oliver Neukum To: =?ISO-8859-1?Q?Bj=F8rn?= Mork , Jim Baxter Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org Date: Wed, 17 May 2017 09:44:20 +0200 In-Reply-To: <87shk4fynp.fsf@miraculix.mork.no> References: <1494956480-6127-1-git-send-email-jim_baxter@mentor.com> <1494956480-6127-2-git-send-email-jim_baxter@mentor.com> <87shk4fynp.fsf@miraculix.mork.no> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, den 16.05.2017, 20:24 +0200 schrieb Bjørn Mork: > > I must say that I don't like the additional complexity added here. If > there are memory issues and you can reduce the buffer size to > USB_CDC_NCM_NTB_MIN_OUT_SIZE, then why don't you just set a lower tx_max > buffer size in the first place? > > echo 2048 > /sys/class/net/wwan0/cdc_ncm/tx_max > Hi, that would hurt performance across the board though. Can we trigger memory compactation earlier? Regards Oliver From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oliver Neukum Subject: Re: [RFC V1 1/1] net: cdc_ncm: Reduce memory use when kernel memory low Date: Wed, 17 May 2017 09:44:20 +0200 Message-ID: <1495007060.30577.8.camel@suse.com> References: <1494956480-6127-1-git-send-email-jim_baxter@mentor.com> <1494956480-6127-2-git-send-email-jim_baxter@mentor.com> <87shk4fynp.fsf@miraculix.mork.no> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: =?ISO-8859-1?Q?Bj=F8rn?= Mork , Jim Baxter Return-path: In-Reply-To: <87shk4fynp.fsf-3F4PFWf5pNjpjLOzFPqGjWGXanvQGlWp@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org Am Dienstag, den 16.05.2017, 20:24 +0200 schrieb Bjørn Mork: > > I must say that I don't like the additional complexity added here. If > there are memory issues and you can reduce the buffer size to > USB_CDC_NCM_NTB_MIN_OUT_SIZE, then why don't you just set a lower tx_max > buffer size in the first place? > > echo 2048 > /sys/class/net/wwan0/cdc_ncm/tx_max > Hi, that would hurt performance across the board though. Can we trigger memory compactation earlier? Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html