From: Patrick Ohly <patrick.ohly@intel.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v2 1/1] image-mode.bbclass: common infrastructure for choosing image defaults
Date: Wed, 17 May 2017 10:38:06 +0200 [thread overview]
Message-ID: <1495010286.28624.30.camel@intel.com> (raw)
In-Reply-To: <8810a4bbb1c67b438a7320df810db02099fcb5a0.1495007905.git-series.patrick.ohly@intel.com>
On Wed, 2017-05-17 at 09:58 +0200, Patrick Ohly wrote:
[...]
> + valid = d.getVar('IMAGE_MODE_VALID') or ''
> + if mode not in valid.split():
> + bb.fatal('Invalid image mode: IMAGE_MODE=%s (not in %s)' % (image_mode, valid))
> +}
A dedicated error message for the "IMAGE_MODE_VALID is empty" case is
needed. But let me wait for reactions before posting a v3.
--
Best Regards, Patrick Ohly
The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.
next prev parent reply other threads:[~2017-05-17 8:38 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 13:26 [RFC][PATCH 0/6] development vs. production builds Patrick Ohly
2017-05-15 13:26 ` [RFC][PATCH 1/6] build-mode.bbclass: distro-wide debug-build mode Patrick Ohly
2017-05-15 13:26 ` [RFC][PATCH 2/6] basefiles: warn about non-production DISTRO_FEATURES in motd Patrick Ohly
2017-05-15 13:27 ` [RFC][PATCH 3/6] defaultsetup.conf: enable special "debug-build" DISTRO_FEATURES support Patrick Ohly
2017-05-15 13:27 ` [RFC][PATCH 4/6] image-mode.bbclass: per-image production/development/debug mode Patrick Ohly
2017-05-15 13:27 ` [RFC][PATCH 5/6] image.bbclass: include IMAGE_MODE support Patrick Ohly
2017-05-15 13:27 ` [RFC][PATCH 6/6] local.conf.sample: make debug-tweaks depend on IMAGE_MODE Patrick Ohly
2017-05-15 15:50 ` Khem Raj
2017-05-15 19:18 ` Patrick Ohly
2017-05-15 19:34 ` Khem Raj
2017-05-15 19:47 ` Patrick Ohly
2017-05-15 20:25 ` Khem Raj
2017-05-16 6:26 ` Patrick Ohly
2017-05-16 7:12 ` Patrick Ohly
2017-05-16 7:29 ` [RFC][PATCH 0/6] development vs. production builds Richard Purdie
2017-05-16 8:17 ` Patrick Ohly
2017-05-17 7:58 ` [PATCH v2 0/1] " Patrick Ohly
2017-05-17 7:58 ` [PATCH v2 1/1] image-mode.bbclass: common infrastructure for choosing image defaults Patrick Ohly
2017-05-17 8:38 ` Patrick Ohly [this message]
2017-05-17 9:49 ` Alexander Kanavin
2017-05-17 10:47 ` Patrick Ohly
2017-05-17 12:56 ` Alexander Kanavin
2017-05-17 13:39 ` Patrick Ohly
2017-05-17 14:17 ` Alexander Kanavin
2017-05-16 7:35 ` [RFC][PATCH 0/6] development vs. production builds Mike Looijmans
2017-05-16 8:21 ` Patrick Ohly
2017-05-16 11:49 ` Alexander Kanavin
2017-05-16 13:47 ` Patrick Ohly
2017-05-16 14:02 ` Alexander Kanavin
2017-05-16 14:25 ` Patrick Ohly
2017-05-16 16:27 ` Alexander Kanavin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495010286.28624.30.camel@intel.com \
--to=patrick.ohly@intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.