From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Abeni Date: Wed, 17 May 2017 09:19:33 +0000 Subject: Re: [PATCH] udp: make function udp_skb_dtor_locked static Message-Id: <1495012773.2644.7.camel@redhat.com> List-Id: References: <20170517085036.15261-1-colin.king@canonical.com> In-Reply-To: <20170517085036.15261-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King , "David S . Miller" , Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , Patrick McHardy , netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On Wed, 2017-05-17 at 09:50 +0100, Colin King wrote: > From: Colin Ian King > > Function udp_skb_dtor_locked does not need to be in global scope > so make it static to fix sparse warning: > > net/ipv4/udp.c: warning: symbol 'udp_skb_dtor_locked' was not > declared. Should it be static? > > Fixes: 6dfb4367cd911d ("udp: keep the sk_receive_queue held when splicing") > Signed-off-by: Colin Ian King > --- > net/ipv4/udp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c > index 7bd56c9889b3..922a62d45714 100644 > --- a/net/ipv4/udp.c > +++ b/net/ipv4/udp.c > @@ -1218,7 +1218,7 @@ void udp_skb_destructor(struct sock *sk, struct sk_buff *skb) > EXPORT_SYMBOL(udp_skb_destructor); > > /* as above, but the caller held the rx queue lock, too */ > -void udp_skb_dtor_locked(struct sock *sk, struct sk_buff *skb) > +static void udp_skb_dtor_locked(struct sock *sk, struct sk_buff *skb) > { > udp_rmem_release(sk, skb->dev_scratch, 1, true); > } Acked-by: Paolo Abeni From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753837AbdEQJTm (ORCPT ); Wed, 17 May 2017 05:19:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58124 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751566AbdEQJTi (ORCPT ); Wed, 17 May 2017 05:19:38 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7B19280C0D Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=pabeni@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 7B19280C0D Message-ID: <1495012773.2644.7.camel@redhat.com> Subject: Re: [PATCH] udp: make function udp_skb_dtor_locked static From: Paolo Abeni To: Colin King , "David S . Miller" , Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , Patrick McHardy , netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 17 May 2017 11:19:33 +0200 In-Reply-To: <20170517085036.15261-1-colin.king@canonical.com> References: <20170517085036.15261-1-colin.king@canonical.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 17 May 2017 09:19:38 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-05-17 at 09:50 +0100, Colin King wrote: > From: Colin Ian King > > Function udp_skb_dtor_locked does not need to be in global scope > so make it static to fix sparse warning: > > net/ipv4/udp.c: warning: symbol 'udp_skb_dtor_locked' was not > declared. Should it be static? > > Fixes: 6dfb4367cd911d ("udp: keep the sk_receive_queue held when splicing") > Signed-off-by: Colin Ian King > --- > net/ipv4/udp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c > index 7bd56c9889b3..922a62d45714 100644 > --- a/net/ipv4/udp.c > +++ b/net/ipv4/udp.c > @@ -1218,7 +1218,7 @@ void udp_skb_destructor(struct sock *sk, struct sk_buff *skb) > EXPORT_SYMBOL(udp_skb_destructor); > > /* as above, but the caller held the rx queue lock, too */ > -void udp_skb_dtor_locked(struct sock *sk, struct sk_buff *skb) > +static void udp_skb_dtor_locked(struct sock *sk, struct sk_buff *skb) > { > udp_rmem_release(sk, skb->dev_scratch, 1, true); > } Acked-by: Paolo Abeni