From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Kirsher Date: Wed, 17 May 2017 22:49:11 -0700 Subject: [Intel-wired-lan] [net-intel-i40e] question about assignment overwrite In-Reply-To: <20170517154858.Horde.xMvsIEhHNSGu52mfyp7HA3R@gator4166.hostgator.com> References: <20170517154858.Horde.xMvsIEhHNSGu52mfyp7HA3R@gator4166.hostgator.com> Message-ID: <1495086551.46489.1.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On Wed, 2017-05-17 at 15:48 -0500, Gustavo A. R. Silva wrote: > While looking into Coverity ID 1408956 I ran into the following > piece?? > of code at drivers/net/ethernet/intel/i40e/i40e_main.c:8807: > > 8807??????? if (pf->hw.mac.type == I40E_MAC_X722) { > 8808??????????????? pf->flags |= I40E_FLAG_RSS_AQ_CAPABLE > 8809???????????????????????????? | I40E_FLAG_128_QP_RSS_CAPABLE > 8810???????????????????????????? | I40E_FLAG_HW_ATR_EVICT_CAPABLE > 8811???????????????????????????? | I40E_FLAG_OUTER_UDP_CSUM_CAPABLE > 8812???????????????????????????? | I40E_FLAG_WB_ON_ITR_CAPABLE > 8813???????????????????????????? | > I40E_FLAG_MULTIPLE_TCP_UDP_RSS_PCTYPE > 8814???????????????????????????? | I40E_FLAG_NO_PCI_LINK_CHECK > 8815???????????????????????????? | I40E_FLAG_USE_SET_LLDP_MIB > 8816???????????????????????????? | I40E_FLAG_GENEVE_OFFLOAD_CAPABLE > 8817???????????????????????????? | I40E_FLAG_PTP_L4_CAPABLE > 8818???????????????????????????? | I40E_FLAG_WOL_MC_MAGIC_PKT_WAKE; > 8819??????? } else if ((pf->hw.aq.api_maj_ver > 1) || > 8820?????????????????? ((pf->hw.aq.api_maj_ver == 1) && > 8821??????????????????? (pf->hw.aq.api_min_ver > 4))) { > 8822??????????????? /* Supported in FW API version higher than 1.4 */ > 8823??????????????? pf->flags |= I40E_FLAG_GENEVE_OFFLOAD_CAPABLE; > 8824??????????????? pf->flags = I40E_FLAG_HW_ATR_EVICT_CAPABLE; > 8825??????? } else { > 8826??????????????? pf->flags = I40E_FLAG_HW_ATR_EVICT_CAPABLE; > 8827??????? } > > The issue here is that the assignment at line 8823 is overwritten > by?? > the code at line 8824. > > I'm suspicious that line 8824 should be remove and a patch like the?? > following can be applied: > > index d5c9c9e..48ffa73 100644 > --- a/drivers/net/ethernet/intel/i40e/i40e_main.c > +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c > @@ -8821,7 +8821,6 @@ static int i40e_sw_init(struct i40e_pf *pf) > ???????????????????? (pf->hw.aq.api_min_ver > 4))) { > ???????????????? /* Supported in FW API version higher than 1.4 */ > ???????????????? pf->flags |= I40E_FLAG_GENEVE_OFFLOAD_CAPABLE; > -?????????????? pf->flags = I40E_FLAG_HW_ATR_EVICT_CAPABLE; > ???????? } else { > ???????????????? pf->flags = I40E_FLAG_HW_ATR_EVICT_CAPABLE; > ???????? } > > What do you think? This issue is already fixed in my dev-queue branch on my next-queue tree. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: This is a digitally signed message part URL: From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754677AbdERFtP (ORCPT ); Thu, 18 May 2017 01:49:15 -0400 Received: from mga14.intel.com ([192.55.52.115]:38001 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752572AbdERFtO (ORCPT ); Thu, 18 May 2017 01:49:14 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,357,1491289200"; d="asc'?scan'208";a="969931192" Message-ID: <1495086551.46489.1.camel@intel.com> Subject: Re: [net-intel-i40e] question about assignment overwrite From: Jeff Kirsher To: "Gustavo A. R. Silva" Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 17 May 2017 22:49:11 -0700 In-Reply-To: <20170517154858.Horde.xMvsIEhHNSGu52mfyp7HA3R@gator4166.hostgator.com> References: <20170517154858.Horde.xMvsIEhHNSGu52mfyp7HA3R@gator4166.hostgator.com> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-Oc3/+GCnskuEQvLKrbxz" X-Mailer: Evolution 3.24.1 Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-Oc3/+GCnskuEQvLKrbxz Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 T24gV2VkLCAyMDE3LTA1LTE3IGF0IDE1OjQ4IC0wNTAwLCBHdXN0YXZvIEEuIFIuIFNpbHZhIHdy b3RlOgo+IFdoaWxlIGxvb2tpbmcgaW50byBDb3Zlcml0eSBJRCAxNDA4OTU2IEkgcmFuIGludG8g dGhlIGZvbGxvd2luZwo+IHBpZWNlwqDCoAo+IG9mIGNvZGUgYXQgZHJpdmVycy9uZXQvZXRoZXJu ZXQvaW50ZWwvaTQwZS9pNDBlX21haW4uYzo4ODA3Ogo+IAo+IDg4MDfCoMKgwqDCoMKgwqDCoCBp ZiAocGYtPmh3Lm1hYy50eXBlID09IEk0MEVfTUFDX1g3MjIpIHsKPiA4ODA4wqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgIHBmLT5mbGFncyB8PSBJNDBFX0ZMQUdfUlNTX0FRX0NBUEFCTEUK PiA4ODA5wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqAgfCBJNDBFX0ZMQUdfMTI4X1FQX1JTU19DQVBBQkxFCj4gODgxMMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHwgSTQwRV9GTEFHX0hX X0FUUl9FVklDVF9DQVBBQkxFCj4gODgxMcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHwgSTQwRV9GTEFHX09VVEVSX1VEUF9DU1VNX0NBUEFC TEUKPiA4ODEywqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqAgfCBJNDBFX0ZMQUdfV0JfT05fSVRSX0NBUEFCTEUKPiA4ODEzwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfAo+IEk0MEVfRkxB R19NVUxUSVBMRV9UQ1BfVURQX1JTU19QQ1RZUEUKPiA4ODE0wqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfCBJNDBFX0ZMQUdfTk9fUENJX0xJ TktfQ0hFQ0sKPiA4ODE1wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqAgfCBJNDBFX0ZMQUdfVVNFX1NFVF9MTERQX01JQgo+IDg4MTbCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8IEk0MEVf RkxBR19HRU5FVkVfT0ZGTE9BRF9DQVBBQkxFCj4gODgxN8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHwgSTQwRV9GTEFHX1BUUF9MNF9DQVBB QkxFCj4gODgxOMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgIHwgSTQwRV9GTEFHX1dPTF9NQ19NQUdJQ19QS1RfV0FLRTsKPiA4ODE5wqDCoMKg wqDCoMKgwqAgfSBlbHNlIGlmICgocGYtPmh3LmFxLmFwaV9tYWpfdmVyID4gMSkgfHwKPiA4ODIw wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICgocGYtPmh3LmFxLmFwaV9tYWpf dmVyID09IDEpICYmCj4gODgyMcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg IChwZi0+aHcuYXEuYXBpX21pbl92ZXIgPiA0KSkpIHsKPiA4ODIywqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgIC8qIFN1cHBvcnRlZCBpbiBGVyBBUEkgdmVyc2lvbiBoaWdoZXIgdGhhbiAx LjQgKi8KPiA4ODIzwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHBmLT5mbGFncyB8PSBJ NDBFX0ZMQUdfR0VORVZFX09GRkxPQURfQ0FQQUJMRTsKPiA4ODI0wqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgIHBmLT5mbGFncyA9IEk0MEVfRkxBR19IV19BVFJfRVZJQ1RfQ0FQQUJMRTsK PiA4ODI1wqDCoMKgwqDCoMKgwqAgfSBlbHNlIHsKPiA4ODI2wqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgIHBmLT5mbGFncyA9IEk0MEVfRkxBR19IV19BVFJfRVZJQ1RfQ0FQQUJMRTsKPiA4 ODI3wqDCoMKgwqDCoMKgwqAgfQo+IAo+IFRoZSBpc3N1ZSBoZXJlIGlzIHRoYXQgdGhlIGFzc2ln bm1lbnQgYXQgbGluZSA4ODIzIGlzIG92ZXJ3cml0dGVuCj4gYnnCoMKgCj4gdGhlIGNvZGUgYXQg bGluZSA4ODI0Lgo+IAo+IEknbSBzdXNwaWNpb3VzIHRoYXQgbGluZSA4ODI0IHNob3VsZCBiZSBy ZW1vdmUgYW5kIGEgcGF0Y2ggbGlrZSB0aGXCoMKgCj4gZm9sbG93aW5nIGNhbiBiZSBhcHBsaWVk Ogo+IAo+IGluZGV4IGQ1YzljOWUuLjQ4ZmZhNzMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9uZXQv ZXRoZXJuZXQvaW50ZWwvaTQwZS9pNDBlX21haW4uYwo+ICsrKyBiL2RyaXZlcnMvbmV0L2V0aGVy bmV0L2ludGVsL2k0MGUvaTQwZV9tYWluLmMKPiBAQCAtODgyMSw3ICs4ODIxLDYgQEAgc3RhdGlj IGludCBpNDBlX3N3X2luaXQoc3RydWN0IGk0MGVfcGYgKnBmKQo+IMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKHBmLT5ody5hcS5hcGlfbWluX3ZlciA+IDQpKSkgewo+ IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIC8qIFN1cHBvcnRlZCBpbiBGVyBBUEkg dmVyc2lvbiBoaWdoZXIgdGhhbiAxLjQgKi8KPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoCBwZi0+ZmxhZ3MgfD0gSTQwRV9GTEFHX0dFTkVWRV9PRkZMT0FEX0NBUEFCTEU7Cj4gLcKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcGYtPmZsYWdzID0gSTQwRV9GTEFHX0hXX0FUUl9F VklDVF9DQVBBQkxFOwo+IMKgwqDCoMKgwqDCoMKgwqAgfSBlbHNlIHsKPiDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCBwZi0+ZmxhZ3MgPSBJNDBFX0ZMQUdfSFdfQVRSX0VWSUNUX0NB UEFCTEU7Cj4gwqDCoMKgwqDCoMKgwqDCoCB9Cj4gCj4gV2hhdCBkbyB5b3UgdGhpbms/CgpUaGlz IGlzc3VlIGlzIGFscmVhZHkgZml4ZWQgaW4gbXkgZGV2LXF1ZXVlIGJyYW5jaCBvbiBteSBuZXh0 LXF1ZXVlCnRyZWUu --=-Oc3/+GCnskuEQvLKrbxz Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiTyZWz+nnTrOJ1LZ5W/vlVpL7c4FAlkdNdcACgkQ5W/vlVpL 7c4tmg//fxyJW3LMS3JUVt/JllIyOR3O/gjF4CDGRTEpguLKQTJV9IQnuI0Rxhzz b7r6DwRbsWXpXITfQehhUMoliKVvGon+19Kpp0Ku3JLkt8/YSFJc3IMONR3bZUXH uZEin/BxXOhxcFUg17LyRabkbEbf2tJ8LmdBeoCUWflYHV5aLu0lSAT0EhfIih5N aHZb2XH3otbHJ5NjKng1/T/E6RjJG5Z0sD3DZL2xvYx54GXJ4gcsDxUa4ID+Ja/e 7DtIqZAo9wj87n/yk//TwoxTo8VBpPx5zUcTnDSqwp9o+hf4bfuJCfoRoVX9pI3C 4VR1RsNtZnCiajUtdvtKP+ZttsdRCTeNTtOZ+mFDbOHkpEyAyN9ROrdJFOctdkbl zHylrKZjnkdYLmcpr9w8mD4S3cL/3SGa3gDO0dGgIjYXPXQDXR+j5YjU9mVE7pA5 EbNoLG1uhyfm4EKvcIb54koS+AuBomUPN2CYWxGcYbwRqSPAd8UXf646XoeA3ANR w/A/vOljIR6BnNBq5iOZvX8tXiTqwj96gcOzVMr79rbUVjLeuSAqmlxzkfe9ZEuO 5x25bHVAiu/WkGuPjo76Py9/qv1OSXWR6Q94ZuCnfbZPwqXwAEu6uLQRGuGOUqgO zomdwSOEDE4nQIR2RrB6CI0KWeDd6xzZxNpeOGkd1flVeg+yaiI= =r/f+ -----END PGP SIGNATURE----- --=-Oc3/+GCnskuEQvLKrbxz--