From: Leonard Crestez <leonard.crestez@nxp.com>
To: Jiada Wang <jiada_wang@mentor.com>
Cc: <linux-spi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@kernel.org>,
Octavian Purdila <octavian.purdila@nxp.com>,
"Fabio Estevam" <fabio.estevam@nxp.com>,
Robin Gong <yibin.gong@nxp.com>
Subject: Re: [PATCH linux-next v2 1/1] spi: imx: dynamic burst length adjust for PIO mode
Date: Thu, 18 May 2017 12:29:54 +0300 [thread overview]
Message-ID: <1495099794.26925.18.camel@nxp.com> (raw)
In-Reply-To: <591CFDEA.1080204@mentor.com>
On Wed, 2017-05-17 at 18:50 -0700, Jiada Wang wrote:
> Hello Leonard
>
> Thanks for the report, can you help to check if the following change
> address the issue?
>
> diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
> index 782045f..19b30cf 100644
> --- a/drivers/spi/spi-imx.c
> +++ b/drivers/spi/spi-imx.c
> @@ -288,6 +288,9 @@ static void spi_imx_u32_swap_u8(struct spi_transfer
> *transfer, u32 *buf)
> {
> int i;
>
> + if (!buf)
> + return;
> +
> for (i = 0; i < transfer->len / 4; i++)
> *(buf + i) = cpu_to_be32(*(buf + i));
> }
> @@ -296,6 +299,9 @@ static void spi_imx_u32_swap_u16(struct spi_transfer
> *transfer, u32 *buf)
> {
> int i;
>
> + if (!buf)
> + return;
> +
> for (i = 0; i < transfer->len / 4; i++) {
> u16 *temp = (u16 *)buf;
>
Yes, this does seem to fix it.
next prev parent reply other threads:[~2017-05-18 9:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-01 10:31 [PATCH linux-next v2 0/1] improve imx spi performance jiada_wang-nmGgyN9QBj3QT0dZR+AlfA
2017-05-01 10:31 ` jiada_wang
[not found] ` <1493634704-3545-1-git-send-email-jiada_wang-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
2017-05-01 10:31 ` [PATCH linux-next v2 1/1] spi: imx: dynamic burst length adjust for PIO mode jiada_wang-nmGgyN9QBj3QT0dZR+AlfA
2017-05-01 10:31 ` jiada_wang
2017-05-15 8:04 ` Applied "spi: imx: dynamic burst length adjust for PIO mode" to the spi tree Mark Brown
2017-05-17 17:32 ` [PATCH linux-next v2 1/1] spi: imx: dynamic burst length adjust for PIO mode Leonard Crestez
[not found] ` <1495042325.26925.15.camel-3arQi8VN3Tc@public.gmane.org>
2017-05-18 1:50 ` Jiada Wang
2017-05-18 1:50 ` Jiada Wang
2017-05-18 9:29 ` Leonard Crestez [this message]
2017-05-14 10:06 ` [PATCH linux-next v2 0/1] improve imx spi performance Mark Brown
2017-05-14 10:06 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495099794.26925.18.camel@nxp.com \
--to=leonard.crestez@nxp.com \
--cc=broonie@kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=jiada_wang@mentor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=octavian.purdila@nxp.com \
--cc=yibin.gong@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.