From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH v2 4/5] drm/i915/gvt: Dmabuf support for GVT-g
Date: Fri, 19 May 2017 13:28:55 +0200
Message-ID: <1495193335.627.66.camel@redhat.com>
References: <1495101005-16045-1-git-send-email-xiaoguang.chen@intel.com>
         <1495101005-16045-5-git-send-email-xiaoguang.chen@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1495101005-16045-5-git-send-email-xiaoguang.chen@intel.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Xiaoguang Chen <xiaoguang.chen@intel.com>
Cc: alex.williamson@redhat.com, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, zhenyuw@linux.intel.com, zhiyuan.lv@intel.com, intel-gvt-dev@lists.freedesktop.org, zhi.a.wang@intel.com, kevin.tian@intel.com
List-Id: intel-gfx@lists.freedesktop.org

> +/**
> + * Ioctl to query plane info or create dma-buf
> + */
> +#define INTEL_VGPU_QUERY_DMABUF		0
> +#define INTEL_VGPU_GENERATE_DMABUF	1

This should use _IO* #defines.

> +struct intel_vgpu_dmabuf {
> +	__u32 plane_id;
> +	/* out */
> +	__u32 fd;
> +	__u32 drm_format;
> +	__u32 width;
> +	__u32 height;
> +	__u32 stride;
> +	__u32 start;
> +	__u32 x_pos;
> +	__u32 y_pos;
> +	__u32 size;
> +	__u32 tiled;

I'd suggest to drop tiled, and add drm_format_mod (for
fourcc_mod_code()) instead.

You can also move intel_vgpu_plane_info to this place and just use it as
sub-struct for intel_vgpu_dmabuf.

cheers,
  Gerd