From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
To: "Erik Botö" <erik.boto@pelagicore.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/4] masterimage.py: fix issue with calling reboot on masterimage/DUT
Date: Fri, 19 May 2017 09:59:43 -0500 [thread overview]
Message-ID: <1495205983.1761.105.camel@linux.intel.com> (raw)
In-Reply-To: <20170519142004.32682-1-erik.boto@pelagicore.com>
On Fri, 2017-05-19 at 16:20 +0200, Erik Botö wrote:
> On systemd systems calling reboot over an ssh connection doesn't
> return as expected causing an exception, therefore wrap the call
> to reboot in order to avoid this issue.
>
> Signed-off-by: Erik Botö <erik.boto@pelagicore.com>
> ---
> meta/lib/oeqa/controllers/masterimage.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/lib/oeqa/controllers/masterimage.py b/meta/lib/oeqa/controllers/masterimage.py
> index 07418fcda1..6cdcfa3068 100644
> --- a/meta/lib/oeqa/controllers/masterimage.py
> +++ b/meta/lib/oeqa/controllers/masterimage.py
> @@ -108,7 +108,7 @@ class MasterImageHardwareTarget(oeqa.targetcontrol.BaseTarget, metaclass=ABCMeta
> time.sleep(10)
> self.power_ctl("cycle")
> else:
> - status, output = conn.run("reboot")
> + status, output = conn.run("{ sleep 1; reboot; } > /dev/null &")
what would make the difference having the sleep before reboot?
> if status != 0:
> bb.error("Failed rebooting target and no power control command defined. You need to manually reset the device.\n%s" % output)
>
> --
> 2.11.0
>
next prev parent reply other threads:[~2017-05-19 15:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 14:20 [PATCH 1/4] masterimage.py: fix issue with calling reboot on masterimage/DUT Erik Botö
2017-05-19 14:20 ` [PATCH 2/4] masterimage.py: rename parameter "params" in start() to "extra_bootparams" Erik Botö
2017-05-19 14:20 ` [PATCH 3/4] masterimage.py: fix stop() Erik Botö
2017-05-19 14:20 ` [PATCH 4/4] sshcontrol.py: in copy_to() always use scp Erik Botö
2017-05-19 14:59 ` Leonardo Sandoval [this message]
2017-05-19 18:24 ` [PATCH 1/4] masterimage.py: fix issue with calling reboot on masterimage/DUT Erik Botö
2017-05-26 9:01 ` Erik Botö
2017-05-26 13:57 ` Leonardo Sandoval
-- strict thread matches above, loose matches on Subject: below --
2017-11-06 18:13 [PATCH 0/4] fix runtime tests with systemd-boot Stephano Cetola
2017-11-06 18:13 ` [PATCH 1/4] masterimage.py: fix issue with calling reboot on masterimage/DUT Stephano Cetola
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495205983.1761.105.camel@linux.intel.com \
--to=leonardo.sandoval.gonzalez@linux.intel.com \
--cc=erik.boto@pelagicore.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.