From: Joe Perches <joe@perches.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: James Smart <james.smart@broadcom.com>,
Dick Kennedy <dick.kennedy@broadcom.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Hannes Reinecke <hare@suse.com>,
Johannes Thumshirn <jthumshirn@suse.de>,
linux-scsi@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] lpfc: nvmet_fc: fix format string
Date: Sat, 20 May 2017 17:43:34 -0700 [thread overview]
Message-ID: <1495327414.2093.8.camel@perches.com> (raw)
In-Reply-To: <CAK8P3a37qj9szwsmksxFr_pWXK8LLzTG+4_mJ7t9WB76pO6A2A@mail.gmail.com>
On Sat, 2017-05-20 at 21:10 +0200, Arnd Bergmann wrote:
> On Sat, May 20, 2017 at 12:28 PM, Joe Perches <joe@perches.com> wrote:
> > On Fri, 2017-05-19 at 10:04 +0200, Arnd Bergmann wrote:
> > > The lpfc_nvmeio_data() tracing helper always takes a format string and
> > > three additional arguments.
> >
> > No it doesn't. It takes a format and arguments.
> >
> > I don't disagree with the patch, just the characterization
> > of the lpfc_mvmeio_data call in the commit message.
>
> I think my description is correct, it's just not obvious from
> reading the code until you also look at the lpfc_debugfs_nvme_trc
> prototype:
OK, but more that's a mismatch between a function and its
arguments and a different called function within it.
next prev parent reply other threads:[~2017-05-21 0:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 8:04 [PATCH] lpfc: nvmet_fc: fix format string Arnd Bergmann
2017-05-20 10:28 ` Joe Perches
2017-05-20 19:10 ` Arnd Bergmann
2017-05-21 0:43 ` Joe Perches [this message]
2017-05-24 2:36 ` Martin K. Petersen
2017-05-29 23:02 ` James Smart
2017-06-01 2:44 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495327414.2093.8.camel@perches.com \
--to=joe@perches.com \
--cc=arnd@arndb.de \
--cc=dick.kennedy@broadcom.com \
--cc=hare@suse.com \
--cc=james.smart@broadcom.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.