From mboxrd@z Thu Jan 1 00:00:00 1970 From: Duyck, Alexander H Date: Mon, 22 May 2017 16:40:34 +0000 Subject: [Intel-wired-lan] [PATCH 0/4] Configuring traffic classes via new hardware offload mechanism in tc/mqprio In-Reply-To: References: <149524122523.11022.4541073724650541658.stgit@anamdev.jf.intel.com> Message-ID: <1495471231.2562.9.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On Mon, 2017-05-22 at 06:25 +0300, Or Gerlitz wrote: > On Mon, May 22, 2017 at 1:35 AM, Alexander Duyck > wrote: > > > > On Sat, May 20, 2017 at 2:15 PM, Or Gerlitz wrote: > > > > > > On Sat, May 20, 2017 at 3:58 AM, Amritha Nambiar > > > wrote: > > > > > > > > The following series introduces a new harware offload mode in tc/mqprio > > > > > > Wait, we have already a HW QoS model introduced by John F and Co > > > couple of years ago, right? > > > > I assume you are referring to the ETS portion of DCBX? If so then yes > > we have something there, but there is a fairly high level of > > complexity and dependencies in order to enable that. What we have in > > mind doesn't really fit with DCBX and the problem is the spec calls > > out that you really have to have support for DCBX in order to make use > > of ETS. What we are trying to do here is provide a lightweight way of > > doing this configuration similar to how mqprio was already providing a > > lightweight way of enabling multiple traffic classes. > > UAPI wise, we are talking on DCB, not DCBX, right? the X-portion comes > into play if some user-space entity run LLDP traffic and calls into > the kernel to configure (say) ETS. If there are some issues to use the > existing user-space tool (lldpad tool/daemon) to do DCB without X, one > can/should fix them or introduce another/simpler tool that in a > lightweight manner only configures things w.o exchanging. > > So to clarify, the essence of this series is introducing a 2nd way to > configure ETS and rate limit? Sort of. Basically the idea is we can use several different approaches to enable queue configuration and rate limits. So we are adding two pieces of functionality. The first block allows for configuring queue counts and layout. Historically DCB/DCBX hasn't allowed us to specify that. The second bit is that we added support for rate limiting. I am actually basing it on what we had for SR-IOV rate limiting as that is how this is working in i40e. However the basic attributes we are adding should work for most ETS type use cases though it might need to use the min rates instead of the max rates as we do in i40e. > > > > > > > > Please elaborate in few sentence if you are extending it/replacing it, > > > why we want to do that and what are the implications on existing > > > applications UAPI wise. > > > > > This is meant to be an extension of the existing structure. It can be > > ignored by the driver and instead only have the basic hw offload > > supported. In such a case the command will still return success but > > any rate limits and queue configuration can be ignored. In the case of > > the current implementation the queue configuration was already being > > ignored so we opted to re-purpose the "hw" flag so that if you pass a > > value greater than 1 and the driver doesn't recognize the value it has > > the option to just ignore the extra bits it doesn't recognize and > > return 1 as it did before for the hw flag in mqprio. > > So the user asked to configure something and the kernel returned > success but the config was not plugged to the hw? sounds to me like > possible (probable) source of troubles and complaints. That is possible, however the issue already existed. The queue configuration could be specified with the mqprio configuration and be totally ignored. I opted for just maintaining the existing behavior and moving forward and providing some input via the ability to report what "version" of the hardware offload we are supporting. The plan is that legacy devices can fall back into the setup where they support mode 1, however if they support hw mode 2 then we will fail to initialize if we don't support something that is being requested. > > > > > > > > Below you just say in the new mode Qos is configured with knobs XYZ -- > > > this is way not enough > > > > > Can you clarify what you are asking for here? Amritha included an > > example in patch 1 of a command line that enabled 2 traffic classes > > with rate limits. Is there something more specific you are looking for? > > you were referring to the questions I posted, so we can continue the > discussion from here. > _______________________________________________ > Intel-wired-lan mailing list > Intel-wired-lan at osuosl.org > https://lists.osuosl.org/mailman/listinfo/intel-wired-lan From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Duyck, Alexander H" Subject: Re: [Intel-wired-lan] [PATCH 0/4] Configuring traffic classes via new hardware offload mechanism in tc/mqprio Date: Mon, 22 May 2017 16:40:34 +0000 Message-ID: <1495471231.2562.9.camel@intel.com> References: <149524122523.11022.4541073724650541658.stgit@anamdev.jf.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: "netdev@vger.kernel.org" , "intel-wired-lan@lists.osuosl.org" To: "gerlitz.or@gmail.com" , "alexander.duyck@gmail.com" Return-path: Received: from mga01.intel.com ([192.55.52.88]:45562 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934724AbdEVQkl (ORCPT ); Mon, 22 May 2017 12:40:41 -0400 In-Reply-To: Content-Language: en-US Content-ID: <54792EAA6A13034B85E05BB80D900B81@intel.com> Sender: netdev-owner@vger.kernel.org List-ID: T24gTW9uLCAyMDE3LTA1LTIyIGF0IDA2OjI1ICswMzAwLCBPciBHZXJsaXR6IHdyb3RlOg0KPiBP biBNb24sIE1heSAyMiwgMjAxNyBhdCAxOjM1IEFNLCBBbGV4YW5kZXIgRHV5Y2sNCj4gPGFsZXhh bmRlci5kdXlja0BnbWFpbC5jb20+IHdyb3RlOg0KPiA+IA0KPiA+IE9uIFNhdCwgTWF5IDIwLCAy MDE3IGF0IDI6MTUgUE0sIE9yIEdlcmxpdHogPGdlcmxpdHoub3JAZ21haWwuY29tPiB3cm90ZToN Cj4gPiA+IA0KPiA+ID4gT24gU2F0LCBNYXkgMjAsIDIwMTcgYXQgMzo1OCBBTSwgQW1yaXRoYSBO YW1iaWFyDQo+ID4gPiA8YW1yaXRoYS5uYW1iaWFyQGludGVsLmNvbT4gd3JvdGU6DQo+ID4gPiA+ IA0KPiA+ID4gPiBUaGUgZm9sbG93aW5nIHNlcmllcyBpbnRyb2R1Y2VzIGEgbmV3IGhhcndhcmUg b2ZmbG9hZCBtb2RlIGluIHRjL21xcHJpbw0KPiA+ID4gDQo+ID4gPiBXYWl0LCB3ZSBoYXZlIGFs cmVhZHkgYSBIVyBRb1MgbW9kZWwgaW50cm9kdWNlZCBieSBKb2huIEYgYW5kIENvDQo+ID4gPiBj b3VwbGUgb2YgeWVhcnMgYWdvLCAgcmlnaHQ/DQo+ID4gDQo+ID4gSSBhc3N1bWUgeW91IGFyZSBy ZWZlcnJpbmcgdG8gdGhlIEVUUyBwb3J0aW9uIG9mIERDQlg/IElmIHNvIHRoZW4geWVzDQo+ID4g d2UgaGF2ZSBzb21ldGhpbmcgdGhlcmUsIGJ1dCB0aGVyZSBpcyBhIGZhaXJseSBoaWdoIGxldmVs IG9mDQo+ID4gY29tcGxleGl0eSBhbmQgZGVwZW5kZW5jaWVzIGluIG9yZGVyIHRvIGVuYWJsZSB0 aGF0LiBXaGF0IHdlIGhhdmUgaW4NCj4gPiBtaW5kIGRvZXNuJ3QgcmVhbGx5IGZpdCB3aXRoIERD QlggYW5kIHRoZSBwcm9ibGVtIGlzIHRoZSBzcGVjIGNhbGxzDQo+ID4gb3V0IHRoYXQgeW91IHJl YWxseSBoYXZlIHRvIGhhdmUgc3VwcG9ydCBmb3IgRENCWCBpbiBvcmRlciB0byBtYWtlIHVzZQ0K PiA+IG9mIEVUUy4gV2hhdCB3ZSBhcmUgdHJ5aW5nIHRvIGRvIGhlcmUgaXMgcHJvdmlkZSBhIGxp Z2h0d2VpZ2h0IHdheSBvZg0KPiA+IGRvaW5nIHRoaXMgY29uZmlndXJhdGlvbiBzaW1pbGFyIHRv IGhvdyBtcXByaW8gd2FzIGFscmVhZHkgcHJvdmlkaW5nIGENCj4gPiBsaWdodHdlaWdodCB3YXkg b2YgZW5hYmxpbmcgbXVsdGlwbGUgdHJhZmZpYyBjbGFzc2VzLg0KPiANCj4gVUFQSSB3aXNlLCB3 ZSBhcmUgdGFsa2luZyBvbiBEQ0IsIG5vdCBEQ0JYLCByaWdodD8gdGhlIFgtcG9ydGlvbiBjb21l cw0KPiBpbnRvIHBsYXkgaWYgc29tZSB1c2VyLXNwYWNlIGVudGl0eSBydW4gTExEUCB0cmFmZmlj IGFuZCBjYWxscyBpbnRvDQo+IHRoZSBrZXJuZWwgdG8gY29uZmlndXJlIChzYXkpIEVUUy4gSWYg dGhlcmUgYXJlIHNvbWUgaXNzdWVzIHRvIHVzZSB0aGUNCj4gZXhpc3RpbmcgdXNlci1zcGFjZSB0 b29sIChsbGRwYWQgdG9vbC9kYWVtb24pIHRvIGRvIERDQiB3aXRob3V0IFgsIG9uZQ0KPiBjYW4v c2hvdWxkIGZpeCB0aGVtIG9yIGludHJvZHVjZSBhbm90aGVyL3NpbXBsZXIgdG9vbCB0aGF0IGlu IGENCj4gbGlnaHR3ZWlnaHQgbWFubmVyIG9ubHkgY29uZmlndXJlcyB0aGluZ3Mgdy5vIGV4Y2hh bmdpbmcuDQo+IA0KPiBTbyB0byBjbGFyaWZ5LCB0aGUgZXNzZW5jZSBvZiB0aGlzIHNlcmllcyBp cyBpbnRyb2R1Y2luZyBhIDJuZCB3YXkgdG8NCj4gY29uZmlndXJlIEVUUyBhbmQgcmF0ZSBsaW1p dD8NCg0KU29ydCBvZi4gQmFzaWNhbGx5IHRoZSBpZGVhIGlzIHdlIGNhbiB1c2Ugc2V2ZXJhbCBk aWZmZXJlbnQgYXBwcm9hY2hlcw0KdG8gZW5hYmxlIHF1ZXVlIGNvbmZpZ3VyYXRpb24gYW5kIHJh dGUgbGltaXRzLiBTbyB3ZSBhcmUgYWRkaW5nIHR3bw0KcGllY2VzIG9mIGZ1bmN0aW9uYWxpdHku DQoNClRoZSBmaXJzdCBibG9jayBhbGxvd3MgZm9yIGNvbmZpZ3VyaW5nIHF1ZXVlIGNvdW50cyBh bmQgbGF5b3V0Lg0KSGlzdG9yaWNhbGx5IERDQi9EQ0JYIGhhc24ndCBhbGxvd2VkIHVzIHRvIHNw ZWNpZnkgdGhhdC4NCg0KVGhlIHNlY29uZCBiaXQgaXMgdGhhdCB3ZSBhZGRlZCBzdXBwb3J0IGZv ciByYXRlIGxpbWl0aW5nLiBJIGFtDQphY3R1YWxseSBiYXNpbmcgaXQgb24gd2hhdCB3ZSBoYWQg Zm9yIFNSLUlPViByYXRlIGxpbWl0aW5nIGFzIHRoYXQgaXMNCmhvdyB0aGlzIGlzIHdvcmtpbmcg aW4gaTQwZS4gSG93ZXZlciB0aGUgYmFzaWMgYXR0cmlidXRlcyB3ZSBhcmUgYWRkaW5nDQpzaG91 bGQgd29yayBmb3IgbW9zdCBFVFMgdHlwZSB1c2UgY2FzZXMgdGhvdWdoIGl0IG1pZ2h0IG5lZWQg dG8gdXNlIHRoZQ0KbWluIHJhdGVzIGluc3RlYWQgb2YgdGhlIG1heCByYXRlcyBhcyB3ZSBkbyBp biBpNDBlLg0KDQo+ID4gDQo+ID4gPiANCj4gPiA+IFBsZWFzZSBlbGFib3JhdGUgaW4gZmV3IHNl bnRlbmNlIGlmIHlvdSBhcmUgZXh0ZW5kaW5nIGl0L3JlcGxhY2luZyBpdCwNCj4gPiA+IHdoeSB3 ZSB3YW50IHRvIGRvIHRoYXQgYW5kIHdoYXQgYXJlIHRoZSBpbXBsaWNhdGlvbnMgb24gZXhpc3Rp bmcNCj4gPiA+IGFwcGxpY2F0aW9ucyBVQVBJIHdpc2UuDQo+IA0KPiA+IA0KPiA+IFRoaXMgaXMg bWVhbnQgdG8gYmUgYW4gZXh0ZW5zaW9uIG9mIHRoZSBleGlzdGluZyBzdHJ1Y3R1cmUuIEl0IGNh biBiZQ0KPiA+IGlnbm9yZWQgYnkgdGhlIGRyaXZlciBhbmQgaW5zdGVhZCBvbmx5IGhhdmUgdGhl IGJhc2ljIGh3IG9mZmxvYWQNCj4gPiBzdXBwb3J0ZWQuIEluIHN1Y2ggYSBjYXNlIHRoZSBjb21t YW5kIHdpbGwgc3RpbGwgcmV0dXJuIHN1Y2Nlc3MgYnV0DQo+ID4gYW55IHJhdGUgbGltaXRzIGFu ZCBxdWV1ZSBjb25maWd1cmF0aW9uIGNhbiBiZSBpZ25vcmVkLiBJbiB0aGUgY2FzZSBvZg0KPiA+ IHRoZSBjdXJyZW50IGltcGxlbWVudGF0aW9uIHRoZSBxdWV1ZSBjb25maWd1cmF0aW9uIHdhcyBh bHJlYWR5IGJlaW5nDQo+ID4gaWdub3JlZCBzbyB3ZSBvcHRlZCB0byByZS1wdXJwb3NlIHRoZSAi aHciIGZsYWcgc28gdGhhdCBpZiB5b3UgcGFzcyBhDQo+ID4gdmFsdWUgZ3JlYXRlciB0aGFuIDEg YW5kIHRoZSBkcml2ZXIgZG9lc24ndCByZWNvZ25pemUgdGhlIHZhbHVlIGl0IGhhcw0KPiA+IHRo ZSBvcHRpb24gdG8ganVzdCBpZ25vcmUgdGhlIGV4dHJhIGJpdHMgaXQgZG9lc24ndCByZWNvZ25p emUgYW5kDQo+ID4gcmV0dXJuIDEgYXMgaXQgZGlkIGJlZm9yZSBmb3IgdGhlIGh3IGZsYWcgaW4g bXFwcmlvLg0KPiANCj4gU28gdGhlIHVzZXIgYXNrZWQgdG8gY29uZmlndXJlIHNvbWV0aGluZyBh bmQgdGhlIGtlcm5lbCByZXR1cm5lZA0KPiBzdWNjZXNzIGJ1dCB0aGUgY29uZmlnIHdhcyBub3Qg cGx1Z2dlZCB0byB0aGUgaHc/IHNvdW5kcyB0byBtZSBsaWtlDQo+IHBvc3NpYmxlIChwcm9iYWJs ZSkgc291cmNlIG9mIHRyb3VibGVzIGFuZCBjb21wbGFpbnRzLg0KDQpUaGF0IGlzIHBvc3NpYmxl LCBob3dldmVyIHRoZSBpc3N1ZSBhbHJlYWR5IGV4aXN0ZWQuIFRoZSBxdWV1ZQ0KY29uZmlndXJh dGlvbiBjb3VsZCBiZSBzcGVjaWZpZWQgd2l0aCB0aGUgbXFwcmlvIGNvbmZpZ3VyYXRpb24gYW5k IGJlDQp0b3RhbGx5IGlnbm9yZWQuIEkgb3B0ZWQgZm9yIGp1c3QgbWFpbnRhaW5pbmcgdGhlIGV4 aXN0aW5nIGJlaGF2aW9yIGFuZA0KbW92aW5nIGZvcndhcmQgYW5kIHByb3ZpZGluZyBzb21lIGlu cHV0IHZpYSB0aGUgYWJpbGl0eSB0byByZXBvcnQgd2hhdA0KInZlcnNpb24iIG9mIHRoZSBoYXJk d2FyZSBvZmZsb2FkIHdlIGFyZSBzdXBwb3J0aW5nLg0KDQpUaGUgcGxhbiBpcyB0aGF0IGxlZ2Fj eSBkZXZpY2VzIGNhbiBmYWxsIGJhY2sgaW50byB0aGUgc2V0dXAgd2hlcmUgdGhleQ0Kc3VwcG9y dCBtb2RlIDEsIGhvd2V2ZXIgaWYgdGhleSBzdXBwb3J0IGh3IG1vZGUgMiB0aGVuIHdlIHdpbGwg ZmFpbCB0bw0KaW5pdGlhbGl6ZSBpZiB3ZSBkb24ndCBzdXBwb3J0IHNvbWV0aGluZyB0aGF0IGlz IGJlaW5nIHJlcXVlc3RlZC4NCg0KPiA+IA0KPiA+ID4gDQo+ID4gPiBCZWxvdyB5b3UganVzdCBz YXkgaW4gdGhlIG5ldyBtb2RlIFFvcyBpcyBjb25maWd1cmVkIHdpdGgga25vYnMgWFlaIC0tDQo+ ID4gPiB0aGlzIGlzIHdheSBub3QgZW5vdWdoDQo+IA0KPiA+IA0KPiA+IENhbiB5b3UgY2xhcmlm eSB3aGF0IHlvdSBhcmUgYXNraW5nIGZvciBoZXJlPyBBbXJpdGhhIGluY2x1ZGVkIGFuDQo+ID4g ZXhhbXBsZSBpbiBwYXRjaCAxIG9mIGEgY29tbWFuZCBsaW5lIHRoYXQgZW5hYmxlZCAyIHRyYWZm aWMgY2xhc3Nlcw0KPiA+IHdpdGggcmF0ZSBsaW1pdHMuIElzIHRoZXJlIHNvbWV0aGluZyBtb3Jl IHNwZWNpZmljIHlvdSBhcmUgbG9va2luZyBmb3I/DQo+IA0KPiB5b3Ugd2VyZSByZWZlcnJpbmcg dG8gdGhlIHF1ZXN0aW9ucyBJIHBvc3RlZCwgc28gd2UgY2FuIGNvbnRpbnVlIHRoZQ0KPiBkaXNj dXNzaW9uIGZyb20gaGVyZS4NCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18NCj4gSW50ZWwtd2lyZWQtbGFuIG1haWxpbmcgbGlzdA0KPiBJbnRlbC13aXJl ZC1sYW5Ab3N1b3NsLm9yZw0KPiBodHRwczovL2xpc3RzLm9zdW9zbC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC13aXJlZC1sYW4NCg==