diff for duplicates of <1495472831.2610.4.camel@sandisk.com> diff --git a/a/1.txt b/N1/1.txt index 3b877d2..94831bd 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -6,7 +6,7 @@ On Sun, 2017-05-21 at 08:34 +0200, Christoph Hellwig wrote: > > that initialization code has to be repeated after every > > blk_get_request() call by adding a new callback function to struct > > request_queue. -> >=20 +> > > > Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> > > Cc: Jens Axboe <axboe@fb.com> > > Cc: Christoph Hellwig <hch@lst.de> @@ -18,20 +18,19 @@ On Sun, 2017-05-21 at 08:34 +0200, Christoph Hellwig wrote: > > block/blk-mq.c | 3 +++ > > include/linux/blkdev.h | 4 ++++ > > 3 files changed, 10 insertions(+) -> >=20 +> > > > diff --git a/block/blk-core.c b/block/blk-core.c > > index a69d420b7ff0..f2540d164679 100644 > > --- a/block/blk-core.c > > +++ b/block/blk-core.c -> > @@ -126,6 +126,9 @@ void blk_rq_init(struct request_queue *q, struct re= -quest *rq) -> > rq->start_time =3D jiffies; +> > @@ -126,6 +126,9 @@ void blk_rq_init(struct request_queue *q, struct request *rq) +> > rq->start_time = jiffies; > > set_start_time_ns(rq); -> > rq->part =3D NULL; +> > rq->part = NULL; > > + > > + if (q->initialize_rq_fn) > > + q->initialize_rq_fn(rq); ->=20 +> > Can we keep this out of the fast path and only do it from the > blk_get_request / blk_mq_alloc_request path? And while were at it > I think those two should be merged as far as the public interface @@ -53,4 +52,4 @@ Are you sure it would help to move the .initialize_rq_fn() calls? Thanks, -Bart.= +Bart. diff --git a/a/content_digest b/N1/content_digest index 8aba08f..5d206ea 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -22,7 +22,7 @@ "> > that initialization code has to be repeated after every\n" "> > blk_get_request() call by adding a new callback function to struct\n" "> > request_queue.\n" - "> >=20\n" + "> > \n" "> > Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>\n" "> > Cc: Jens Axboe <axboe@fb.com>\n" "> > Cc: Christoph Hellwig <hch@lst.de>\n" @@ -34,20 +34,19 @@ "> > block/blk-mq.c | 3 +++\n" "> > include/linux/blkdev.h | 4 ++++\n" "> > 3 files changed, 10 insertions(+)\n" - "> >=20\n" + "> > \n" "> > diff --git a/block/blk-core.c b/block/blk-core.c\n" "> > index a69d420b7ff0..f2540d164679 100644\n" "> > --- a/block/blk-core.c\n" "> > +++ b/block/blk-core.c\n" - "> > @@ -126,6 +126,9 @@ void blk_rq_init(struct request_queue *q, struct re=\n" - "quest *rq)\n" - "> > \trq->start_time =3D jiffies;\n" + "> > @@ -126,6 +126,9 @@ void blk_rq_init(struct request_queue *q, struct request *rq)\n" + "> > \trq->start_time = jiffies;\n" "> > \tset_start_time_ns(rq);\n" - "> > \trq->part =3D NULL;\n" + "> > \trq->part = NULL;\n" "> > +\n" "> > +\tif (q->initialize_rq_fn)\n" "> > +\t\tq->initialize_rq_fn(rq);\n" - ">=20\n" + "> \n" "> Can we keep this out of the fast path and only do it from the\n" "> blk_get_request / blk_mq_alloc_request path? And while were at it\n" "> I think those two should be merged as far as the public interface\n" @@ -69,6 +68,6 @@ "\n" "Thanks,\n" "\n" - Bart.= + Bart. -53b65a971353faa819d0bb6185d2845bf356b56e01563feb9019c722ec4c719a +8a26295d239a156ab77e625130f7f0d751a40bd33a77e743816d7b043b2b7fae
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.