All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: qemu-devel@nongnu.org, peter.maydell@linaro.org
Cc: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>,
	Jason Wang <jasowang@redhat.com>
Subject: [Qemu-devel] [PULL 6/9] net/filter-mirror.c: Remove duplicate check code.
Date: Tue, 23 May 2017 10:43:56 +0800	[thread overview]
Message-ID: <1495507439-1784-7-git-send-email-jasowang@redhat.com> (raw)
In-Reply-To: <1495507439-1784-1-git-send-email-jasowang@redhat.com>

From: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>

The s->outdev have checked in filter_mirror_set_outdev().

Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
 net/filter-mirror.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/net/filter-mirror.c b/net/filter-mirror.c
index 72fa7c2..fd0322f 100644
--- a/net/filter-mirror.c
+++ b/net/filter-mirror.c
@@ -194,12 +194,6 @@ static void filter_mirror_setup(NetFilterState *nf, Error **errp)
     MirrorState *s = FILTER_MIRROR(nf);
     Chardev *chr;
 
-    if (!s->outdev) {
-        error_setg(errp, "filter mirror needs 'outdev' "
-                   "property set");
-        return;
-    }
-
     chr = qemu_chr_find(s->outdev);
     if (chr == NULL) {
         error_set(errp, ERROR_CLASS_DEVICE_NOT_FOUND,
-- 
2.7.4

  parent reply	other threads:[~2017-05-23  2:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-23  2:43 [Qemu-devel] [PULL 0/9] Net patches Jason Wang
2017-05-23  2:43 ` [Qemu-devel] [PULL 1/9] net/tap: Replace tap-haiku.c and tap-aix.c by a generic tap-stub.c Jason Wang
2017-05-23  2:43 ` [Qemu-devel] [PULL 2/9] net/dump: Issue a warning for the deprecated "-net dump" Jason Wang
2017-05-23  2:43 ` [Qemu-devel] [PULL 3/9] virtio-net: fix wild pointer when remove virtio-net queues Jason Wang
2017-05-23  2:43 ` [Qemu-devel] [PULL 4/9] COLO-compare: Improve tcp compare trace event readability Jason Wang
2017-05-23  2:43 ` [Qemu-devel] [PULL 5/9] hmp / net: Mark host_net_add/remove as deprecated Jason Wang
2017-05-23  2:43 ` Jason Wang [this message]
2017-05-23  2:43 ` [Qemu-devel] [PULL 7/9] net/filter-mirror.c: Rename filter_mirror_send() and fix codestyle Jason Wang
2017-05-23  2:43 ` [Qemu-devel] [PULL 8/9] net/filter-rewriter: Remove unused option in filter-rewriter Jason Wang
2017-05-23  2:43 ` [Qemu-devel] [PULL 9/9] e1000e: Fix ICR "Other" causes clear logic Jason Wang
2017-05-23 13:54 ` [Qemu-devel] [PULL 0/9] Net patches Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1495507439-1784-7-git-send-email-jasowang@redhat.com \
    --to=jasowang@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=zhangchen.fnst@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.